Dave Pugmire authored 3 years ago and Kitware Robot committed 3 years ago

6f8d1466 Fixes for compiler warnings.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2547

Dave Pugmire authored 3 years ago and Kitware Robot committed 3 years ago

39054e64 Add corner case unit test.
0a3fd262 Add test file for corner case.
4b0896bd Fix for corner case in particle advection.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Abhishek Yenpure <abhishek@uoregon.edu>
Merge-request: !2545

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

869535b2 Remove uses of ScopedCudaStackSize
4bf8bfb1 Deprecate KdTree3D worklets
5fa402ac Remove recursion from FloatDistance
fc58f4ed Turn on CUDA warnings for unknown stack sizes

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Dave Pugmire <dpugmire@gmail.com>
Merge-request: !2535

Since we have (hopefully) gotten rid of all unbounded recursion and
calls to function pointers or virtual methods, the CUDA compiler should
be able to statically determine the size of the stack needed. Thus, we
shouldn't need `ScopedCudaStackSize` at all.

However, there is one odd case where using it seems to be necessary. It
is unclear why, but that is an issue for another day.

The implementation of the search in the k-d tree is problematic because
it uses unbounded recursion. This is a problem for GPU devices, which
have very short stacks set by how many calls the compiler determines.
This is fixable, but the fix is not trivial.

This class is not used anywhere in VTK-m other than a trivial test.
Thus, I am just deprecating the class. I am also deleting the test, so
the code is not run anymore.

The maximum recursion that could happen was 1 call in, but compilers had
trouble determining that. Split this into 2 non-recursive functions so
the compiler can easily determine the stack depth.

These were previously suppressed because they are unavoidable when
calling virtual methods. But we no longer support virtual methods on
devices (it is deprecated).

These warnings can still happen if you have unbounded recursion. But we
would like to avoid unbounded recursion, so we would like to see these
warnings.

Also turned on other nvlink warnings, which include when a recursive
function call means that the compiler cannot figure out the full
stack depth.

Vicente Bolea authored 3 years ago and Kitware Robot committed 3 years ago

7ea28273 LFS: Set default url to the current origin url

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2532

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

62411796 Add RuntimeDeviceTracker::CopyState

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2540

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

34615a98 Deprecate ArrayHandle::GetDeviceAdapterId

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2534

It is sometimes the case that you want to copy the state of one
`RuntimeDeviceTracker` to another. This is particularly the case when
creating threads in the control environment. Each thread has its own
copy of `RuntimeDeviceTracker`, so when you spawn a thread you probably
want to copy the state of the tracker from the calling thread.

This method is a remenant of when `ArrayHandle` could only store data on
one device at a time. It is now capable of storing data on any number of
devices (as well as the host), so asking for "the" device no longer
makes sense. Thus, this method is deprecated in favor of
`ArrayHandle::IsOnDevice`.

This deprecation leads to fixing some older functionality that still
assumed data could only be on one device at a time.

Fixes #592.

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

1fb11417 Update code to use ArrayCopyShallowIfPossible
5c36eafe Add ArrayCopyShallowIfPossible

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !2529

Vicente Bolea authored 3 years ago and Kitware Robot committed 3 years ago

9fe31c88 Doxygen: Update doxygen hosting URL

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2533

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>

Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>

Gunther Weber authored 3 years ago and Kitware Robot committed 3 years ago

f9eab2ee Replace STL exception in contour tree with VTKM exception

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2531

There were several places in the code that had to check the type of an
`UnknownArrayHandle` and conditionally get or copy that array. This code
is simplified by using `ArrayCopyShallowIfPossible`.

Often times you have an array of an unknown type (likely from a data set),
and you need it to be of a particular type (or can make a reasonable but
uncertain assumption about it being a particular type). You really just
want a shallow copy (a reference in a concrete `ArrayHandle`) if that is
possible.

`ArrayCopyShallowIfPossible` pulls an array of a specific type from an
`UnknownArrayHandle`. If the type is compatible, it will perform a shallow
copy. If it is not possible, a deep copy is performed to get it to the
correct type.

Fixes #572.

Gunther Weber authored 3 years ago and Kitware Robot committed 3 years ago

851c3271 Clean-up 0f CopyArrayByIndices and CopyVecArrayByIndices helpers
89fc3be8 Changed comment style to avoid warning
17caf7f3 Fixed incorrect filename in CMakeLists.txt
c3b3c44e Update CMakeLists.txt
b625ef7d Removed helper function for debugging
dffb7afb Clean-up. Move functor class outside template.
51f73704 Clean-up. Move functor class outside template.
74923266 Added missing const qualifier
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2443

Gunther Weber authored 3 years ago and Kitware Robot committed 3 years ago

ca86402f Provide additional debug info in case contour tree hangs
48d91b99 Throw exception if merge tree gets stuck in a loop
c7ea03ee Throw exception if contour tree gets stuck in a loop

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2420

Sujin Philip authored 3 years ago and Kitware Robot committed 3 years ago

8d62bf12 Fix cuda-opengl interop

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !2528

Kenneth Moreland authored 3 years ago and Kitware Robot committed 3 years ago

f883b5e0 Avoid divide by zero in rendering TriangleIntersections
ede77569 Allow for empty Z bounds in ResetToBounds
4c1514bb Fix divide by zero in CanvasRayTracer
83369ed9 Remove unused fields from Ortho2DRayGen
c1a790db Fix BIH split calculations for empty regions
9ce97352 Fix divide-by-zero in UnitTestCellInterpolate
e4ae3cee Avoid floating point exception in Orthonormalize
f74a2239 Break LUP factorization when invalid matrix found
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Matt Larsen <larsen30@llnl.gov>
Merge-request: !2527

If the camera is not a 3D camera, then it might be the case that the
calling code has not set the bounds in the Z direction. Allow this to
happen as long as you are not using a 3D camera.

The divide by zero happened when mapping a surface to a depth buffer.
Some rays terminated at the origin, which is a singularity in the
project matrix.

This might be indicative of a larger problem. Rays really shouldn't
terminate before the near plane.

There were apparently some fields copy/pasted from the 3D version were
not used in the 2D version (probably because they had no meaning). In
one case, one was erroneously normalized, and could cause a floating
point exception.

When computing the cost for splitting, if a regions was empty you would
get a floating point error when multiplying the (invalid) region bound
(inf or -inf) with the number of points (0). It would then check for NaN
costs and reset that. This worked but caused a floating point exception,
which is problematic for some users.

Instead, check for empty regions before computing the cost and reset the
cost that way.

Singular matrices cannot be LUP factorized, so this condition is
detected and returned in a `valid` flag. However, when the detection
happened, the rest of the computation continued to happen. This could
lead to floating point exceptions, which some applications do not like.
So, when an invalid array is detected, return immediately.

Some functions are supposed to behave correctly when given a NaN. This
might only be valid if floation point exceptions are not trapped, so
disable trapping for these tests.

Some simulations trap floating point exceptions to ensure that their
code is working correctly, and we want VTK-m to work correctly in their
code. To check this, we want to turn on floating point exception
trapping in our test code. This is very implementation-specific, so for
now we are just turning it on for GCC. This will at least alert a
problem on some of the dashboards.