Turn on floating point exception trapping for GCC in tests
Some simulations trap floating point exceptions to ensure that their code is working correctly, and we want VTK-m to work correctly in their code. To check this, we want to turn on floating point exception trapping in our test code. This is very implementation-specific, so for now we are just turning it on for GCC. This will at least alert a problem on some of the dashboards.
Also fix several issues where VTK-m was raising floating point exceptions.
Fixes #600 (closed)
Merge request reports
Activity
This merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: 9fe2b91e
Errors:
- commit c66c644a is not allowed because the following files are not formatted according to the 'clang-format' check:
vtkm/testing/Testing.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically. - commit c1be959b is not allowed because the following files are not formatted according to the 'clang-format' check:
vtkm/Matrix.h
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically.
Warnings:
- the merge request is marked as a work-in-progress.
The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
- commit c66c644a is not allowed because the following files are not formatted according to the 'clang-format' check:
This merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: 775d1484
This merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: 5b3faf2e
Errors:
- commit aea3b3c4 is not allowed because the following files are not formatted according to the 'clang-format' check:
vtkm/exec/testing/UnitTestCellInterpolate.cxx
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically.
Warnings:
- the merge request is marked as a work-in-progress.
The warnings do not need to be fixed, but it is recommended to do so.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
- commit aea3b3c4 is not allowed because the following files are not formatted according to the 'clang-format' check:
This merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: 2edb3fef
added 9 commits
- b01ca530 - Turn on floating point exception trapping for GCC in tests
- 6447b173 - Disable floating point exception traps when testing NaNs
- f74a2239 - Break LUP factorization when invalid matrix found
- e4ae3cee - Avoid floating point exception in Orthonormalize
- 9ce97352 - Fix divide-by-zero in UnitTestCellInterpolate
- c1a790db - Fix BIH split calculations for empty regions
- 83369ed9 - Remove unused fields from Ortho2DRayGen
- 4c1514bb - Fix divide by zero in CanvasRayTracer
- ede77569 - Allow for empty Z bounds in ResetToBounds
Toggle commit listThis merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: ede77569
added 1 commit
- f883b5e0 - Avoid divide by zero in rendering TriangleIntersections
This merge request has been queued for testing. Test results may be viewed on:
- Gitlab CI builders results can be viewed via the Pipelines for this merge request.
- CDash links are also available in the Pipelines page
- CDash (master)
- Buildbot (master) (only visible from inside Kitware)
Branch-at-master: f883b5e0