Skip to content
Snippets Groups Projects

Turn on floating point exception trapping for GCC in tests

Merged Kenneth Moreland requested to merge kmorel/vtk-m:fp-exceptions into master

Some simulations trap floating point exceptions to ensure that their code is working correctly, and we want VTK-m to work correctly in their code. To check this, we want to turn on floating point exception trapping in our test code. This is very implementation-specific, so for now we are just turning it on for GCC. This will at least alert a problem on some of the dashboards.

Also fix several issues where VTK-m was raising floating point exceptions.

Fixes #600 (closed)

Edited by Kenneth Moreland

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 9fe2b91e

  • Errors:

    • commit c66c644a is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/testing/Testing.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c1be959b is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/Matrix.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Maintainer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 4 commits

    added 4 commits

    • b3471f14 - Turn on floating point exception trapping for GCC in tests
    • bd864c8c - Disable floating point exception traps when testing NaNs
    • 8a6316fa - Break LUP factorization when invalid matrix found
    • 775d1484 - Avoid floating point exception in Orthonormalize

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 775d1484

  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Kenneth Moreland added 4 commits

    added 4 commits

    • aea3b3c4 - Fix divide-by-zero in UnitTestCellInterpolate
    • 6053bf14 - Fix BIH split calculations for empty regions
    • 4b8b2751 - Remove unused fields from Ortho2DRayGen
    • 5b3faf2e - Fix divide by zero in CanvasRayTracer

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 5b3faf2e

  • Errors:

    • commit aea3b3c4 is not allowed because the following files are not formatted according to the 'clang-format' check: vtkm/exec/testing/UnitTestCellInterpolate.cxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Author Maintainer

    Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 4 commits

    added 4 commits

    • d23584fe - Fix divide-by-zero in UnitTestCellInterpolate
    • 913628d3 - Fix BIH split calculations for empty regions
    • 6cffe8b5 - Remove unused fields from Ortho2DRayGen
    • 2edb3fef - Fix divide by zero in CanvasRayTracer

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 2edb3fef

  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Kenneth Moreland added 9 commits

    added 9 commits

    • b01ca530 - Turn on floating point exception trapping for GCC in tests
    • 6447b173 - Disable floating point exception traps when testing NaNs
    • f74a2239 - Break LUP factorization when invalid matrix found
    • e4ae3cee - Avoid floating point exception in Orthonormalize
    • 9ce97352 - Fix divide-by-zero in UnitTestCellInterpolate
    • c1a790db - Fix BIH split calculations for empty regions
    • 83369ed9 - Remove unused fields from Ortho2DRayGen
    • 4c1514bb - Fix divide by zero in CanvasRayTracer
    • ede77569 - Allow for empty Z bounds in ResetToBounds

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: ede77569

  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • added 1 commit

    • f883b5e0 - Avoid divide by zero in rendering TriangleIntersections

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: f883b5e0

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading