In ProcessUNIX.c, testProcess.c, and testCommandLineArguments1.cxx, add
assert() calls to tell Clang scan-build that we do not expect certain
pointers to be NULL.

Change-Id: I4a2b035cf58198606b4698c9d0e2048a66f15fd0

This method is no longer used.  The CommandLineToArgvW function
could be used instead on Windows anyway.

Change-Id: I46d9197c80a5ab1515686890f396b1cd631943cf

Rashad M authored 10 years ago and Brad King committed 10 years ago

Change-Id: Ia74a754b34971e71d5352f48839abc8e9a313682

Windows required non-NULL anyways (via strlen) where *nix checked it
after passing it to opendir; just assume non-NULL everywhere and take a
string where possible.

Change-Id: I85c6dc71dd11be58ba61e269c4b40b009924d967

Everything is one character anyways, remove the level of indirection.

Change-Id: I26a59acc4778b93ed68de098e5640c7835d5ee43

Change-Id: I7cd88d0d5c36dc5b66998ff92ad42291a3bea498

Change-Id: I782ed6400f0e0fc855b6245a68597dfeda36ba11

Clinton Stimpson authored 10 years ago and Brad King committed 10 years ago

Change-Id: I23a27b25bf7a2f8f8785c575e1e595f785f9db98

Bob E authored 10 years ago and Brad King committed 10 years ago

QNX not support SA_RESTART signal:

 /* #define SA_RESTART 0x0040 (not supported yet) */

Use it in SystemInformation only if it is defined.

Change-Id: I4a00179fe3f288bb524e002ba37094c73a8a8b08

Steve Dougherty authored 10 years ago and Brad King committed 10 years ago

Change-Id: I6dd8143e0098fab018c0005f8b37db06734fd2c9

SystemTools::ModifiedTime() and
SystemTools::CreationTime() are fixed to work with unicode.

Change-Id: Iaf137340cf2e235d46a79a49621c11890b85ab84

Chuck Atkins authored 10 years ago and Brad King committed 10 years ago

Many Windows filesystem calls (but not all) have a MAX_PATH limitation
of 260 characters (drive letter, colon, backslash, 256 char path, null).
This is especially problematic for interacting with large highly nested
build trees (the boost C++ libraries, for example). This limitation can
be overcome by using extended length paths instead.  By converting
local filesystem and network paths to extended length paths before
passing them to the underlying APIs the maximum path length can be as
large as 32767 characters. The new ConvertToWindowsExtendedPath
function will convert "E:/a.txt" to "\\?\E:\a.txt" and "\\Foo\a.txt" to
"\\?\UNC\Foo\a.txt".

See also the MSDN article on "Naming Files, Paths, and Namespaces":

 http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247.aspx

This also adds a hidden CMake option, KWSYS_TEST_SYSTEMTOOLS_LONG_PATHS,
which, when set to TRUE, will enable the extended length path tests.
This is off by default since if something does go awry, the resulting
leftovers could be difficult to delete manually.

Change-Id: Ib7ac1f657241ed389169678d1c078c0d836f1c7b

The full path for files used by SystemTools tests were preconfigured
in a generated header file by CMake variables.  This begins to get
unwieldy and clutters the CMake files once more variables and files
get added.  In preperation for more file and directory tests being
added, the preconfigured variables are now just the source and binary
directories for which all tests can base themselves off of.

Change-Id: Iae9e11592a3c040ce2e9cc90dbd1ccedfc3129ea

When applying the /* wildcard suffix to a directory, make sure the
direction of the slash getting appended is consistent with the other
slashes in the path, i.e. /foo/bar and /foo/bar/ become /foo/bar/* and
similarly \foo\bar and \foo\bar\ become \foo\bar\*.

Change-Id: I44fcf7e97be65923a37aaed615ba5f4012756893

When we kill a child we send SIGSTOP first so that we can traverse its
child processes recursively.  On unwinding the recursion we then send
SIGKILL.  Current Cygwin has trouble when both signals are sent in quick
succession by the parent process.  Add a usleep(1) after sending the
first signal to give up our time slice and give Cygwin a chance to
process the first signal before sending the second.

Change-Id: I75ab55cf969a0ea6104a9798c761c0ba1fcd1dbc

The cygwin_conv_to_win32_path function is deprecated in favor of
cygwin_conv_path.  Use the latter.

Change-Id: I416c3b3360cd5085ed51dd60375c7e0b3b9ca1cb

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: I51d3522ff01c360542c5f3c25bec9ce56307b809

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: I50bab3aa8ea1d95dce5220d92aaad90916bf33da

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ia355093ee73937ecb276a42bac2b837e3fe496b5

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ieb7479b6cde5edebe0b6b4ec132d8dd7b413d039

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ic80a61bd1bb23f46b2b1875e672a4dc4f93cc7ce

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are turned into strings right away.

Change-Id: I9dfdc37f2317270da2878632d8e02142a641beda

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are assumed to be non-null.

Change-Id: Ibe8e9fc9c932efc55cc18f0e06b2db61bc168817

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are assumed to be non-null anyways.

Change-Id: Iff75a677a051d04919871b3d9efd22ec663cdcd2

It's assumed to be non-null anyways, so just take a string which is done
on non-Windows unconditionally anyways.

Change-Id: I97219d644867287d9f5c789c3d1338a65286554f

Using strlen is much smarter here since we don't have to allocate for
it.

Change-Id: I62f46039a8b5ebc5ab1535a00859a824d77dbaec

It's faster since it doesn't have a second string to loop over.

Change-Id: I8a5917ad356db38e18cc370276edb76ce3027a17

We have them, so save the subtraction.

Change-Id: Iae5a623b2f77323f6bcf701eeb5fb688f900262a

Change-Id: I8f51197cfce502f07f427a7bb1718d9caeba8465

If the container is empty, the loop will be a no-op anyways, so simplify
the code a bit

Change-Id: I641b93744ff677dd1d8f78a6ad88ea0aa284fa39

Change-Id: I5fc21da7073177768088a7298d84632c43f70bd6

If Relative was non-empty, the parameter is unconditionally casted into
a string anyways, so save the allocation.

Change-Id: I835782fa0307c0122cacf032d4937b5646561d7f

Change-Id: I2f02cf1c150019ecef628a322824a52c86c25431

It's weird that find had one (non-inline) overload. Make overloads for
the ctor and .compile() as well so that other code can drop unnecessary
.c_str() calls.

Change-Id: If0da9811728892bdfd1340f51ec9b33524776958

Rather than doing str[str.size() - 1], save pointer arithmetic and just
use the .rbegin() iterator to get the last element of a container.

Change-Id: Iad5cffce4da4d714f19d93273ee1193a576b8f87

MSVC will warn about performance problems for implicit int -> bool
conversions, but it also makes the code cleaner.

Change-Id: Iedc5fc8ebe56e052303b990005379bed0a8ef76a

Change-Id: Ib725299593d9fce88c73fcee2d640def5759b708

It's not needed and just clutters the code.

Change-Id: I9e69621be79b8bfebe6790edae4cdb86e8389733

Include execinfo.h, cxxabi.h, and dlfcn.h under the same conditions
under which we use the APIs from them.  Move their inclusion out of
OS-specific blocks.

Change-Id: I7723e530e2351d259adddd8e570036a562bade05

Declare a private _Hashtable_node<_Val>::operator= without
implementation to ensure no code tries to assign nodes.
The hash_map uses "pair<const _Key,_Tp>" as the value type
so the const key cannot be assigned.

Change-Id: If772e1588c9504df450c18eb0d36dc024db9f2da