CMake 3.4 may crash on this case.  The problem seems to have been
fixed since then, but keep it working by adding a test case now.

Reported-by: Gonzalo Garramuño <ggarra13@gmail.com>

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

1040e690 cmSystemTools: Teach RunSingleCommand to merge child pipes when possible
ce3b713b cmSystemTools: Simplify RunSingleCommand output string construction
dc039cc0 cmSystemTools: Drop redundant condition in RunSingleCommand
ffa2a8c9 cmSystemTools: Rename OUTPUT_NORMAL to OUTPUT_FORWARD to clarify its purpose
92e9bb21 cmcmd.cxx: Remove unused code in __run_iwyu implementation
fb1526f5 cmake: Change `-E chdir` to pass through stdout/stderr directly

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

a15e375c Fix MFC setting on utility targets (#15867)

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

77cd74a3 Print line number of cache parse errors (#11109)

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

18c3714f UseJava: Fix create_javah CLASSPATH handling on Windows

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

53511936 FindPkgConfig: Quote ${_pkgconfig_path} to protect semicolons on Windows

Multi-byte MFC is deprecated, and some projects will not compile if MFC is enabled.

Audit the code to make sure there are no callers that use OUTPUT_MERGE
with separate capture strings.  Then change RunSingleCommand to
implement output merging by giving the child process a single pipe for
both its stdout and stderr descriptors.  This will more cleanly merge
the content on atomic write boundaries in the child instead of on
arbitrary buffering boundaries in the parent.

Assign to the result strings instead setting to empty and appending.
The old approach was left from when we directly buffered output in
the strings.

The output processing loop is already guarded by a condition so we do
not need to repeat the condition inside the loop.

The OUTPUT_NORMAL value is not really "normal" and has only one caller.
Rename it to OUTPUT_FORWARD to clarify that we are explicitly forwarding
the output.

Do not try to capture stderr with OUTPUT_PASSTHROUGH.  RunSingleCommand
will never populate it.

Use OUTPUT_PASSTHROUGH instead of OUTPUT_NORMAL in order to avoid
buffering the output just to re-print it.

Marc Chevrier authored 9 years ago and Brad King committed 9 years ago

Preserve semicolons in the value.

Ashley Whetter authored 9 years ago and Brad King committed 9 years ago

Track the line number while parsing `CMakeCache.txt` files and include
it in a parse failure error message.

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

aea1b036 Fix export of STATIC library PRIVATE dependencies with CMP0022 NEW
e5cbec14 Tests: Use CMP0022 NEW behavior in some ExportImport cases
0ca122fc Tests: Isolate policy changes in ExportImport test

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

8979a107 FindPkgConfig: Fix restoration of PKG_CONFIG_PATH in environment

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

83d63391 ExternalProject: Add option to set `git clone -o` argument

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

6e92f7b2 Help: Document the CMAKE_EXPORT_COMPILE_COMMANDS variable

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

6ccc3070 FindCUDA: Support special characters in path (#15919)

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

3ec92267 install: Do not remove compiler-defined RPATH entries

Brad King authored 9 years ago and Kitware Robot committed 9 years ago

09b2f1c3 Windows: Find Program Files directories more robustly from environment

Rob Gowin authored 9 years ago and Brad King committed 9 years ago

The original value is saved in `_pkg_config_path_old`.  Fix this typo
left by commit v3.1.0-rc1~763^2 (FindPkgConfig: Extend PKG_CONFIG_PATH
using CMake variables, 2014-03-06).

Lior Goldberg authored 9 years ago and Brad King committed 9 years ago

Some compilers may add their own RPATH entries when invoking the linker.
For example, a GCC installation may contain the following definition in
the specs file:

  *link_libgcc:
  %D -rpath <<some specific rpath in which libstdc++.so can be found>>

In this case binaries may contain RPATH entries that CMake did not add.
When we update the RPATH on installation we must preserve these entries
even if CMake thinks the INSTALL_RPATH value should be empty.

Fix this by always using file(RPATH_CHANGE) and teach it to behave as
file(RPATH_REMOVE) if the actual RPATH in the file is empty after
replacing the build-tree RPATH with the install-tree RPATH.  This will
preserve any compiler-added RPATH value instead of removing it.

Adam Rankin authored 9 years ago and Brad King committed 9 years ago

Add a `GIT_REMOTE_NAME` option to `ExternalProject_Add` to support

  git clone --origin <name>

Default to `origin` if not specified.

In Modules/Platform/WindowsPaths.cmake our previously recorded
environment variable combinations no longer seem to be correct.  For
example, a 64-bit cmake binary may see ProgramW6432 in the environment
and end up not considering the "ProgramFiles(x86)" variable.  Instead
check for all possible environment variables in the preferred order and
then remove duplicates.

Reported-by: Shawn Waldon <shawn.waldon@kitware.com>

The target_link_libraries command records the PRIVATE dependencies of a
STATIC library in INTERFACE_LINK_LIBRARIES as "$<LINK_ONLY:dep>".  This
hides the target name from export namespacing logic inside a generator
expression.  When user-written generator expressions reference a target
name they must put it inside a "$<TARGET_NAME:dep>" expression to allow
the export logic to rename the target.  In the case that the private
dependency is not already a generator expression, target_link_libraries
must use "$<LINK_ONLY:$<TARGET_NAME:dep>>" to allow the export logic to
rename the target.

Reported-by: Tamás Kenéz <tamas.kenez@gmail.com>

Use cmake_policy(PUSH/POP) to isolate CMP0022 policy changes.