`char` is unsigned on aarch64.

`char` on aarch64 is `unsigned` and the negative variants for
`PointClassification` end up leaking out when compared with literals
where promotion occurs (as `int`). While `CellClassification` lacks
negative variants, using its enum name helps to keep usage consistent.

Assign the `int8_t` storage size for these `enum` types and store its
type explicitly where used.

GCC on Linux aarch64 is warning that the temporary doesn't live long
enough. I don't see why it wouldn't though as `.Get()` returns a pointer
which shouldn't need any lifetime extension rule to keep alive.

This code was rewritten in dda65158 (BUG: Fix escape character
handling, improve test coverage., 2010-11-24). Given the `- '0'` on the
value guarded by the conditionals, it is likely that these were meant to
be the ASCII value of the numerals 0-9, not the numeral values 0-9. Use
`isdigit` to simplify the expression.

Discovered via Linux aarch64 warnings about `*pos >= 0` being a
tautology.

On Linux aarch64, `char` is unsigned, so comparison with negative
integers is always false.

On Linux aarch64, `char` is unsigned, so integer promotion interferes
with using a literal `-1`.

This predicate clause was introduced in e6d1e71e (BUG: Avoiding debug
assertion on with VS8…, 2009-05-06) in the context of avoiding a debug
assertion in VS8 when using the routine during `CanReadFile` as it opens
in ASCII mode but might actually be a binary file.

On aarch64, this way of testing the high bit is a tautology. Instead,
use the `isascii` function to make the expression meaningful at a
glance.

This warning is about GCC7+ having a different ABI than GCC6. Since GCC6
is no longer supported, we can ignore this ABI difference.

This version has prebuilt binaries for Linux aarch64 available.

For use with aarch64 because the Fedora 39 container has issues
rebuilding due to the removal of the openturns repository.

Disable OSPRay and Anari on aarch64 as they use Intel-specific bits
currently.

Johnny authored 1 month ago and Ben Boeckel committed 3 weeks ago

Note that aarch64 wheels are built on manylinux_2_28 due to the
unavailability of `git-lfs` in CentOS 7 for aarch64 (the manylinux2014
base distribution).

The wheel containers have shifted and they no longer provide a newer
`ninja` package.

Mathieu Westphal (Kitware) authored 3 weeks ago and Kitware Robot committed 3 weeks ago

3fb1c011 vtkType: Convert defines into enum and deprecate some types

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Lucas Givord <lucas.givord@kitware.com>
Reviewed-by: Nicolas Vuaille <nicolas.vuaille@kitware.com>
Merge-request: !11886

Cory Quammen authored 3 weeks ago and Kitware Robot committed 3 weeks ago

f2fc0bf5 ci: exclude TestValuePassFloatingPoint2 from wasm builds
a8551bd5 Add second test for floating point vtkValuePass
2c99a81b vtkValuePass: save and restores GL state to fix rendering issues

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Jaswant Panchumarti (Kitware) <jaswant.panchumarti@kitware.com>
Merge-request: !11921

Alexy Pellegrini authored 3 weeks ago and Kitware Robot committed 3 weeks ago

e5dd56b3 Add vtkOpenXRSceneObserver and vtkOpenXRSceneComponent
349286a8 Include cmath in vtkOpenXRUtilities.h
a83e13e0 Update Windows CI OpenXR Loader version
315b6ed9 Move OpenXR feature request from vtkOpenXRManager to vtkOpenXRRenderWindow

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Merge-request: !11902

vtkValuePass uses a glReadPixels format not supported by GLES 3.0, so
retrieving the floating point values does not work. Exclude this test
like its counterpart TestValuePassFloatingPoint.

Cory Quammen authored 3 weeks ago and Kitware Robot committed 3 weeks ago

b043d4a5 Use VTK_ALWAYS_INLINE even on Windows
6018941f Add more special keywords to parser
f46593b8 vtkFFT.txx: add needed but missing typename keyword

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>
Merge-request: !11937