Kenneth Moreland authored 1 week ago and Kitware Robot committed 1 week ago

868d751e Fix issue with device function calling host

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !178

It is not valid for a method marked `VTKM_EXEC` to call a function
not marked as such. Missed a condition where this happened.

Caitlin Ross authored 2 weeks ago and Kitware Robot committed 2 weeks ago

d492f5a4 support passing MPI_Comm to DataSetWriter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Kenneth Moreland <morelandkd@ornl.gov>
Merge-request: !177

fix a lot of warnings caused by !171

See merge request !175

Kenneth Moreland authored 3 months ago and Kitware Robot committed 3 months ago

1d249aba Load XGC files without paths

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !176

Recent changes to Fides (!172) made specifying paths unnecessary
when using relative files. However, XGC arrays were still checking
for the existence of source paths even when they were not needed.
This change removes the check so that paths can be relative to the
file.

There were a number of warnings (that should have been caught by CI...)
like unused variables and variable shadows.

Caitlin Ross authored 4 months ago and Kitware Robot committed 4 months ago

de691867 DataSetWriter: support writing different types for Fields
8b9efc24 support more types in DataSetWriter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !147

Ben Boeckel authored 5 months ago and Kitware Robot committed 5 months ago

22e999d9 gitlab-ci: remove `dependencies` from jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !174

Historically, `needs` specifies the jobs which need to complete
successfully and `dependencies` specifies the jobs which provide
artifacts which should be used. Modern GitLab discourages using both as
`needs` now supports an `artifacts` key to say "depend on but do not use
artifacts", so remove `dependencies` and use `needs:artifacts` where
necessary.

See: https://docs.gitlab.com/ee/ci/yaml/#needsartifacts

Dave Pugmire authored 6 months ago and Kitware Robot committed 6 months ago

f6ce6883 Address code review.
1551f6ee Add basic reader that computes points.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !171

Add cellsets.

Add surface index cell var.

Read multiple surfaces.

Put num_theta and num_zeta in the json.

Move cellset construction into CellSet.cxx

bug fix. Had the zeta/theta swapped.

Handle the duplicate points stuff.

Use cleangrid filter to cleanup data.

Fix the support for multiple surfaces.

Add option to specify the surfaces to extract.

code cleanup.

Add surface_index variable

Worklet-ize the cell set creation.

Cleanup CellSetGX::PostRead

Undo debug statement in json code.

Add validators to test, fix bug in cellset.

Code cleanup....

Code cleanup.

more code cleanup.

Code cleanup.

Code cleanup...

Fix compiler warnings.

fix compile warnings.

Add filename to test.

code cleanup.

Kenneth Moreland authored 6 months ago and Kitware Robot committed 6 months ago

a82653a5 Update documentation to match changes to BP file finding

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !173

Recent changes support specifying a BP file from a JSON file relative to
the location of the JSON file. Although the old method of specifying
paths is still supported, this new method is preferrable and should be
documented.

The documentation for the schema and the C++ reader interface are
updated to document this new method.

Kenneth Moreland authored 6 months ago and Kitware Robot committed 6 months ago

27f262c9 Update test files to make data relative to JSON
8dd29bac Add ability to load data sources without providing a path

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !172

The previous change made it possible to specify the location of data
files relative to a json file. This is a likely scenerio when creating
files, so make many of the test files to match.

Previously, to load a JSON file with the data in a separate bp
file, you had to specify the directory or path of the data file
in the "paths" map provided to the `DataSetReader` read methods.
This is a problem because it makes the file formant not
self-descriptive. When loading data in an application like
ParaView, you have to type in the directory to the bp file
attached to a magic string defined somewhere in the JSON file.
Every. Damn. Time.

This change allows you to specify a relative path to the data
source .bp file within the JSON file. If you do not specify a
matching path, the reader will look for the .bp file relative to
the JSON file. If you do provide a path, then that path is used.
Thus, the old behavior is preserved.

Dave Pugmire authored 8 months ago and Kitware Robot committed 8 months ago

ac3f4d4e Fix issues when write destructs.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !170

Caitlin Ross authored 9 months ago and Kitware Robot committed 9 months ago

0b585490 fix bp5 metadata issue in test-write
827f70c9 move asan suppressions out of docker build
c98b1b7d ci: update linux builds

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: Ryan Krattiger <ryan.krattiger@kitware.com>
Merge-request: !166

Dave Pugmire authored 9 months ago and Kitware Robot committed 9 months ago

dabb032d Fix compiler warning.
a248f47d Fix compiler warning.
d102768b Coordinates fix for the Fides_Data_Model schema.
55649715 Fix for writing unstructured ds.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !167

When updating to more recent versions of ADIOS2 (2.9 and later), BP5
becomes the default file engine. test-write was not calling ReadMetaData
at the correct time, which caused failures to arise when updating ADIOS2
in CI.

updated vtkm and adios versions, removed unnecessary dependencies
from docker images, improvements to install scripts for dependencies

Kenneth Moreland authored 9 months ago and Kitware Robot committed 9 months ago

9b1144c0 Use `CanConvert` when testing array type in fields
bdf396c5 Support reading vectors of any size

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !162

It is possible that the array type will not match exactly but is still
equivalent. It is safer to use `CanConvert` to ensure the retrival
happens correctly.

FIDES allows you to treat one of the dimensions of an array as a vector.
Previously, FIDES supported only vectors of size 1, 2, and 3. FIDES can
now read vectors of any size.

Fixes: #25

Kenneth Moreland authored 9 months ago and Kitware Robot committed 9 months ago

4a4cde67 Update the minimum VTK-m to 2.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Caitlin Ross <caitlin.ross@kitware.com>
Merge-request: !165

VTK-m 2.1 contains some important features to support reading and writing
vector fields of different sizes. FIDES is updated to require this newer
version to take advantage of these features.

Caitlin Ross authored 10 months ago and Kitware Robot committed 10 months ago

3fd3fa7f use script to install cmake with Dockerfile
f4b8eac0 update vtkm version in readme and user guide
f748da9c update to use vtkm 2.1 in docker images
e301a226 remove vtkm 1.9 builds from CI
425447a2 remove guards for building with vtkm 1.9

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !164

For some reason the version of cmake installed by apt stopped working
for building adios and vtkm, so now use a script to install a more
recent version.