Ben Boeckel authored 1 month ago and Lucas Givord committed 1 month ago

(cherry picked from commit e14e3a4a)

The vtkLabeledContourMapper now renders the labels
on top of the isolines rather than hiding the isolines.

The loose error is 0.057, but the content is correct,
just slightly off-placed since it is text.

- address paraview/paraview#22733
- This commit fixes the logic in the
  `vtkPlotBar::GetBounds(double*, bool unscaled)` method
  to scale the bounds only if `unscaled` is false. Previously,
  it returned unscaled bounds even when `unscaled` was false and
  returned scaled bounds when `unscaled` was true.

(cherry picked from commit 6d90695f)

(cherry picked from commit c6c3a83d)

- address paraview/paraview#22733
- This commit fixes the logic in the
  `vtkPlotBar::GetBounds(double*, bool unscaled)` method
  to scale the bounds only if `unscaled` is false. Previously,
  it returned unscaled bounds even when `unscaled` was false and
  returned scaled bounds when `unscaled` was true.

Mathieu Westphal (Kitware) authored 4 months ago and Lucas Givord committed 3 months ago

(cherry picked from commit 0692322c)

Remove the threshold that existed before because
the new image testing framework is now used, whose
threshold ranges from 0 to 1, and 0.05 is a good default.

Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

This feature allows resizing the charts without having the legend
moving around the chart.

Vincent Le Garrec authored 8 months ago and Lucas Givord committed 6 months ago

(cherry picked from commit a96d29eb)

The error was generated by Visual Studio 2022 /std:c++20:
error C2445: result type of conditional expression is ambiguous:
types 'vtkStdString' and 'const char [2]' can be converted to
multiple common types

Fix warnings detected by gcc 14 when building with
```
SET(CMAKE_CXX_FLAGS "-Wall -Wextra -Wshadow -Woverloaded-virtual -Wno-deprecated -Wno-strict-overflow -Wno-array-bounds -Wunreachable-code -fdiagnostics-color=always -Wstringop-overflow -Wstringop-overread" CACHE STRING "")
SET(CMAKE_C_FLAGS "-Wall -Wextra -Wshadow" CACHE STRING "")
```

The fixes are mostly about shadowed variables and methods

warning: loop variable 'comp' is always a copy because the range of type 'const VecTuple' (aka 'const ConstTupleReference<vtkDataArray, 0>') does not return a reference [-Wrange-loop-analysis]

- Enables automated marshalling for some classes in the following modules
  1. ChartsCore
  2. RenderingContext2D
  3. RenderingLabel
  4. ViewsContext2D
  5. ViewsCore
- Enables automated marshalling for additional classes in the following
modules
  1. CommonExecutionModel
  2. InteractionWidgets
  3. RenderingCore
  4. RenderingOpenGL2

- These new methods wrap around existing methods and make the intentions of get/set clear to WrapSerDes tool.

This causes the compiler to not actually put the functions into the
library. Remove the specifier from methods declared in headers.

These were auto-found and auto-fixed by clang `-Xclang -fixit`

This is needed so that arrays can be dispatched by value including implicit arrays.
Also with this change we don't need to include another header just to dispatch
implicit arrays.

Was able to get value overflow as we were keeping the same type.
Was also allocating an array of x component instead of always 1.

Remove limitations to display values.
Remove limitations to display labels, and fixes labels association.

This is added to provide a way to specify arrays that has more than one
component. Even though SCALARS attribute accepts them, it is not
supposed to be set with more than one component.

We were taking into account spacing twice, which could lead to returning
a nearest point which is out of bounds (and thus get warning when the
tooltip tried to get the value associated).
Spacing is already considered by GetBounds method.

Can choose component to show or magnitude.