Ruslan Baratov authored 8 years ago and Brad King committed 8 years ago

The logic to re-run the download script will be moved elsewhere.

Ruslan Baratov authored 8 years ago and Brad King committed 8 years ago

There is no retries for local files and retry logic is broken for downloads.
Will be implemented in '*-download.cmake' script.

Ruslan Baratov authored 8 years ago and Brad King committed 8 years ago

Use uppercase variables for future 'configure_file' command.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

eb076692 Tests: Select RunCMake.Ninja test cases based on ninja version
8a862a4d Ninja: Support embedding of CMake as subninja project
038e7716 Ninja: Pass all build paths through a central method
7c26a6a2 Ninja: Fix path to soname-d target file
ac3cdd9a Ninja: Convert object file names to ninja paths earlier
d4381cb1 Ninja: Convert link library file names like all other output paths
0397c92a Ninja: Pre-compute "CMakeCache.txt" build target name
3b3ecdfa Ninja: Pre-compute "all" build target name
5ca72750 Ninja: Simplify generation of custom target logical path

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

bdca6838 ExternalProject: Always run update step with non-empty UPDATE_COMMAND

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

41199f8c CPackIFW: Add support for Promoting Updates
6ca6b0dd CPackIFW: Add more known QtIFW releases

The purpose of the `update` step is to run an update on each build
(subject to `UPDATE_DISCONNECTED`).  This is done for version-controlled
source directories.  We should do it for a custom `UPDATE_COMMAND` too.
In particular, when `UPDATE_DISCONNECTED` is used we expect the
`skip-update` step to exist.

Konstantin Podsvirov authored 8 years ago and Brad King committed 8 years ago

Add support for this feature added by QtIFW 2.0.3:

  http://doc.qt.io/qtinstallerframework/ifw-updates.html

Add a `cpack_ifw_update_repository` command as porcelain.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

edcccde7 file: Sort GLOB results to make it deterministic (#14491)

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d7233a04 GHS: Use shorter object file names on collision

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

5a21557b AIX,HP: Allow user to override the default runtime path (libpath)

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

030556b7 cmListFileLexer: Revise C++ coding style using clang-format
e4a92dab cmListFileLexer: Update to flex 2.6

Some test cases need features not available in Ninja < 1.6, so check the
version before running them.

Matthew Hanna authored 8 years ago and Brad King committed 8 years ago

The `CMAKE_PLATFORM_REQUIRED_RUNTIME_PATH` is used by CMake to always
append `-Wl,-blibpath:/usr/lib:/lib` to the link line.  This is needed
by default on these platforms but needs to be overridden in some use
cases (e.g. an environment in which one maintains versioned shared
libraries).  Change our logic to set this value only if it not already
set by the user, project, or toolchain file.

Manually extract the C++ portion of `cmListFileLexer.in.l` into a
temporary file, format it, and then move it back into the original file.
Manually format C++ code inside the lexer actions to match our style.
Then re-generate the lexer.

Revise the documented modifications we need to make to the
flex-generated source file according to the needs of the new version.
Update our own implementation to avoid warnings with flex types.

Reiner Herrmann authored 8 years ago and Brad King committed 8 years ago

Even though the `file(GLOB)` documentation specifically warns against
using it to collect a list of source files, projects often do it anyway.
Since it uses `readdir()`, the list of files will be unsorted.
This list is often passed directly to add_executable / add_library.
Linking binaries with an unsorted list will make it unreproducible,
which means that the produced binary will differ depending on the
unpredictable `readdir()` order.

To solve those reproducibility issues in a lot of programs (which don't
explicitly `list(SORT)` the list manually), sort the resulting list of
the `file(GLOB)` command.

A more detailed rationale about reproducible builds is available
[here](https://reproducible-builds.org/).

Nicolas Despres authored 8 years ago and Brad King committed 8 years ago

Add a `CMAKE_NINJA_OUTPUT_PATH_PREFIX` variable.  When it is set, CMake
generates a `build.ninja` file suitable for embedding into another ninja
project potentially generated by an alien generator.

Nicolas Despres authored 8 years ago and Brad King committed 8 years ago

This gives us a central location to revise paths.

Nicolas Despres authored 8 years ago and Brad King committed 8 years ago

In WriteLinkStatement we convert all target output paths to ninja-style
paths.  Add a missing conversion for the `soname` file name.

Nicolas Despres authored 8 years ago and Brad King committed 8 years ago

In WriteObjectBuildStatement we pass object file names and directories
to several places that expect paths as Ninja sees them.  Convert them to
Ninja paths before all such uses.

Nicolas Despres authored 8 years ago and Brad King committed 8 years ago

All paths generated on Ninja-invoked command lines should be passed
through ConvertToNinjaPath.  Fix ConvertToLinkReference to call this
instead of partially duplicating its implementation.

In `AppendTargetOutputs` we generate a logical build target name for
each UTILITY command.  Simplify the logic to avoid testing the result
of `ConvertToNinjaPath`.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d9fd2f54 Revise C++ coding style using clang-format
82df6dea Empty commit at end of history preceding clang-format style transition
6a13f43f CONTRIBUTING: Add a section on coding style
bf451d9f Add a script to run clang-format on the entire source tree
1e90d78f Configure clang-format for CMake source tree
da60adc3 Tell Git to use a distinct conflict marker size in `.rst` files

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

c7006d2e cmGeneratorTarget: Protect macro code layout from clang-format

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `Utilities/Scripts/clang-format.bash` script to update
all our C++ code to a new style defined by `.clang-format`.
Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

This is an empty commit that precedes an automatic application of
clang-format to update the C++ style of our entire source tree.
This may be helpful to rebase a topic branch that was originally
based on a commit preceding the transition.  One may first rebase
the topic on this commit.  Then use one of the following approaches.

*   Rewrite the topic, including this commit, using `git filter-branch`
    `--tree-filter` with `Utilities/Scripts/clang-format.bash` to update
    the style in every commit.  Rebase the revised topic, excluding the
    rewrite of this commit, on the style transition commit.

OR

*   Add a `.git/info/grafts` entry to change the parent of the first
    commit in the topic from this commit to the style transition commit.
    Rewrite the topic using `git filter-branch --tree-filter` with
    `Utilities/Scripts/clang-format.bash` to update the style in every
    commit.  Then remove the graft, which was resolved by the filter.

See `git help filter-branch` and `git help repository-layout` for
details.

Document that we now define our coding style with `clang-format`.

List all sources in version control and filter out those that we should
not format for various reasons.  Then run the clang-format tool to do an
in-place update.

After discussion among developers we settled on the Mozilla style
with a few tweaks:

* Do not align operator arguments.

* Do not always break after a function return type.

* Limit to 79 columns instead of 80 to fit edge cases
  better in 80-column terminals as CMake has always done.

* Format for C++98 instead of C++11 because CMake is written
  in the former language.

Co-Author: Daniel Pfeifer <daniel@pfeifer-mail.de>

Use a long conflict marker size that is unlikely to be in conflict
with a `=======` section header underline.

The `IMPLEMENT_VISIT_IMPL` macro must preserve a space before the `>`
character in case the `DATATYPE` is a template type ending in `>`.
Manually format the macro layout as clang-format would except for this
space.  Then add markup to tell clang-format not to format this macro.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

c2e8d515 FindBoost: Add checks for component-specific headers