SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

vtkDataArray subclasses now use

ComponentValue --> TypedComponent
TupleValue --> TypedValue

for their type-specific methods.

# Conflicts:
#	Rendering/Annotation/vtkScalarBarActor.cxx

Changed some parameters to be by reference,
instead of by value, including some public API.

The way algorithms were updated (made to execute) with
request meta-data (such as update extent) was very error
prone and counter-intuitive. Added new methods to make
updating with meta-data easier. I also deprecated a number
of methods to set request meta-data. This will encourage
developers to migrate to the new API which is less error-
prone.

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

This tool warns where macros should be using parens.
Fixed many issues it pointed out by either:
 - adding parens (which it can do automatically)
 - removed unused (or rarely used) macros
 - replacing macros with functions, notably vtkMath stuff

VTK no longer supports any compilers that do not provide this type.
Therefore all code conditional on VTK_TYPE_USE_LONG_LONG can be made
unconditional.  Leave the macro defined to tell dependent projects that
APIs using the type are available in case they still support versions of
VTK that make it conditional.

VTK no longer supports any compilers that have `__int64` but not a
`long` or `long long` that is 64-bit.  Therefore all code that is
conditional on VTK_TYPE_USE___INT64 is never used and can be dropped.

This makes the python wrappers ignore WRAP_EXCLUDE, and instead use
the new property WRAP_EXCLUDE_PYTHON that excludes fewer classes.
The WRAP_SPECIAL flag, which used to act as a whitelist for python,
has been removed.

Because this change causes classes to be wrapped in python by default,
some third-party VTK packages might break until they modify their own
CMakeLists.txt files to add WRAP_EXCLUDE_PYTHON where necessary.

Convert double-quote includes to angle brackets:

 git grep -l '#include "sstream"' | xargs sed -i 's/"sstream"/<sstream>/'

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/stl/ | xargs sed -i 's|vtksys/stl/||'
 git grep -l vtksys_stl | xargs sed -i 's|vtksys_stl|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

This is not supported by the new OpenGL2 backend, and doesn't support
new text features, like MathText, FontConfig, or custom font files.

It only implements vtkTextMapper, which now will use a texture-based
implementation, similar to vtkTextActor and friends.

Fixed all clang -Wimplicit-fallthrough warnings:
- Some fixed by adding missing breaks
- Other fixed by adding VTK_FALLTHROUGH statement

Under (modern) clang with C++11:
 #define VTK_FALLTHROUGH [[clang::fallthrough]]

Otherwise:
 #define VTK_FALLTHROUGH ((void)0)

VTK_FALLTHROUGH serves two purposes:
 - under clang, suppresses -Wimplicit-fallthrough warnings
 - makes code more self-documenting

It warned because the division occurs before a
later check for zero.

Change-Id: I35f7ec7c72fcd163a583875a06ee6bb48c8a2235

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

A number of classes in Infovis/Core were not being compiled. This patch:
1) Moves vtkConvexHull2D and vtkGraphAnnotatedLayersFilter to
Rendering/Annotation.
2) Reinstates tests for vtkConvexHull2D, vtkDotProductSimilarity,
vtkArrayNorm
3) Removes unused test for TestTimePoint. The vtkTimePointUtility is
already tested in Common/Core.

Change-Id: I51c23a20897590531435f784602570865ebcb22b

Change-Id: I76fea205f42b796bcfc5d47b6f171d39eadd44a4

Change-Id: I76848acf2f0939f63df6c3194b302eebd6a68009

This change makes more modules dynamically switch between the
rendering backends if they have no OpenGL code, or introduces some
ifdefs in the case of RenderingParallel (which may not be functional
at this stage). Added RenderingFreeTypeOpenGL2 which will also need
some additional work before it is properly integrated with the new
rendering backend, but it surprisingly seems to render on the
desktop.

This commit contains everything needed to get a minimal ParaView
build using the new rendering backend for polygonal rendering.

Change-Id: If8676d41d263b046a54060965fc760b5d4bd64a1

Did this for cxx files where another vtk include was already
using the "" style.  I find this is more correct, especially
for implementation files.

Change-Id: I632178a9af13991ccba96bfaabf5ccc4bfea3c18

This will allow kits to gather all of the required libraries to link
since the modules themselves won't "exist" to link anything when kits
are enabled.

Change-Id: Ic73220c7b97e17a5fbc0aa6c0f7a5e5a61dc6bef

Change-Id: I3dad8993e7057782897ddbe1a232e2df376a91b5

When alpha is zero, the array is indexed past the end.
This junk data is then multiplied by zero so it had
the correct behavior on most platforms, but for some
(e.g. Visual Studio) there is runtime bounds checking
and the program would error. So check for this case
to avoid going past the end of the array

Change-Id: I0d1c8bf94a65983fd8303ffbb7e1c75ca778f614

These tests should work with either backend, and were inadvertently
merged with a hard dependency on OpenGL2 backend.

Change-Id: I25356b499d2317143db37e3fa59b04c5b1c53710

Hopefully it's the indentation that was wrong,
and not that braces were missing... this seems
to be the consensus on vtk-dev.

Warned by clang's experimental -Windent
"warning: statement has higher indent than preceding if, but is not part of it"

Change-Id: I921d4849f1da362e7301ed0cacb2520b3508fd01

Change-Id: I1ae50e6d904856aa67364c955f15c7a016a417e1

Change-Id: If92879d67d11dfc5965ef42a8c173539801b3c98

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

It doesn't appear to have been compiled since at least 6.0, and it
needs more time than we have to fully fix the issues that are now
showing in it.

Change-Id: I5499518f68e32572b5344691ee0fcb4a9b29a6b5

Still many comp warnings and several failed tests remain. Lacking
users, I will deprecate this module rather than fix them.

Change-Id: I4cf58bb1c769ba5fe10b135f3899cd6865c2b9b8

The pointer was being checked for null, but only logged; now return too.

Change-Id: Id9af0f968fc4fd626d9eec79af1ee22aebdc6cc6

Change-Id: I080c1c230f9ded9e4eff76c4dd292cf8fb49682a

The test and data existed, but the test was not in the CMakeLists.txt
file.

Change-Id: Id5bb1af147a5a296ea51cc2baebf56824a3aa25d