SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Sujin Philip authored 8 years ago and Kitware Robot committed 8 years ago

1e31faf4 Fix vtkPolyData Reset

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !1479

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

4f32d092 ibo creation was not setting Index to zero when no cells

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1481

In some cases whenIBOs are being recreated an IBO may
go from having cells to having no cells. In that case
we need to make sure we reset the IndexCount to zero.

Reset should delete the Links and Cells objects so that they can be rebuilt
when needed.

T.J. Corona authored 8 years ago and Kitware Robot committed 8 years ago

bb8dcbaf Create a test array and test case for XML writer dispatch fallback.
c8771337 Create a fallback for writing vtkDataArrays to XML.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1470

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

4267de85 make some methods virtual

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Berk Geveci <berk.geveci@kitware.com>
Merge-request: !1477

For the OpenVR work some methods needed to be virtual
in the core rendernig classes

Bill Lorensen authored 8 years ago and Kitware Robot committed 8 years ago

932b3e4a ENH: Increase coverage for point kernels

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1474

Strive for 100 percent coverage.

1) added tests for exact point interpolation
2) added normals and scalars testing
3) added fuzzy compare for exact points in relevant classes
4) used Get() methods in PrintSelfs to improve coverage

David Lonie authored 8 years ago and Kitware Robot committed 8 years ago

e3d8c856 Work around min/max macros on MSVC.
5a8ddba5 Work around MSVC linker issues.
592d0d6b Fix typo in array dispatch documentation.
74a1dfa9 Remove unneeded header from vtkGenericDataArray.
224dfab4 Reduce dispatches in vtkDataArray.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Berk Geveci <berk.geveci@kitware.com>
Merge-request: !1472

Utkarsh Ayachit authored 8 years ago and Kitware Robot committed 8 years ago

efc6d63e Handle invalid time slices in netCDF/CF files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !1465

Utkarsh Ayachit authored 8 years ago and Kitware Robot committed 8 years ago

196b115e Revert "Added more flags for using OpenGL libraries"

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Berk Geveci <berk.geveci@kitware.com>
Merge-request: !1476

This reverts commit c3d05fab.

The changes are causing failures with ParaView. We don't have dashboard
setup to test that these changes are working.

Sankhesh Jhaveri authored 8 years ago and Kitware Robot committed 8 years ago

49290fb9 Fix color buffer clear color for RenderToImage mode

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1475

Color buffer was being cleared to (1, 0, 1, 0) instead of
(1, 1, 1, 0)

David Lonie authored 8 years ago and Kitware Robot committed 8 years ago

97467119 Disable dual depth peeling on mesa master.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !1473

Sankhesh Jhaveri authored 8 years ago and Kitware Robot committed 8 years ago

ea5c8559 Update the baselines for depth render to image tests
c0119596 Warning message about the use RenderToImage mode
bd4ba00f Clear to a transparent white background in RenderToImage mode
d6e63c64 Revert "Remove unnecessary depth buffer attachment for RenderToTexture"
99316df2 Use depth image scalar type for render to texture mode
4679780d Added superclass API for depth image type
169d03f4 Remove unnecessary depth buffer attachment for RenderToTexture

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1456

See comment.

Alvaro Sanchez authored 8 years ago and Kitware Robot committed 8 years ago

3167f2e3 Fix value-pass's scalar range initialization.
39794205 Fix value array component selection.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1466

'using Superclass::OverloadedMethod;' was throwing linker errors on
MSVC:

error C2487: 'vtkDataArray::SetTuple' : member of dll interface
class may not be declared with dll interface

Explicitly fowarding the call instead works.

Cory Quammen authored 8 years ago and Kitware Robot committed 8 years ago

67c06079 Add some checks before attempting to add attribute arrays
5559c11b Fix picking with 2D actors
5f15afd6 Added test for vtkTextActor picking

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1471

Added warning messages about RenderToImage mode being restricted
to the volume mapper ignoring scene attributes

Added overrides for the methods that take a vtkAbstractArray and dispatch
it, so that the common case of using these methods with NewInstance() can
avoid the dispatch overhead.

Also moved to vtkDataArrayRoundIfNecessary helpers from vtkDataArray.cxx
to vtkMath::RoundDoubleToIntegralIfNecessary so they can be reused from
other array implementations.

Also replaced some vtkDataArray::SafeDownCasts with FastDownCasts and
added more detail to some error messages.

Aashish Chaudhary authored 8 years ago and Kitware Robot committed 8 years ago

a189f37b RayCast mapper renders voxel Id during element selection.
e26054e0 Fixed volume picking test. Disabled depth mask in raycast mapper.
0f9e8d61 vtkHardwareSelector renders VolumetricGeometry.
a024c261 Added VolumePicking test.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ken Martin <ken.martin@kitware.com>
Merge-request: !1360

Max Smolens authored 8 years ago and Kitware Robot committed 8 years ago

bd63a80e Handle case when textDims are NULL

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !1464

This allows the background values outside the bounds of the
volume to be white and transparent in the color image and white
in the depth image. This combination makes sure that the depth
image has an opaque white background outside the bounds of the
volume; while the color image has a transparent white background.

No picking support was provided in vtkOpenGLPolyDataMapper2D.  This
change adds such support. The test added in the previous commit will
now pass when either the OpenGL 1 or OpenGL 2 backend is enabled.

This test fails with the OpenGL 2 backend enabled, but passes with the
OpenGL backend.

Mathieu Westphal (Kitware) authored 8 years ago and Kitware Robot committed 8 years ago

30dcadfd Adding default to switch to remove warnings and explicit falltrough

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Julien Finet <julien.finet@kitware.com>
Reviewed-by: Ken Martin <ken.martin@kitware.com>
Merge-request: !1463

Sean McBride authored 8 years ago and Kitware Robot committed 8 years ago

325fb50d Fix build error with old clangs without UBSan

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1447