Clang (rightly) detects that the `PyCFunction` cast is between invalid
function pointer types. Ignore the warning in-code because we know it is
fine due to the `METH_KEYWORDS` flag for the method.

(cherry picked from commit e83f01c9)

The "reference" extension type for the VTK wrappers has a slot
for x.__round__(digits=0), and if the "digits" parameter was not
set, then an unitialized pointer would be passed instead.  This
change initializes the optional parameter, and also initializes
all non-optional paramters out of an abundance of caution.

Vicente Bolea authored 4 months ago and Vicente Bolea committed 3 months ago

b1b2333a cmake: correct java artifacts in pom.xml

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Merge-request: !11595
(cherry picked from commit 9d49423c)

Jaswant Panchumarti (Kitware) authored 4 months ago and Jaswant Panchumarti (Kitware) committed 3 months ago

- This commit fixes a bug in deserialization of vtkCollection in situation where the item pointers have changed but the total number of items in a collection has not changed since the last time the collection was deserialized.
- Previously, the generated code removed all previous items only when the number of items have changed and added the new items once again. Such a design worked only when the item identifiers remained the same. For example, if the state of a prop collection had a different actor, it would be serialized but never added into the collection.
- Now, the generated code will always remove all previous items and deserialize each individual item from the state before adding it into the collection.

(cherry picked from commit 817d8f41)

This change makes the type checkers aware that these constructors
exist, so that the checkers don't warn about code that calls them.

The type check in the override() method was too strict, it was not
allowing the override to be derived from an abstract base class.

Fixes warning for `re.sub`:

DeprecationWarning: 'count' is passed as positional argument

Recent changes to fix the dependencies of vtkjava_tests for Ninja
have caused problems with dependencies for Unix Makefiles.  This
change makes those previous fixes specific to Ninja, in order to
get the build working properly with Unix Makefiles again.

  -- Changing python class types for current overrides for multiple
  inheritance
  -- Adding proper equality checks for data objects and data arrays
  -- Adding custom `_numpy_attrs` for checking/comparing attributes for
  equality

Check length of offset before taking adrees of a range like `&string[n - 8]`.

Looked for similar cases and also reordered another case to check length first, may or may not have been a problem, but safer this way.

ASan would catch this *during* VTK builds, while generating the wrappings.

A typical threshold is 0.05, but vtkJavaTesting was always
converting it to an int, that is, to zero.

This is done to make sure that the correct
image comparison method is actually utilized.

Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

Clang (rightly) detects that the `PyCFunction` cast is between invalid
function pointer types. Ignore the warning in-code because we know it is
fine due to the `METH_KEYWORDS` flag for the method.

GlobalData are the field data of the root.

Also improve/correct documentation

The warnings were of the following types:

constParameterPointer
constVariablePointer
knownConditionTrueFalse
nullPointerRedundantCheck
redundantAssignment
unreadVariable

The Python unittest.makeSuite() function is gone in Python 3.13,
replace with unittest.TestLoader.loadTestsFromTestCase()

Python 3.13 removed a safety net from PyModule_Type's tp_init slot
that created the module's md_dict member if it was NULL.  This
safety net was removed because, since Python 3.11, the md_dict is
created by tp_new and is never expected to be NULL.  So, in our
own code, we must ensure that tp_new is called before tp_init.

There were a couple code differences between these files, either
typos, omissions, or formatting.  For each difference, it was the
code in vtkParse.tab.c that was correct, so the code in vtkParse.y
has been fixed.

Jaswant Panchumarti (Kitware) authored 6 months ago and Jaswant Panchumarti (Kitware) committed 6 months ago

- without the `-pthread` flag, the build hangs while generating
  serdes sources.