This is a continuation of commit 9a715607
for polyhedrons.

Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

When Global ids can not be used, exit gracefully

Also do not interpolate the corners of Bezier cells

Yohann Bearzi (Kitware) authored 9 months ago and Lucas Givord committed 9 months ago

The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex
protectionThreadedCallbackQueue, fixing race condition

The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex protection

(cherry picked from commit 0cc57f26)

The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex
protectionThreadedCallbackQueue, fixing race condition

The boolean member `Destroying` needs to be atomic because there is one
location in the code that uses it without mutex protection

- Core filters use now SetPolyhedralCells, GetPolyhedronFaces/GetPolyhedronFaceLocations
- For parallel filters or filters using SMP a special care is required with the FaceLocations.
- Adapt existing tests of filters to the API

Yohann Bearzi (Kitware) authored 1 year ago and Lucas Givord committed 1 year ago

`NumberOfThreads` update must be done under a lock so threads waiting
are ensured to see the new size.

When one is calling `Wait()` on a future, the future will try to un its
priors if they are enqueued (not on hold) using a constant-time lookup
through the `InvokerIndex` member. There was a race condition with the
regular path for running tasks. The queue could try to run the prior
while the user does it as well. When this happens, the computed index in
the queue is negative (because the prior has been popped in the regular
pathe). When such occurenc happens, we abandon trying to run the prior.

Setting the invoker's status to `RUNNING` was done in `Invoke()`. It
turns out that there are cases when we want to set it befor calling
`Invoke()`. From now on, each part of the code about to invoke is
responsible for updating its status.

These were auto-found and auto-fixed by clang `-Xclang -fixit`

`NumberOfThreads` update must be done under a lock so threads waiting
are ensured to see the new size.

Instead of regenerating ghosts, it can try to synchronize ghost data
between blocks using process ids. New option to enable this behavior.

Replace 1

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================(.|\n)*.*Program:   Visualization Toolkit\n.*Module:.*\n\n  Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n  All rights reserved.\n  See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 2

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================(.|\n)*.*Program:   Visualization Toolkit\n.*Module:.*\n\n  Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n  All rights reserved.\n  See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 3

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n.*Program:.*Visualization Toolkit\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n.*\n.*\n.*\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 4

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 5

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 6

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 7

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 8

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*==================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n===================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace sandia 1

 cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n-------------------------------------------------------------------------\n.*Copyright 2008 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,\n.*the U.S. Government retains certain rights in this software.\n-------------------------------------------------------------------------\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2008 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-CLAUSE-Sandia-USGov/g' %s

Replace 9

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n.*Language:.*\n\n.*Copyright \(c\) .* Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 1

Replace 10

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 11

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n.*Program:.*\n.*Module:.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n.*\n.*\n.*\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace Valve 1

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\nParts Copyright Valve Corporation from.*\nunder their BSD license found here:\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) 2015, Valve Corporation\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 2

Manual 3

manual 4

manual sandia 1

manual 5

Replace ParaView 1

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Sandia Corporation, Kitware Inc.\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) Sandia Corporation, Kitware Inc\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual Sandia 2

Replace 13

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual sandia 3

replace 14

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual sandia 4

Manual 6

manual 7

manual sandia 5

Manual Kitware SAS 1

manual 7

Manual 10

manual 11

manual 12

manual 15

Fix wrong spdx name

Remove useless cmake copyright

Remove useless copyrights

Remove useless copyright and license statement in python files

Removal glsl

cat files.out | xargs -I %s perl -i~ -0777 -pe "s/.*=========================================================================\n.*\n.*Program:.*\n.*Module:.*\n.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .*for details.\n.*\n.*\n.*\n.*\n.*\n.*=========================================================================\n//g" %s

Replace sandia accel

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\/=============================================================================\n.*\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See LICENSE.txt for details.\n.*\n.*This.*\n.*the.*\n.*PURPOSE.*\n.*\n.*Copyright 2012 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,\n.*the U.S. Government retains certain rights in this software.\n.*\n.*=============================================================================/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) Kitware, Inc.\n\/\/ SPDX-FileCopyrightText: Copyright 2012 Sandia Corporation.\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Manual sandia accel

manual Kitware inc

Manual fixups

Manual 14

Replace 15

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See LICENSE file for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 16

Removing non-standard file header

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\/ \-\*\- c\+\+.*\n\n//g' %s

Manual removal non standard header

Adding custom sandia and lanl licenses

Fix missing header common core

Manual missing headers

Add missing sandia

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\n\/\*\n.*Copyright 2004 Sandia Corporation.\n.*Under.*\n.*license.*\n.*U.*\n.*or.*\n.*statement.*\n \*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2004 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Adding missing sandia licenses

Adding sandia licenses

Adding missing sandia licenses

Replace sandia

Adding sandia module changes

Use new custom license system

Replace sandia

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*-------------------------------------------------------------------------\n.*Copyright 2009 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000.*\n.*the.*\n-------------------------------------------------------------------------\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2009 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Adding missing sandia licenses

Sandia final fixup license

Adding missing sandia license

Fix remaining sandia license

Manual LANL license

Replace sandia BSD

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*----------------------------------------------------------------------------\n.*Copyright \(c\) Sandia Corporation\n.*See Copyright.txt.*\n.*----------------------------------------------------------------------------\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) Sandia Corporation\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Replace Kitware, Inc.

 cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\*=========================================================================\n\n.*Program.*\n.*Module.*\n\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See Copyright.txt.*\n\n.*This.*\n.*the.*\n.*PURPOSE.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) Kitware, Inc.\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual ParaView license

Remove useless license statement in cmake files

Manual licenses

Replace lanl

 cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\n\/\*.*\n.*\n.*Copyright \(c\) 2000.*2009.*Lawrence Livermore National Security, LLC\n.*Produced at the Lawrence.*\n.*LLNL-CODE-400124\n.*All rights reserved.\n.*\n.*This.*\n.*see.*\n.*file.*\n.*http.*\n.*\n.*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) 2000 - 2009, Lawrence Livermore National Security, LLC\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual LANL

NVIDIA license impact

Manual Indiana

Manual copyrights

More manual licenses

More manual licenses

Replace Atamai

 cat a.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*.*\n\n.*Copyright \(c\) 2006 Atamai, Inc.\n\nUse.*\nbinary.*\nconditions.*\n\n1.*\n   form.*\n   the.*\n   license.*\n\n2.*\n   notice.*\n   in.*\n   distribution.*\n\n3.*\n   and.*\n\nTHE.*\nWITHOUT.*\nTHE.*\nPURPOSE.*\nMODIFY.*\nBE.*\n.*\nOR.*\nTHE.*\nPOSSIBILITY.*\n\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) 2006 Atamai, Inc.\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual MIT

Manual licenses

Xdmf2 License

PLY license

Manual VRML licenses

replace Netcdf license

Manual OpenXR license

Manual Licenses

Example Licenses manual

Manual Copyrights and licenses

Manual licensing

Removing empty lines

Manual licenses

Manual final pass

Manual Dicom

Replace all cxx without copyright info

find .  -name "*.cxx" -exec grep -L "SPDX" {} \; | grep -v ThirdParty | grep -v Utilities > files.out

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\A(.*)\n/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-Clause\n$1\n/g' %s

Replace all header missing license

find .  -name "*\.h" -exec grep -L "SPDX" {} \; | grep -v ThirdParty | grep -v Utilities > files.out

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\A(.*)\n/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-Clause\n$1\n/g' %s

Manual from build

Add missing license

Replace copyright.txt

Remove license files

Manual fixes found by building

Fix header testing

Add license in vtkEncodeString

Manual new filters

Review JF

This scenario can happen if the user provides faulty global point ids.
An asymmetrical adjacency map can cause a crash. So instead, we now
double check symmetry while exchanging ghost data and abort if exchanges
are not symmetrical

Fixes #22191

Use MPI_Datatype directly for dynamic type NoBlockSend, so differences
in the type between OpenMPI and MPICH are handled.

Fix a bug in vtkMPICommunicator::Test* and vtkMPICommunicator::Wait*
calls that didn't update the Request handles after the call was
complete.

MPICH uses an `int` for MPI_Datatype, but OpenMPI uses a pointer.
Change the stand-in type in the VTK api so that it can accept either,
and detect the type using a template so we can do the appropriate cast.

This allows those filters to take advantage of MPI 4.x support for
large-message sizes automatically.

This helps to figure out what is supposed to be in the array when
analyzing values post-gather.

Otherwise 2^64-3 can be printed which looks like a serious error. The
values don't matter too much, but avoid distracting behaviors in this
test.

Variants of mpi calls allow for message lengths > MAX_INT in
mpi 4.x and later. Checks the MPI_VERSION to enable. Makes
64bit versions of methods available and checks for overflow if
large messages aren't available.

2 implementations were in the .txx file and cause linking errors in
  ParaView

The class hierarchy of invokers and futures is changed. Now `vtkInvoker`
inherits from `vtkSharedFuture`. This allows to reduce the number of
allocation when pushing a task. There used to be 3 needed, now one
allocation is enough. This also allows to get rid of `InvokersOnHold`,
as the invoker is directly accessible from `Dependents`. There is no
more need to fetch the invoker associated with a future. You can just
run it when the invoker is ready.