The viewport coordinates were pixel centered
which casues a number of issues including missing
border pixels etc. This patch fixes the math
so that viewport coordinates range from the
lower left to the upper right which the origin
being lower left. e.g. pixel 0,0 is the lower
left of the pixel.

This topic addresses issue:

vtk/vtk#15565

I used perl regex to find any groups that spanned a protected: or
private: access specifier.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

vtkView keeps representations provided to `AddRepresentation` call in an
internal datastructure. If a representation was comprised of other
internal representations and it called vtkView::AddRepresentation() then
the order in which the representations would get stored in the internal
datastructure did not match the order in which `AddRepresentation` was
called. Not a big deal, except in cases where the internal
representation expects the outer representation to have been updated (as
was was the case with #16832).

Fixed vtkView::AddRepresentation() to maintain the order in internal
datastructure to match the order in which AddRepresentation is called.

Fixes #16832.

This is a fix for:
vtk/vtk#14310

Windows applications that run for a long time report that rendered
objects do not change. This is because the modified time on a Windows
system is 32 bits. This causes overflows that defeat the modified time
mechanism. This patch defines a new type, vtkMTimeType that is 64
unsigned integer regardless of the architecture.

A mechanism to provide backward compatibility is introduced. The
preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications
that must build against VTK versions that use the "unsigned long" type
for MTime's.

Methodology used to find MTime occurences:
1) Identify files as follows:
   git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
2) Hand edit each of those files replacing "unsigned long" with
   "vtkMTimeType" where appropriate.
3) Temporarily change typedef for vtkMTimeType to "double" to detect
   missing conversions

In module configuration files generated for Qt-based modules, we now
export find_package() calls that find specific components from Qt5 i.e.
`find_package(Qt5 COMPONENTS Widgets)` instead of
`find_package(Qt5Widgets)`.

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

vtkDataArray subclasses now use

ComponentValue --> TypedComponent
TupleValue --> TypedValue

for their type-specific methods.

# Conflicts:
#	Rendering/Annotation/vtkScalarBarActor.cxx

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

This is a patch that fixes issues with
'vtk-kamino-osx-shared-release+mpi+python+tbb' builder.

OpenGL 3.2 does not support line width greater than 1 although
many drivers do support it. This adds valid images for cases
where line width is greater than 1.0

Also minor VisualStudio error check

If you find each qt5 component directly, you have to specifiy the path
to Qt5 config files for each component. If you use
find_package(Qt5 COMPONENT component), then you can specify one Qt5
config directory and all the components will be found.

This is not supported by the new OpenGL2 backend, and doesn't support
new text features, like MathText, FontConfig, or custom font files.

It only implements vtkTextMapper, which now will use a texture-based
implementation, similar to vtkTextActor and friends.

Also removed some dead code as a consequence,
like setting the deallocated pointer to null
then to a new address.

Also removed setting some ivars to null in dtors.

A few good fixes in here that are all related. The biggest is a
fix to OpenGLActor to use the more comprehensive GetIsOpaque
method in determining if an actor is opaque. The old code only
looked at the property's opacity. This is why you would see folks
setting somethings opacity to 0.99 to get it treated as translucent
because the actor code wasn't handling it correctly. This change
resulted in 3 new valid images for tests that were rendering
translucent items as if they were opaque. I removed these tests
from the old backend as I did not want to change the behavior
for that backend.

Next up is depth peeling. OpenGL2 depth peeling would render
a number of peels up to the limit and then just stop. Any geometry
left between the opaque layer and the last translucent layer was
just thrown out.  This created very noticable artifacts and was bad.
This change makes it so that when it gets to the last pass, it will
render all remaining geometry using alpha blending. This is much
better. Fix example if you get the limit to 20 layers and 20 was
not enough to render all the geometry, this change renders 19
layers using depth peeling, then in the 20th render it would add
in all the remaining geometry as last layer. That last layer may
have overlapping geometry which is rendered using alpha blending.

Finally some changes to the PointGaussianMapper. It turns out that
the point gaussian mapper is an translucent mapper which means it
needs the first change, and it is a very tough case for depth peeling
resulting in the second change. While at it I modified this mapper
to render far fewer fragments, resulting is far fewer overlapping
layers and fewer artifacts. Really when using PointGaussian you
should turn off depthpeeling as it is not needed and actually makes
it worse, but these changes will make it better if you happen to have
it on.  Also cleaned up the mapper so that the radius is equal to
the standard devisation of the gaussian, previously it was four
standard deviations.

Change-Id: I62d90b6e424ac0e939033387ed10ba8caac66095

Change-Id: I5adee5e4e29ae03aa4363550a11a044d447ae74b

1. Fixed TimerId type. vtkRenderWindowInteractor defines the TimerId
type as int. vtkContextInteractorStyle now uses the same type.

2. Fixed timer creation. OnSceneModifed() was repeatedly creating new
timers even when previous one hadn't timed out yet. Fixed that. Also,
RenderNow() ensures that old timers are destroyed.

3. RenderNow() now uses Interactor->Render() rather than
Interactor->GetRenderWindow()->Render(). vtkRenderWindowInteractor has
API to control how and if an interaction should trigger a render on the
window. Calling RenderWindow->Render() bypasses all that logic resulting
is mismatch between how interactions work in Render views and Chart views.
This fixes that issue.

Change-Id: I58798615070d97ba9a00ccc21919a5d518bdac22

Thanks to Maarten Beek for pointing this out on the VTK users list.

Change-Id: Ic964ff5bb3b8c69560ff7c80a1a0eee976ff5be3

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

The one shot timer could still be fired after the interactor style
was removed.

Change-Id: I7425293ecf78745504c247169848df0958287be9

Change-Id: I76848acf2f0939f63df6c3194b302eebd6a68009