- Oct 21, 2017
-
-
Jean-Christophe Fillion-Robin authored
The following comment were executed: pip install autopep8 autopep8 --in-place --max-line-length=150 -r . Former-commit-id: 6576c198
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 6c796423
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 73fb5943
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: c3a3403c
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 55cd2522
-
Jean-Christophe Fillion-Robin authored
Rational copied from https://www.python.org/dev/peps/pep-0290/#testing-for-none // ----------------- Since there is only one None object, equality can be tested with identity. Identity tests are slightly faster than equality tests. Also, some object types may overload comparison, so equality testing may be much slower. Pattern: if v == None --> if v is None: if v != None --> if v is not None: // ----------------- Former-commit-id: 48ab42f0
-
Jean-Christophe Fillion-Robin authored
* Use spaces instead of tab * Add missing new lines * Remove trailing spaces * Add missing spaces * Remove redundant backslash between brackets Former-commit-id: 697b15ab
-
Jean-Christophe Fillion-Robin authored
Flake8 is a python source checker. The initial configuration file adds exceptions for all errors, it will iteratively be updated as the code is improved. After installing flake8 with `pip install flake8`, the following shell script was used to craft the list of exceptions: IFS=$'\n' for line in $(flake8 --exclude src/Admin/ . | cut -d":" -f4 | sort | uniq) do # Remove leading space line=$(echo $line | sed -e 's/^[ \t]*//') # Extract error code code=$(echo $line | cut -d" " -f1) echo " # $line" echo " $code," done Currently, `src/Admin/` is excluded. Internally flake8 is wrapper around these tools: * PyFlakes: analyzes programs and detects various errors. It works by parsing the source file, not importing it, so it is safe to use on modules with side effects. It’s also much faster. * pycodestyle: a tool to check your Python code against some of the style conventions in PEP 8 (the style guide for python code). See https://www.python.org/dev/peps/pep-0008/ * Ned Batchelder’s McCabe script: check McCabe (or cyclomatic) complexity. See https://en.wikipedia.org/wiki/Cyclomatic_complexity. To learn more about flake8. See http://flake8.pycqa.org/en/latest/ Former-commit-id: 6f028716
-
Bill Lorensen authored
BUG: Fix VTK build using vtkExternalModuleMacros Former-commit-id: e0952ffa
-
Bill Lorensen authored
Former-commit-id: c9684717
-
Bill Lorensen authored
Former-commit-id: 7bc77180
-
Bill Lorensen authored
Former-commit-id: 33601115
-
Bill Lorensen authored
Former-commit-id: 00f0fbbd
-
Bill Lorensen authored
Former-commit-id: 222dd5da
-
Jean-Christophe Fillion-Robin authored
This commit fixes the configuration and build of VTKWikiExamples as both a VTK remote module and a stand-alone project. It ensure **first and follow-up configurations** produce similar results and behave **identically**. The build was broken following the introduction of Kitware/VTK@e33b90d (ExternalModule: Improve target export to allow build against external module). The commit addresses the issue by introducing the WikiModuleConfig CMake module responsible for: * ensure module information are exported into `VTK_MODULES_DIR` by using `vtk_module_export_info`. * use `vtk_module_config` to ensure that variables like `VTK_LIBRARIES` are set in the current scope when the project is build. Former-commit-id: 766a0e16
-
Bill Lorensen authored
Former-commit-id: f8a272fd
-
Bill Lorensen authored
Former-commit-id: fc81491f
-
Bill Lorensen authored
STYLE: Simplify top level cmakelists Former-commit-id: 79652654
-
Bill Lorensen authored
ENH: Report which Databases/SQL or Video examples are not built Former-commit-id: d23e7365
-
Bill Lorensen authored
ENH: Update minimum required version of CMake from 2.8.8 to 3.3 Former-commit-id: e94a30e1
-
Bill Lorensen authored
COMP: Fix configure error when build against Qt4 Former-commit-id: db433d32
-
Bill Lorensen authored
module.cmake: Update list based on output of WhatModulesVTK.py Former-commit-id: 4914843a
-
Bill Lorensen authored
COMP: Fix VisualizationAlgorithms/PlateVibration build on case sensitive system Former-commit-id: 7c0b1379
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 0d18dec4
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 6a1ae9e7
-
Jean-Christophe Fillion-Robin authored
The module has the "Legacy" prefix anticipating a module named WikiModuleConfig will be added. Former-commit-id: 252f1b51
-
Jean-Christophe Fillion-Robin authored
Note that testing for VTK_BINARY_DIR or Module_WikiExamples are equivalent since both evaluate to True when building the module from within VTK. Former-commit-id: 1bee9a59
-
Jean-Christophe Fillion-Robin authored
Report message are like the following: ``` -- VTKWikiExamples: Building VTKWikiExamples stand-alone -- VTKWikiExamples: Building VTKWikiExamples stand-alone - yes -- VTKWikiExamples: Setting executables prefix -- VTKWikiExamples: Setting executables prefix - no -- VTKWikiExamples: VTK VERSION: 8.1.0(OpenGL2) [...] ``` or ``` [...] -- VTKWikiExamples: Building VTKWikiExamples stand-alone -- VTKWikiExamples: Building VTKWikiExamples stand-alone - no -- VTKWikiExamples: Setting executables prefix -- VTKWikiExamples: Setting executables prefix - yes [prefix: wiki] [...] ``` Former-commit-id: 33514a73
-
Jean-Christophe Fillion-Robin authored
The version now match the one used in VTK 8.1 Former-commit-id: 828be1bb
-
Jean-Christophe Fillion-Robin authored
This commit fixes the following error: ``` [...] -- Found Qt4: /home/jcfr/Support/qt-everywhere-opensource-build-4.8.7/bin/qmake (found version "4.8.7") CMake Error at src/Cxx/Qt/CMakeLists.txt:64 (TARGET_LINK_LIBRARIES): Cannot specify link libraries for target "BorderWidgetQt" which is not built by this project. [...] Former-commit-id: e8c5d86a
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 707e4dc3
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: deba7c26
-
Jean-Christophe Fillion-Robin authored
The test label is already set in ExampleTesting CMake module. Former-commit-id: e9339e03
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: 9b81b509
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: e94bd18f
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: a3dbaad5
-
Jean-Christophe Fillion-Robin authored
Former-commit-id: a4d306f5
-
- Oct 20, 2017
-
-
Bill Lorensen authored
Former-commit-id: 1ef2284a
-
Bill Lorensen authored
Implementing Bill's changes from the C++ version. Former-commit-id: d92fe664
-
Andrew Maclean authored
Former-commit-id: 515a7e60
-