Revert the non-CollapseFullPath part of commit 4feb470a (SystemTools:
Remove GetActualCaseForPath from CollapseFullPath, 2024-10-23).  The
caching may still be useful to other callers later.

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

4feb470a SystemTools: Remove GetActualCaseForPath from CollapseFullPath

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !305

Previously, `CollapseFullPath` internally called `GetActualCaseForPath`
on Windows.  This caused disk access for what otherwise should be a
string operation.  Callers can explicitly call `GetActualCaseForPath`
themselves if they need that behavior.

Issue: cmake/cmake#20214

Brad King authored 6 months ago and Kitware Robot committed 6 months ago

ee3223d7 SystemTools: fix clonefile optimization on macOS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !303

Mike Lundy authored 6 months ago and Brad King committed 6 months ago

Since commit 0969597d (SystemTools: add a clonefile optimization on
macOS, 2022-06-03) input symlinks have been preserved as symlinks,
breaking the intention of producing a copy of the file.

Issue: cmake/cmake#26293

Brad King authored 7 months ago and Kitware Robot committed 7 months ago

68e1f35d SystemInformation: fix use of using

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !302

The automatic conversion from `typedef` to `using` in 7be4043f produced
unexpected results on struct definitions and left over some `typedefs`.
Perform a manual cleanup.

Brad King authored 7 months ago and Kitware Robot committed 7 months ago

5f4012c6 Don't compare to nullptr

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !301

Per C++ Core Guidelines ES.87
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es87-dont-add-redundant--or--to-conditions
Ref: CMake PR 9778

Brad King authored 10 months ago and Kitware Robot committed 10 months ago

510b13b4 SystemTools: Add FileId class and GetFileId function

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !298

Jochem van Boxtel authored 10 months ago and Brad King committed 10 months ago

Add a FileId class, which encapsulates the identifier internally used
by the existing SystemTools::SameFile function. The GetFileId function
retrieves a FileId object for the given file or directory. This makes the
file identifier cacheable to the calling code, so that checking whether
one file is the same as many other candidates can be done faster.

Brad King authored 10 months ago and Kitware Robot committed 10 months ago

beaf1ca1 ConsoleBuf: Fix test case when running under Windows Terminal

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !299

Since commit 4967ccc0 (ConsoleBuf: Fix output for strings that contain
null byte, 2016-11-09) our test case writes a NUL byte to the console.
The behavior of Windows Terminal differs from Windows Console Host
(conhost.exe).  Detect which of these is in use at runtime and adjust
our expected result accordingly.

Brad King authored 11 months ago and Kitware Robot committed 11 months ago

a347a66b SystemInformation: Implement HasFPU on Apple processors
ff14b4f5 SystemInformation: Fix find logic

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !297

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

3c922475 Convert http URLs to https

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !296

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

2310be95 Make variable more local
9fd52415 Range-for loop with const reference
d3f3c38b Use prefix ++ operators for non-primitive types

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !295

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

6624edf2 SystemTools:FileIs{Directory,Executable,FIFO}: refactor for simplicity

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !294

Some were found by Cppcheck

Prevent copy-ctor and dtor to be called.
Found by Cppcheck (constVariableReference)

Prevent unnecessary calls to copy constructor
Found by Cppcheck (postfixOperator)

eliminates C++ logic interlaced with preprocessor logic

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

9f9ff427 SystemTools: Teach RemoveADirectory to handle non-readable directories

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !292

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

dd7d92d6 SystemTools: Implement GetEnv via GetEnvironmentVariableW on Win32

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !291

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

72e677e9 kwsysPrivate.h: Remove unused build-tree copy

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !290

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

7f4459d5 Comeau: Remove undocumented support for this compiler

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !289

scivision authored 1 year ago and Brad King committed 1 year ago

This appears to be from CMake 2.8 era and was undocumented.
Comeau last release 2008.

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

ebb95153 lint: set_property(TEST
f10cb6ad lint: use modern add_test(NAME ... COMMAND ...)
12825be6 lint: use foreach(... IN {ITEMS,LISTS} ...)

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !287

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

3c403fa9 SystemInformation: Replace C-style cast with reinterpret_cast

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !288

Brad King authored 1 year ago and Kitware Robot committed 1 year ago

f26b1b39 SystemInformation: use std::cerr like rest of KWSys

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !286

scivision authored 1 year ago and Brad King committed 1 year ago

From static analysis lint (cppcheck).

scivision authored 1 year ago and Brad King committed 1 year ago

The rest of KWSys source uses std::cerr for error messages.
SystemInformation.cxx was the only KWSys source file use cout, I
think this was just an oversight.