feat: add touch event processing flag to QVTKOpenGLWindow

chore: reformat code

Upon the introduction of the new image testing framework,
this variable should have changed like the default threshold
of vtkRegressionTestImage changed.

The pinch handler fires a `onTranslationChanged` event, so sticking to
that naming convention in QQuickVTKPinchEvent.

This reverts commit ff11f345.

This commit caused issue with Qt event processing, especially
in ParaView: !11788 (comment 1611317)

feat: add touch event processing flag to QVTKOpenGLWindow

chore: reformat code

- This commit removes a left over print statement in
  QVTKRenderWindowAdapter.cxx
- The message is already handled correctly by the opengl
debug logger mechanism in VTK. It is caught by vtkOpenGLMessageHandler
in vtkOpenGLRenderWindow and sent to vtkLog macro. There is no need to print it to console.
- This was not caught until vtk/vtk@5d4edb2c
enabled debug OpenGL context in Qt. The surrounding code never executed at all.
- added a release note for OpenGL debug output feature in VTK.

- Use the GL_ARB_debug_output extension if it is available to log opengl messages. It explains what method caused an invalid operation since error codes returned by `glGetError` are very cryptic and meaningless for the most part.

Raimund Schlüßler authored 4 months ago and Lucas Givord committed 3 months ago

(cherry picked from commit 2617ad04)

Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

- closes #18547
- closes #19383
- Use glad instead of glew for loading GL extension functions
because GLEW has trouble using GLX and EGL in the same build.
- Replaces the VTK::glew module with VTK::glad.
- Removed the utility VTK::opengl module because it is unnecessary
after the changes made to vtkOpenGLOptions.cmake
- OpenGL is now loaded at runtime in desktop platforms.
- For mobile and webassembly, when VTK_OPENGL_USE_GLES is ON,
glad finds and links to the OpenGL::GLES3 library.
- Support for OSMesa is always available from VTK. Users must make
sure the libOSMesa.so or osmesa.dll is installed.
- Support for EGL is always available from VTK in Linux and Android.
Users must make sure libEGL is installed.
- On platforms where multiple render window backends are possible, the
vtkOpenGLRenderWindow is made the default factory override and it's
New method implements runtime tests to determine what render windows
can work. It basically constructs the platform implementation render
window, attempts to initialize it and checks whether it was
successfully intialized.
- The X OpenGL render window class was updated to not call abort.
It also print warnings instead of errors when it fails to open X
display. This allows us to safely test support for GLX at runtime.
- The new environment variable VTK_DEFAULT_OPENGL_WINDOW
can optionally be used to force a render window subclass
at runtime. It is useful to debug support for a fallback render
window on different system configuration.
- Remove usage of unnecessary CMake flag VTK_OPENGL_HAS_MESA.
- Since there is no compile time depedency for OSMesa in VTK,
this commit makes VTK act as if it can always use OSMesa,
obviously when the system executing VTK code has osmesa installed.
- ci scripts will be adjusted in next commits

When using a screen scale that is not 100%, the size of the interactor is
scaled as expected but the event position was not, making it impossible
to interact with widgets, pick points, ...

The replacement API has existed for all of Qt5 at least.

(cherry picked from commit 3b026a2c)

The replacement API has existed for all of Qt5 at least.

Before this change, CMake would quietly configure VTK without this
module when MFC libraries are not available.

Otherwise it loads the system one if exist

mrbean-bremen authored 1 year ago and Lucas Givord committed 1 year ago

QVTKRenderWindowAdapter::context() had never been implemented,
it was introduced during the refactoring of the Qt VTK widgets

(cherry picked from commit 85599a9e)

Sankhesh Jhaveri authored 1 year ago and Lucas Givord committed 1 year ago

The public method `scheduleRender` can be invoked any time the vtk view
needs to be refreshed.

(cherry picked from commit d5a9df63)

Sankhesh Jhaveri authored 1 year ago and Lucas Givord committed 1 year ago

The update observer introduced in 83e48294 was invoking Render
recursively on the render window.

(cherry picked from commit ed6c6e04)

This hardware do not rely on quad-buffering to display stereo content and should use a dedicated
render window class handling the new stereo display mode.

This new stereo display mode requires a dedicated stereo style preventing QVTKOpenGLWindow to blit into
the backbuffer (zSpace API taking care of it)

Updating a lot of baselines to match the new image comparison method

QVTKRenderWindowAdapter::context() had never been implemented,
it was introduced during the refactoring of the Qt VTK widgets

The public method `scheduleRender` can be invoked any time the vtk view
needs to be refreshed.

The update observer introduced in 83e48294 was invoking Render
recursively on the render window.

Lucas Gandel authored 1 year ago and Mathieu Westphal (Kitware) committed 1 year ago

Qt provides a context where the depth test is disabled by default.
In general, vtkRenderer will take care of enabling the dept test in its
Clear() method at the beguining of the render call, but there are use
cases where the depth test is expected to be enabled before VTK renders:
1. If vtkRenderer::EraseOff() was called, Clear() won't be called and the
   depth test is left disabled
2. Render passes that restores the depth test initial value (e.g.
   vtkSSAOPass) will restore a disabled depth test for additional overlay
   renderers that could use EraseOff to prevent useless clearing.

Fixes [Slicer/Slicer#7518](https://github.com/Slicer/Slicer/issues/7518)

Co-authored by: @lassoan

- also resolves this compiler warning
"warning: To use GLEW with Qt, do not include <qopengl.h> or <QOpenGLFunctions> after glew.h [-W#warnings]
warning To use GLEW with Qt, do not include <qopengl.h> or
<QOpenGLFunctions> after glew.h"

Qt provides a context where the depth test is disabled by default.
In general, vtkRenderer will take care of enabling the dept test in its
Clear() method at the beguining of the render call, but there are use
cases where the depth test is expected to be enabled before VTK renders:
1. If vtkRenderer::EraseOff() was called, Clear() won't be called and the
   depth test is left disabled
2. Render passes that restores the depth test initial value (e.g.
   vtkSSAOPass) will restore a disabled depth test for additional overlay
   renderers that could use EraseOff to prevent useless clearing.

Fixes [Slicer/Slicer#7518](https://github.com/Slicer/Slicer/issues/7518)

Co-authored by: @lassoan