Windows required non-NULL anyways (via strlen) where *nix checked it
after passing it to opendir; just assume non-NULL everywhere and take a
string where possible.

Change-Id: I85c6dc71dd11be58ba61e269c4b40b009924d967

Everything is one character anyways, remove the level of indirection.

Change-Id: I26a59acc4778b93ed68de098e5640c7835d5ee43

Change-Id: I7cd88d0d5c36dc5b66998ff92ad42291a3bea498

Change-Id: I782ed6400f0e0fc855b6245a68597dfeda36ba11

SystemTools::ModifiedTime() and
SystemTools::CreationTime() are fixed to work with unicode.

Change-Id: Iaf137340cf2e235d46a79a49621c11890b85ab84

Chuck Atkins authored 10 years ago and Brad King committed 10 years ago

Many Windows filesystem calls (but not all) have a MAX_PATH limitation
of 260 characters (drive letter, colon, backslash, 256 char path, null).
This is especially problematic for interacting with large highly nested
build trees (the boost C++ libraries, for example). This limitation can
be overcome by using extended length paths instead.  By converting
local filesystem and network paths to extended length paths before
passing them to the underlying APIs the maximum path length can be as
large as 32767 characters. The new ConvertToWindowsExtendedPath
function will convert "E:/a.txt" to "\\?\E:\a.txt" and "\\Foo\a.txt" to
"\\?\UNC\Foo\a.txt".

See also the MSDN article on "Naming Files, Paths, and Namespaces":

 http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247.aspx

This also adds a hidden CMake option, KWSYS_TEST_SYSTEMTOOLS_LONG_PATHS,
which, when set to TRUE, will enable the extended length path tests.
This is off by default since if something does go awry, the resulting
leftovers could be difficult to delete manually.

Change-Id: Ib7ac1f657241ed389169678d1c078c0d836f1c7b

The cygwin_conv_to_win32_path function is deprecated in favor of
cygwin_conv_path.  Use the latter.

Change-Id: I416c3b3360cd5085ed51dd60375c7e0b3b9ca1cb

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: I51d3522ff01c360542c5f3c25bec9ce56307b809

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: I50bab3aa8ea1d95dce5220d92aaad90916bf33da

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ia355093ee73937ecb276a42bac2b837e3fe496b5

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ieb7479b6cde5edebe0b6b4ec132d8dd7b413d039

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

Change-Id: Ic80a61bd1bb23f46b2b1875e672a4dc4f93cc7ce

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are turned into strings right away.

Change-Id: I9dfdc37f2317270da2878632d8e02142a641beda

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are assumed to be non-null.

Change-Id: Ibe8e9fc9c932efc55cc18f0e06b2db61bc168817

Ben Boeckel authored 11 years ago and Ben Boeckel committed 10 years ago

The arguments are assumed to be non-null anyways.

Change-Id: Iff75a677a051d04919871b3d9efd22ec663cdcd2

It's assumed to be non-null anyways, so just take a string which is done
on non-Windows unconditionally anyways.

Change-Id: I97219d644867287d9f5c789c3d1338a65286554f

Using strlen is much smarter here since we don't have to allocate for
it.

Change-Id: I62f46039a8b5ebc5ab1535a00859a824d77dbaec

It's faster since it doesn't have a second string to loop over.

Change-Id: I8a5917ad356db38e18cc370276edb76ce3027a17

We have them, so save the subtraction.

Change-Id: Iae5a623b2f77323f6bcf701eeb5fb688f900262a

Change-Id: I8f51197cfce502f07f427a7bb1718d9caeba8465

If the container is empty, the loop will be a no-op anyways, so simplify
the code a bit

Change-Id: I641b93744ff677dd1d8f78a6ad88ea0aa284fa39

Rather than doing str[str.size() - 1], save pointer arithmetic and just
use the .rbegin() iterator to get the last element of a container.

Change-Id: Iad5cffce4da4d714f19d93273ee1193a576b8f87

MSVC will warn about performance problems for implicit int -> bool
conversions, but it also makes the code cleaner.

Change-Id: Iedc5fc8ebe56e052303b990005379bed0a8ef76a

It's not needed and just clutters the code.

Change-Id: I9e69621be79b8bfebe6790edae4cdb86e8389733

Stephen Kelly authored 11 years ago and Brad King committed 11 years ago

Change-Id: I2323e5b6ec35948f6f3ba8967369969e475f4e02

Jiri Malak authored 11 years ago and Brad King committed 11 years ago

Use ISO C header <wctype.h> for towupper instead of relying on the
MS-specific location of towupper in <ctype.h>

Change-Id: If779418eb6752e7b059bcb9e823f64914b4fa101

Clinton Stimpson authored 11 years ago and Brad King committed 11 years ago

SystemTools still had uses of kwsys_ios::ofstream that need changed
to kwsys::ofstream to support utf-8 encoding of filenames.

Change-Id: I308e9cc055295881405b1b079d0653dab37b8d3d

The WindowsFileExists function was originally created to avoid
duplication by the Cygwin and Windows implementations of FileExists.
Now that we use the ANSI API on Cygwin and the Wide API on Windows, one
of the two overloads is always left unused.  Drop the helper functions
and inline the implementations at their respective (single) call sites.

Change-Id: I4d25f98b8b11f0fdce2f360f5f425e0b159b22e5

Change-Id: Icb357202c5591819b9f44b4e4f1376e7c4f7b7b3

Adrien Destugues authored 11 years ago and Brad King committed 11 years ago

Haiku does not define __BEOS__ anymore, so there is no need to guard
these BeOS specific workaround for Haiku.  The workarounds themselves
are not needed for Haiku as it has much better POSIX compatibility than
BeOS did.

Change-Id: I91a1598df764abe0febc9c3828e8bfd47e089cee

Patrick Gansterer authored 11 years ago and Brad King committed 11 years ago

Change-Id: Ifc21dc8ab53867abae9758e6408fef8eac6e4a33

Patrick Gansterer authored 11 years ago and Brad King committed 11 years ago

Move the code for parsing the given key to its own function.

Change-Id: I05eddba48cf7fabd3c48f2175a16457910a47583

Honor the DASHBOARD_TEST_FROM_CTEST environment variable as
well as DART_TEST_FROM_DART.

Change-Id: I8b57f3d50e887dfc96820684f6706336a14d96bd

The loop condition "while ( path.size() > dir.size() )" assumes that
eventually path will be no longer than dir but "c:/" will always be
longer than "/" and loop forever.  Simplify the implementation to avoid
the loop and the assumption.

Change-Id: I5613c7554ebd05b12cfe4882ac3bec4ecaa6e0ae
CMake-Issue: 14283

If the path passed to MakeDirectory() pointed to an existing file (not
directory), it would return true indicating that the directory was
successfully created even though creation of the directory failed.
Now it returns true only when the existing path is a directory and
returns false otherwise.

Change-Id: Ieb3e6352d63868c824df35f19187a8d396f75296

A ".." after the root component of a full path should just be the root
component itself.

Change-Id: I01b4ecc7d9ad0a0a267fa3451ab59e4078be8454
CMake-Issue: 14186

On Windows use CreateFile (with FILE_FLAG_BACKUP_SEMANTICS so it works
for directories), GetSystemTimeAsFileTime, and SetFileTime to touch.  On
other platforms prefer utimensat, then utimes, then utime.

Change-Id: Ie85fe3766661803e66f39975a147cd6f7320ea59
CMake-Issue: 14020

Allocate a buffer large enough to hold the input path when removing a
trailing slash.  Use a local stack buffer when it is large enough and
fall back to heap allocation otherwise.

Change-Id: Ibc4b4c96c7b0fafae9f4b5cd7ea894bdd605a098

Andreas Mohr authored 11 years ago and Brad King committed 11 years ago

Change-Id: If6fc66bb0800c21a19dd06e41afc1eafa305b24e

Do not strip the trailing slash from root components like "c:/" before
passing to stat().

Suggested-by: Patrick Spendrin <ps_ml@gmx.de>
Change-Id: If8fffd6b1178f0edcd6984a8b865c697dae081c7