Jack Guo authored 4 years ago and Brad King committed 4 years ago

The `touch -c` command-line tool does nothing when given a broken
symlink.  Fix `SystemTools::Touch` to do the same.

This was broken by commit 45db0937 (SystemTools: use PathExists where
appropriate, 2017-01-10).

The versions of these compilers previously supported do not
support C++11 that we now require.

Robert Maynard authored 4 years ago and Brad King committed 4 years ago

It is common when running software from a container setup such
as docker that the user is root. Because of this, some permission
checks are pointless as the root user ( uid=0 ) can always do
things such as write to files.

This check is responsible for using the auto type specifier for variable
declarations to improve code readability and maintainability.

The auto type specifier will only be introduced in situations where the
variable type matches the type of the initializer expression. In other words
auto should deduce the same type that was originally spelled in the source

The check flags insertions to an STL-style container done by calling the
push_back method with an explicitly-constructed temporary of the container
element type. In this case, the corresponding emplace_back method results in
less verbose and potentially more efficient code.

Sean McBride authored 5 years ago and Brad King committed 5 years ago

- Find/replace of KWSYS_NULLPTR with nullptr
- Find/replace of NULL with nullptr
- Manually fixed -Wzero-as-null-pointer-constant warnings
- Careful review to fix some comments, string output, etc.

Although `CollapseFullPath` is meant to construct a full path, it
is possible that a caller will provide a relative base path.
In this case, keep leading `../` components from the base path
instead of discarding them.

Taylor Braun-Jones authored 6 years ago and Brad King committed 6 years ago

Compares files in a line-ending-insensitive way.

Kitware Robot authored 6 years ago and Brad King committed 6 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a
new style defined by `.clang-format`.  Use `clang-format` version 6.0.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Peter Wu authored 6 years ago and Brad King committed 6 years ago

LLVM libc++ as included with Mac OS X 10.7 suffers from an issue where
the trailing character is discarded when the delimiter (LF) is not found
within the given buffer size (1024).  The returned length is also 1024
rather than 1023.

This issue results in truncated reads as observed with CMake 3.11.0 on
Mac OS X 10.7 and `cmake -E cmake_link_script link.txt`.

Solve this by replacing `istream::getline` by `std::getline` which does
not trigger the buffering issue.  There is one edge case that I decided
to leave up to the callers though: a file containing `\0` previously
resulted in line truncation, but is now included in the result.

Tested with Mac OS X 10.7 and 10.11:

    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.7 -DCMAKE_CXX_FLAGS=-stdlib=libc++

and `./kwsysTestsCxx testSystemTools`.

Issue: cmake/cmake#15039

Found via `codespell` and `grep`

Ben Boeckel authored 7 years ago and Brad King committed 7 years ago

The function only works on paths which are already properly escaped.

Ben Boeckel authored 7 years ago and Brad King committed 7 years ago

Non-Windows platforms don't have backslash as a separator, however some
projects may want to support Windows paths on non-Windows platforms
(e.g., paths from data files). For those which don't need this, this
allows the search to be faster since it's searching for a single
character.

Hans Johnson authored 7 years ago and Brad King committed 7 years ago

When building with C++11 or greater, use the `nullptr` keyword.

Previously trying to parse a windows-style (backslash separated) path on
Linux would fail.  Make this function handle either kind of separator on
both platforms.

Move the implementation of `SystemTools::ConvertToWindowsExtendedPath`
over to a new function in `Encoding`.  It does not depend on other
things `SystemTools` and will be useful in other KWSys components
that already depend on `Encoding` but not `SystemTools`.

```
testSystemTools.cxx:901:32: warning: comparison of integers of different
  signs: 'size_type' (aka 'unsigned long') and 'long' [-Wsign-compare]
    if (!result || line.size() != size) {
                   ~~~~~~~~~~~ ^  ~~~~
```

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Logic for the size limit argument added by commit 521c5483 (added a
limit to the getline method, 2007-03-01) had an off-by-one error in
truncating the buffer.  Fix it and add a test case.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

Use ComparePath to perform case-insensitive comparison when needed.

Change-Id: I901b1a12ab43655ac44eee2b3e18c3f2630d6c18

This method checks if a path by the given name exists. The problem with
FileExists is that it returns `false` even for broken (or
self-referential) symlinks which may not be what the user wants.

Change-Id: I71b8af6e12a5ae4b1319a3bec83db6c3cef36f90

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I3cdbcb846a205b211ac0f597e2c1c940dc0b7268

Change-Id: I59c150ef46c87bea36bab2822ebd0643aa7b7c2b

Change-Id: I45efddc1638965d17f0207cdf900a44aef8bf0e8

Vitaly Baranov authored 9 years ago and Brad King committed 9 years ago

The GetPath method appends paths to an output vector and also converts
paths to forward slashes.  However, the method should not modify entries
in the output vector that existed prior to the call.  Fix it to only fix
slashes in the entries it added to the vector.  Also add a test case
covering this behavior.

Change-Id: Ie098c3eddbe63ed59f0d393aa6c43ea6c395011d