Document that we now define our coding style with `clang-format`.

Change-Id: I6dea8c3816f277b0e56e074ccd6c64a2cfeb094c

List all sources in version control and filter out those that we should
not format for various reasons.  Then run the clang-format tool to do an
in-place update.

Change-Id: If6d24b3b2e2de1b8e66f7fc2a713d2fd1d579f3d

Use the same format as CMake.  This is the Mozilla style with a few
tweaks:

* Do not align operator arguments.

* Do not always break after a function return type.

* Limit to 79 columns instead of 80 to fit edge cases
  better in 80-column terminals.

* Format for C++98 instead of C++11 because KWSys is written
  in the former language.

Change-Id: I755d3ca9cf2d883e85682fa86cab7127156da861

Do not let clang-format add spaces around the "/" in the macro
definition.

Change-Id: I51dd99b304300b4181c6e35628f3a3c324935b7a

References to `@KWSYS_NAMESPACE@` have no meaning in non-configured
sources.

Change-Id: I4ffa59918d69aefb4835b2d2e84e4c6bf73dd274

Change-Id: I35dbe7cb024d2220e2a7137515d03c9b4dc838ba

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

Add a script to replace our previous per-source license notices with a
much simpler notice.  This will be used in a following commit and then
removed.

Change-Id: I63911c5b21bab6c198f7f65f7facffd6a1df405c

We do not require copyright assignment for contributions to KWSys.
Update the top-level notice to mention "Contributors" explicitly.

Change-Id: Id0bd823b8408b8041584a46c81ab46a8cfbe0c0d

The clang-format tool sorts `#include` lines within contiguous blocks.
Separate blocks with blank lines and sort the include lines within them
so that clang-format does not re-order anything.

Change-Id: I96d6828f470b9a234464972172d46afab322487c

On MSVC we get

    FStream.hxx(149): warning C4100: 'efilebuf' : unreferenced formal parameter

Quiet the warning by casting the argument to `void`.

Change-Id: Ife2e2301b95864b0ae4c8bafe21e8c989110d635

In some cases GetFileType returns FILE_TYPE_CHAR even if it isn't
actual console.

Change-Id: I84b6b7b8b3eebc840fd5464cf1de2e9be24f427e

The current implementation was added by commit 5c8693bc (remove
redundant function and eliminate need for strcasecmp, 2003-04-11).  The
code was taken from Graphviz in 2003 from a source file that at the time
was distributed under terms of the Common Public License, Version 1.0.
While the actual content is simple and likely not copyrightable, clarify
the licensing status by simply re-implementing the function from scratch
using another approach.

Change-Id: I44f72b215577af9e3de234b5ef03113c580a3bd6

Change-Id: I7b5d0b0edb756989d84d7291467256ad48004398

This compiler extension is not universally supported.  Spell out the
function name explicitly, and use __LINE__ to get more-specific
information.

Change-Id: I670d94a85f1ff8112655af62fb710460b3e76f19

Streaming std::endl implies a flush.

Change-Id: I770ee8ef989d096192fc9eb2a372eb2110ebe34c

Borland 5.8 warns about initializations that are immediately followed
by assignments.

Change-Id: I74320629a3112b919b68215ebe74870881b210c5

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

If expected and received characters don't match, output them.

Change-Id: I348b531b85e2d09211c8d4c09eba12200d7ead32

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

std::wstring<>::size() returns characters, not bytes.

Change-Id: Iced3d7246d022e3eea582dbd880ff2c71a145f5d

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

If FaceName wasn't previously present we need to remove it.

Change-Id: I1e463f2b159de15838efe9f504ab5340aa5f2342

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I3a726be174f9799e85d34243182e80cb35c655b5

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Split the before-input and after-output cases since the parent must
act between them.

Change-Id: I14b704ea927c7ce7258d40ac105577a355cdcd13

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Print more information about each failure.

Change-Id: I9c9a0ad628fba6452894eb80251e6fa2bdf1a87f

If only some leading components of the input path exist then convert
those and leave the rest unchanged.  This way if a file path is
constructed using GetActualCaseForPath and created on disk, then a
following GetActualCaseForPath on the same now-existing path will return
the same value.

Change-Id: I6e09a4d411f8bf107312f39d7409ba2d22bf176b
CMake-Issue: 16295

Use ComparePath to perform case-insensitive comparison when needed.

Change-Id: I901b1a12ab43655ac44eee2b3e18c3f2630d6c18

Undefine any `_WIN32_WINNT` value that may be defined on the compiler
command line by clients that are targeting the build at a different
version of Windows than the host.  We must build for the host APIs in
order for the test to be able to configure its console correctly.  Since
the test binary is not installed it does not matter if it is not built
for the client's target Windows version.

Change-Id: Ic3e79550713384c45baf25aa624efbcb5d49d0a4

Currently Microsoft's C++ libraries implementation of std::cout/cerr
can't output Unicode characters but only ASCII or ANSI if locale is set
so we implement and use our own ConsoleBuf which can output Unicode
characters to console and it doesn't matter what locale or console's
codepage is set.

Change-Id: I33053aa229796e84088aa3beb0ebe8bdbebaf3d1

When `GetShortPathNameW` returns a 0 buffer size then we should not call
it again.

Change-Id: I6529013ec3c792796649c25168f6c67b60ac7238

This method checks if a path by the given name exists. The problem with
FileExists is that it returns `false` even for broken (or
self-referential) symlinks which may not be what the user wants.

Change-Id: I71b8af6e12a5ae4b1319a3bec83db6c3cef36f90

Patrick authored 8 years ago and Brad King committed 8 years ago

Take changes used by pkgsrc [1]:

* SCO OpenServer 5.0.7/3.2's command has 711 permission.

[1] http://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/cmake/patches/

Change-Id: Ib9fd7611e2c0b3e10a75b2322c002a8cb266ea89

Patrick authored 8 years ago and Brad King committed 8 years ago

Take changes used by pkgsrc [1].

[1] http://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/cmake/patches/

Change-Id: I3b035ad1835755548250b67e2a7cbadaaf6a4657

Patrick authored 8 years ago and Brad King committed 8 years ago

Take changes used by pkgsrc [1]:

* Add more conditional handling for NetBSD, same as others.
* Treat FreeBSD and DragonFly the same way as NetBSD and OpenBSD.

[1] http://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/cmake/patches/

Change-Id: If94a931dd1609565459eb9891561f341cc990bf0

Remove the last calls to the GetEnv methods with this signature from
KWSys itself.

Change-Id: I9cdb2b060776a00bb698b396c9b33450237cd0b7

Otherwise on e.g. MinGW or Embarcadero it would use POSIX functions
which works only for ASCII paths.

Change-Id: Ib95c79f0bc649e3befb646c6820380ef86108c8a

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

std::basic_filebuf::open(const wchar_t *) isn't part of C++ standard
and it's only present for MSVC but it isn't present in libstdc++ (MinGW)
so we implement this functionality using GNU libstdc++ stdio_filebuf
extension and _wfopen function.

Change-Id: I7df7a1b22ba272db23c8d962cb66ec71a278ef06

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Reduce code duplication.

Change-Id: Ic0fcee68286c8e67bcb6fb58cbc7ca71c30f4c36

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I3cdbcb846a205b211ac0f597e2c1c940dc0b7268

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Some GetEnv callers only need to know whether an environment variable
exists, so provide a direct query for this.

Change-Id: Ib754cb122b53a2a7cc4801fc7198cf1d612ef6f4

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded
to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv)
instead and encode that.

Change-Id: I8cb91f2386eb0efe3ef0a3132d1603217d710b60

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Revise code layout to make introduction of wide character APIs cleaner.

Change-Id: I22301f07eba1e13b954eb938da3305f269d8b754