Vitaly Baranov authored 9 years ago and Brad King committed 9 years ago

The GetPath method appends paths to an output vector and also converts
paths to forward slashes.  However, the method should not modify entries
in the output vector that existed prior to the call.  Fix it to only fix
slashes in the entries it added to the vector.  Also add a test case
covering this behavior.

Change-Id: Ie098c3eddbe63ed59f0d393aa6c43ea6c395011d

Domen Vrankar authored 9 years ago and Brad King committed 9 years ago

Teach these functions to copy directories as directories instead
of files.  Create the destination directory and set permissions,
but do not recurse into the directory structure because these
functions are meant for individual filesystem entries.

Change-Id: I20fae2e159f86285c02c3fd894609e2e51cafdac

Change-Id: I3cc74292e44eb13e8d7c278b67d7270119e2ae4f

Gilles Khouzam authored 9 years ago and Brad King committed 9 years ago

Change-Id: I552e0840b5c84187b67a781621c09b485d3e6048

Gilles Khouzam authored 9 years ago and Brad King committed 9 years ago

We pass a OSVERSIONINFOEXA structure so call GetVersionExA explicitly to
avoid ever calling GetVersionExW with a structure of the wrong size by
mistake.

Change-Id: I892ae0497ef3ca4b38cd2c1c1870d165b0bd8713

Change-Id: Ie06816e1a2a0537c23fb646985a8017087dcf702

Change-Id: I0da93a55af243fe798b9dd5bda4ee30c1bc3fcf9

Drop the KWSYS_STL_HAS_* checks needed only for hashtable compatibility
with old STL versions.

Change-Id: I164a40669881439f5853a72c60ab2065498a69c0

Drop "kwsys/stl/*" and "kwsys_stl::" and use the standard headers and
namespace instead.  Drop the now-unused KWSYS_STL_HAVE_STD check.

Change-Id: I6105fd32cd8f0e487e03f58927976e824a53f0d8

Remove the KWSYS_STL_STRING_HAVE_{ISTREAM,OSTREAM,NEQ_CHAR} checks
and drop their uses.

Change-Id: I1e95dbbd724a7e08db67f71533da381b9d943f53

Remove the checks for KWSYS_IOS_USE_ANSI and KWSYS_IOS_HAVE_STD and uses
of the results.

Change-Id: I67d756a70a08636175a9d131c6b3e27a3f74b175

Change-Id: I930fdf45832e09b01b653a21ed0be159bebbf45d

Change-Id: Icdc68acbac4b393ff753598dff331ac22df68b73

Use the standard headers and namespace instead.  We no longer support
compilers without them.

Change-Id: Iafb19d28462e9302df06eecc8ae42b48a9577a21

If honor_umask is set, the umask is queried and applied to the
given permissions when calling SetPermissions.

Change-Id: I302231a2ae7f0c4610eb47fdb256fa02934ecd8c

Added a new TestFileAccess function that can be used to test for
access to a file or directory using the requested combination of
permissions.  This is basically a wrapper of the POSIX access()
function.

Change-Id: I3e1769a2438cc2047a97850c5f312e36ed695799

The FileExists function always ensures that a file is readable on
POSIX systems by using access() with R_OK.  This was due to bug #809.
Publicly state in the header file that this is being done.

Also simplify the implementation so that redundant code handling the
isFile parameter is eliminated.

Change-Id: Ie07bec7aa5dd2bca07bb3244c01c0a29587aa437

This is necessary to satisfy a warning in
Modules/Platform/CYGWIN.cmake.

Change-Id: If5b5a661d3b82f4f3542ed34e96e4ccff4cbce8d

Change-Id: I53978f9da16eef6652566a59d8569fed07fe33a4

This file has not been used since commit af059ea0 (Remove unused
CheckCXXSourceRuns cmake module, 2011-04-13).

Change-Id: If438199d6f4dd97528c6399c8dd87cfebe6fc288

Pass flags to the SunPro compiler to improve the level of C++ standard
support beyond the default.  Do this only in a standalone build so that
host projects can set flags for us.

Change-Id: Ic9a84debfa939caf00b7ad99887793e885c35371

Mattias Ellert authored 9 years ago and Brad King committed 9 years ago

Apply KWSYS_PROPERTIES_C to our C-only library, not the main library.

Change-Id: I550196e6c6bdf613abfa7c7a19ec0b36d7f09553

James Johnston authored 9 years ago and Brad King committed 9 years ago

Teach testProcess-1 to stress-test kwsysProcess for leaks that lead to
failure by running the test many times.

Change-Id: I1906b935f4096161f30f418918653087f91dde16

James Johnston authored 9 years ago and Brad King committed 9 years ago

Change-Id: Id632329f3593da977ce52de42ad39af4e6fb01dd

Sebastian Schuberth authored 9 years ago and Brad King committed 9 years ago

Change-Id: Iddfc4048d412ea9ecf1546802d6faca645c7ff36

Jean-Christophe Fillion-Robin authored 9 years ago and Brad King committed 9 years ago

Some operating systems allow directories to be opened and read like
files while others do not.  Simply check for a directory type first.

Change-Id: Ic970f662d5aa887ace4a8f166ede7e0d1531d0d6

Jean-Christophe Fillion-Robin authored 9 years ago and Brad King committed 9 years ago

Fix the following error reported by valgrind memcheck tool:

==31549== 256 bytes in 1 blocks are definitely lost in loss record 1 of 1
==31549==    at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31549==    by 0x44F3AA: kwsys::SystemTools::DetectFileType(char const*, unsigned long, double) (in .../kwsysTestsCxx)
==31549==    by 0x43D75E: CheckFileOperations() (in .../kwsysTestsCxx)
==31549==    by 0x43FAC5: testSystemTools(int, char**) (in .../kwsysTestsCxx)
==31549==    by 0x434A2B: main (in .../kwsysTestsCxx)

Change-Id: I42db9774bf30889b67921a538e00c1bf519a2719

James Johnston authored 9 years ago and Brad King committed 9 years ago

Since commit faff2ab0 (Process: Wait for children to terminate on Ctrl+C,
2015-06-30) we do not report the GetLastError() from CreateProcessW()
failure.  Refactor kwsysProcessCleanup to pass the error code in so
that we can always call GetLastError() immediately after a failure.

Change-Id: I2b7950560c8bde2e29070c87f4927c51dca32e39

Store and pass the interruptDelay parameter as 'unsigned int' so
it does not have to be converted to pass to testProcess_sleep.
Otherwise some compilers warn about the signed->unsigned conversion.

Change-Id: I1edf6dbc852231834a5de82c5b14f84ac8018c1f

James Johnston authored 9 years ago and Brad King committed 9 years ago

kwsysProcess leaked a file descriptor every time a process would start.
This was causing exhaustion of available file descriptors on some
operating systems (e.g. Mac OS X).

Change-Id: I78eed0755f9766065c36460ffab468b2d7d1df12

James Johnston authored 9 years ago and Brad King committed 9 years ago

Two new tests were added to testProcess:
 * Test 9 is constructed of the root test process, a child process,
   and a grandchild process.  The grandchild ignores all Ctrl+C signals
   and then sleeps.  The child runs the grandchild normally.  The root
   process runs the child in a new process group, sends it a Ctrl+C
   signal, and then lets the process expire to prove that the child was
   blocked waiting for the uninterruptable grandchild to die.
 * Test 10 is constructed of the root test process, a child process,
   and a grandchild process.  The grandchild sleeps and processes
   signals normally.  The child runs the grandchild in a new process
   group.  The root process runs the child in a new process group as
   well, sends it a Ctrl+C, and then verifies that: (1) the child does
   indeed terminate with an interrupt signal, (2) the child did not
   expire, proving that it retransmitted the signal to the sleeping
   grandchild before waiting for the grandchild to terminate.

Change-Id: Iba5bee546a82eb61a41d4194341e9382a00279d4

James Johnston authored 9 years ago and Brad King committed 9 years ago

kwsysProcess_SetOption now allows you to specify a new
kwsysProcess_Option_CreateProcessGroup option, which creates the
process in a new process group (Windows/UNIX) and a new session
(UNIX).  Child process groups receive signals separately from their
parents.  This allowed for the introduction of the new
kwsysProcess_Interrupt function, which allows one to safely request
the child process in its own group to terminate.  The Ctrl+C handler
also manually sends that signal to child process groups, since it's
no longer automatic.

Change-Id: Id0a420ad65f1b1c1d299ac0eb95fbb8b50a52409

James Johnston authored 9 years ago and Brad King committed 9 years ago

The following applies to any KWSys console app on Windows or UNIX
(e.g. cmake.exe):  The default behavior of such an app when Ctrl+C is
pressed is to call ExitProcess or _exit.  If the user has a
subprocess open (e.g. by way of cmake --build) when this happens, the
subprocess will be orphaned because the kwsys-based program will
immediately exit.  This can lead to odd behavior such as the orphaned
subprocess continuing to run and mix output with the operating system
shell.  We prevent this behavior on Windows by tracking all
subprocesses and waiting for their termination when Ctrl+C is pressed
before allowing the call to ExitProcess to proceed.  On UNIX, we reap
every single child process and then call _exit.

Change-Id: Iebd2eedb1c06719e9797dd5b1309d473145476a8

James Johnston authored 9 years ago and Brad King committed 9 years ago

Code for delaying/sleeping has been unified into one location.

Change-Id: I234f3e1be667539e8126f7ed24aec95fe14284b3

James Johnston authored 9 years ago and Brad King committed 9 years ago

Change-Id: I821de08dd10b5f1f4af6287a5d7dc6e03e2c1e78

Use a case-insensitive map key since paths of all case combinations
should map to the same actual case.  This may reduce the number
of copies of each path differing only by case in the map.

Change-Id: Ic5460fcf14fa263d45ef1909bf80a81c6f4791a4

Convert the drive letter to upper case in the actual output value
instead of just our internal memoization map key.  This was broken by
commit 08b2dcff (Fix GetActualCaseForPath for UNC paths, 2010-08-16).

CMake-Issue: 15642
Change-Id: Iee7148616370d1be4be052c74b7a5d802ad47d93

The shell escaping APIs are very specific to CMake and are not used by
other KWSys clients.  They are moving to CMake proper, so drop them from
KWSys.

Change-Id: I422c76f6515d51a352e112828533d6e3fd1a5440

Use an algorithm that simply reverses CommandLineToArgvW to construct
a string encoding command line arguments.

Change-Id: I52a5d27679da3962eda36b8bb6a1fb714a735a1d

Change-Id: I5eb32dd2b8ca02800f15375dd4959c5c80d9ba7a