SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/stl/ | xargs sed -i 's|vtksys/stl/||'
 git grep -l vtksys_stl | xargs sed -i 's|vtksys_stl|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

Fixed all clang -Wimplicit-fallthrough warnings:
- Some fixed by adding missing breaks
- Other fixed by adding VTK_FALLTHROUGH statement

Under (modern) clang with C++11:
 #define VTK_FALLTHROUGH [[clang::fallthrough]]

Otherwise:
 #define VTK_FALLTHROUGH ((void)0)

VTK_FALLTHROUGH serves two purposes:
 - under clang, suppresses -Wimplicit-fallthrough warnings
 - makes code more self-documenting

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

A number of classes in Infovis/Core were not being compiled. This patch:
1) Moves vtkConvexHull2D and vtkGraphAnnotatedLayersFilter to
Rendering/Annotation.
2) Reinstates tests for vtkConvexHull2D, vtkDotProductSimilarity,
vtkArrayNorm
3) Removes unused test for TestTimePoint. The vtkTimePointUtility is
already tested in Common/Core.

Change-Id: I51c23a20897590531435f784602570865ebcb22b

Change-Id: I76fea205f42b796bcfc5d47b6f171d39eadd44a4

Change-Id: I76848acf2f0939f63df6c3194b302eebd6a68009

Did this for cxx files where another vtk include was already
using the "" style.  I find this is more correct, especially
for implementation files.

Change-Id: I632178a9af13991ccba96bfaabf5ccc4bfea3c18

These tests should work with either backend, and were inadvertently
merged with a hard dependency on OpenGL2 backend.

Change-Id: I25356b499d2317143db37e3fa59b04c5b1c53710

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

The pointer was being checked for null, but only logged; now return too.

Change-Id: Id9af0f968fc4fd626d9eec79af1ee22aebdc6cc6

This fixes a off-by-one bug.  This mapping has to be set explicitly
because the subsequent recursive mapping generator needs to stop
just short of the root.

Change-Id: If749f88a6a7fb7b036ea49e81637187eaf14ad0d

Change-Id: Ie966625bee8ca7fde4617d05f6dfcf85078c0696

Done using a few regular expressions & find & replace.
Fixes many -Wextra-semi warnings.

Change-Id: I5ef603e88d4c0a390cfb2d22d8d92c21bf554024

Change-Id: I5a22aad3fe45399a88ce46eb60568bcd80ad2fbd

Change-Id: I45a40f94ee78f3a696bfebdd66374aa4d4be0dbd

This fixes a bug where the wrong rows in the input table could be
used to calculate a value in the output table.

Change-Id: Ibd5dac710f3a8ea1e19971c8fbd13a5742aa86a6

This generates an error with Visual C++ 2013.
See http://blogs.msdn.com/b/vcblog/archive/2013/06/28/c-11-14-stl-features-fixes-and-breaking-changes-in-vs-2013.aspx
This is a breaking change in VS2013 to be conform to C++11:
"You must #include <algorithm> when calling std::min() or std::max()"

Change-Id: Ib43dfe0b7bf249d23bd6539f0f3b0e38bc9af5b2

This class collapses the rows of the input table such that one
particular column (the IndexColumn) no longer contains any duplicate
values.

Change-Id: I03dddb9b1ebbe61ddd4955241ea58244322840b9

Previously any FieldData stored in the input tree was not
transferred over into the output tree.

Change-Id: Ie8c980ec3bd893dbc45a6341e3c5f2cec370a283

Add to the Testing/Data directory ExternalData content links mirroring
the content and layout we use from the VTKData/Data directory.

Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
for all data directories added from VTKData/Data.  This will bulk-fetch
all test input data currently used by tests of any module, enabled or
not.  We can make the DATA{} references more granular later.

Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
ExternalData module to populate the real data files.  Replace references
to VTK_DATA_ROOT in test command lines (after -D) with references to
VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
the VTKData repository.

Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
input data are now handled through ExternalData and Testing/Data content
links.

Change-Id: Id02490b76ea2e161b9038188264a4830485039d8

Baseline images are now referenced by ExternalData content links stored
directly in each module source tree.  Drop the old VTKData baseline
subdirectory name from the vtk_add_test_* signatures.

Change-Id: I5bdc7a5bf87fc7c8fa77dcd50b79f2f54d6eba31

Change-Id: I7c6ab523d022f28256bb9d29e23ebacbcf6eafdd

Tell calls to vtk_add_test_(cxx|python|tcl) explicitly when there is no
valid baseline image to avoid passing -V unnecessarily.

Change-Id: Ibe5aecdfa076446ddda0b95e814483eb6622af73

Refactor */*/Testing/Cxx/CMakeLists.txt to use the vtk_add_test_cxx
function instead of direct add_test calls.

Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd

When tests are run with -I they must be linked with InteractionStyle.

On the Mac, tests must be linked with MACOSX_BUNDLE to get keyboard
focus.

Change-Id: I938c4b6a5a44ca5792f5eeaaa946cc9fb27e1110

Before this change, the wrong name was mentioned when the comparison
array does not exist.

Change-Id: Ib4cee14ae78c5d111ecd245c2d4ab7f553aed8e2

I accidentally overwrote this change in a previous commit.

Change-Id: I00683705cd171094831e0c7c6deb858300b7ab02

Previously we modified the first input tree by adding the difference
array to it.  It makes more sense that we add this array to the
output tree instead.

Change-Id: I201dfa428ce882a22fbf5ce92896565a490667e6

Identified with -Wunused-member-function.
Improves coverage a little.

Change-Id: I42804da51ff74838b641720ba15ae1b2832ada71

vtkTreeDifferenceFilter crashed on some platforms in PrintSelf. If
IdArrayName, ComparisionArrayName or OutputArrayName were null,
PrintSelf crashed on some platforms.

Change-Id: Iacba9dc5b9c355115a9eec3df875fa0a55f3903a

Fix warnings related to vtkExtractSelectedTree.

Change-Id: I49ebdcf731f41112e04ac5421b214139b20dae61

Add a new filter (vtkExtractSelectedTree) to extract or
remove subtrees from a vtkTree.
The implementation is similar to vtkExtractSelectedGraph.

Change-Id: Ib31ed4b26634f37a53b44369cd32ac414f050a08