- Jan 22, 2016
-
-
- Jan 21, 2016
-
-
70788e92 Remove temporary allocations when calling cmHasLiteral{Suf,Pre}fix. bd2384f5 Optimize cmMakefile::ExpandVariablesInStringNew. ad9394f4 Remove temporary allocations in cmMacroHelper::InvokeInitialPass. f9599ed4 Remove temporary allocations by extending the lifetime of the retval. 275f2a85 Remove temporary allocations when calling cmGeneratorTarget::GetName.
-
f9e45ab9 FindXalanC: New module to find the Apache Xalan-C++ library
-
1787269e cmake: Fix `-E time` argument passing to child
-
-
c8daac35 GetPrerequisites: Define api-ms-win-* files as system libraries (#15691)
-
Kitware Robot authored
-
- Jan 20, 2016
-
-
When the first argument passed is a std::string, we need to take it by const&, otherwise we copy the string and trigger a temporary allocation. This patch removes a few 10k temporary allocations when running the CMake daemon on the KDevelop build dir. This hotspot was found with heaptrack.
-
We can remove the temporary allocations required for the default-constructed t_lookup passed into the openstack by refactoring the code slightly. Furthermore, we use a vector instead of a stack, since the latter is based on a deque which is not required for a heap / lifo structure. This patch removes ~215k allocations. This hotspot was found with heaptrack.
-
This code used to convert std::string's to raw C strings only to put that back into a std::string. This patch thus removes ~70k temporary allocations when running the CMake daemon on KDevelop. This hotspot was found with heaptrack.
-
See also Herb Sutter's article on the "most important const": http://herbsutter.com/2008/01/01/gotw-88-a-candidate-for-the-most-important-const/ When running the CMake daemon on the KDevelop build dir, this removes some hundreds of thousands of temporary allocations. This hotspot was found with heaptrack.
-
This happens quite often from within comparisons such as in NamedGeneratorTargetFinder or FindGeneratorTargetImpl. It is the top hotspot of both, number of allocations as well as number of temporary allocations - the majority of calls lead to temporary allocations. In raw numbers, this patch removes ~1E6 temporary allocations of 1.5E6 temporary allocations in total when running the cmake daemon on the KDevelop build dir. That is 2/3 of the total. This hotspot was found with heaptrack.
-
-
Brad King authored
Since this command was introduced in 2002 it has incorrectly constructed the child process command line by concatenating arguments separated by spaces with no quoting. Fix this by passing the command argument vector directly to RunSingleCommand without an intermediate quoting and re-parsing step. Reported-by:Andrey Pokrovskiy <wonder.mice@gmail.com>
-
Brad King authored
In multi-config generators we must tell `ctest` what configuration to test. Reported-by:Taylor Braun-Jones <taylor@braun-jones.org>
-
Brad King authored
Check CMAKE_CONFIGURATION_TYPES instead of CMAKE_CFG_INTDIR in order to recognize multi-config generators. Then use $<CONFIG> to pass the configuration value.
-
1040e690 cmSystemTools: Teach RunSingleCommand to merge child pipes when possible ce3b713b cmSystemTools: Simplify RunSingleCommand output string construction dc039cc0 cmSystemTools: Drop redundant condition in RunSingleCommand ffa2a8c9 cmSystemTools: Rename OUTPUT_NORMAL to OUTPUT_FORWARD to clarify its purpose 92e9bb21 cmcmd.cxx: Remove unused code in __run_iwyu implementation fb1526f5 cmake: Change `-E chdir` to pass through stdout/stderr directly
-
a15e375c Fix MFC setting on utility targets (#15867)
-
77cd74a3 Print line number of cache parse errors (#11109)
-
18c3714f UseJava: Fix create_javah CLASSPATH handling on Windows
-
53511936 FindPkgConfig: Quote ${_pkgconfig_path} to protect semicolons on Windows
-
Kitware Robot authored
-
- Jan 19, 2016
-
-
Clinton Stimpson authored
Multi-byte MFC is deprecated, and some projects will not compile if MFC is enabled.
-
Brad King authored
Audit the code to make sure there are no callers that use OUTPUT_MERGE with separate capture strings. Then change RunSingleCommand to implement output merging by giving the child process a single pipe for both its stdout and stderr descriptors. This will more cleanly merge the content on atomic write boundaries in the child instead of on arbitrary buffering boundaries in the parent.
-
Brad King authored
Assign to the result strings instead setting to empty and appending. The old approach was left from when we directly buffered output in the strings.
-
Brad King authored
The output processing loop is already guarded by a condition so we do not need to repeat the condition inside the loop.
-
Brad King authored
The OUTPUT_NORMAL value is not really "normal" and has only one caller. Rename it to OUTPUT_FORWARD to clarify that we are explicitly forwarding the output.
-
Brad King authored
Do not try to capture stderr with OUTPUT_PASSTHROUGH. RunSingleCommand will never populate it.
-
Brad King authored
Use OUTPUT_PASSTHROUGH instead of OUTPUT_NORMAL in order to avoid buffering the output just to re-print it.
-
Suggested-by:Gilles Khouzam <gillesk@microsoft.com>
-
Brad King authored
-
-
Brad King authored
-
Preserve semicolons in the value.
-
Track the line number while parsing `CMakeCache.txt` files and include it in a parse failure error message.
-
-
-
8979a107 FindPkgConfig: Fix restoration of PKG_CONFIG_PATH in environment
-
83d63391 ExternalProject: Add option to set `git clone -o` argument
-
6e92f7b2 Help: Document the CMAKE_EXPORT_COMPILE_COMMANDS variable
-
