Bradley Lowekamp authored 7 years ago and Brad King committed 7 years ago

Remove code that gives the preprocessor trouble when `_FILE_OFFSET_BITS`
is not defined, e.g. on 32-bit machines.  It was behind `#if 0` anyway.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

88d4dd4b CommandLineArguments: use std::string in GenerateHelp()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !60

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

8717ac15 DynamicLoader: use std::string instead of strcpy() + strcat()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !59

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

749b7506 ProcessUNIX: Use monotonic clock in kwsysProcessTimeGetCurrent() for POSIX

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !57

While a process is running, it is possible for other processes such as
NTP to alter the system clock in large jumps.

To make the measurement of how long a process has taken to run
impervious to such large jumps it is helpful to use a monotonic clock.
This is a clock that takes an arbitrary starting point that does not
change.

clock_gettime() is a POSIX method that implements this clock. This is
not available on all platforms, so this commit adds a check for its
presence. If the monotonic timer is available, use that in
kwsysProcessTimeGetCurrent(), otherwise falls back to previous
non-monotonic behaviour.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

5d2aff9d ProcessWin32: use strdup() instead of open coding it
cf8beae3 ProcessUNIX: use strdup() instead of open coding it

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !56

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

3b8fefea remove pointer checks before calling free()
6d7eb3a1 CommandLineArguments: do not check variable before delete[]

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !55

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

ce55a255 testSystemTools: fix some copy'n'paste issues
73c491e8 processUNIX: fix not null terminated buffer during error reporting
13e02b76 processUNIX: close intermediate file descriptor in error case
862562ce SystemInformation: fix potential off-by-one write

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !54

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

6599eda6 testRobustEncoding: restore format flags for std::cout before exiting

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !53

in case readlink uses the complete buffer (1024) it will truncate the
result and return 1024 assigned to ll. the subsequent buf[ll] will then be
out of bounds.

the fix assumes, that a truncated result is as useful as experiencing an
error during readlink, hence falling back to /proc/self/exe.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

6ca15069 SystemTools: make Getcwd() more efficient on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !52

Only do one conversion attempt and write that directly to the target buffer. Do
the uppercasing of the drive letter only in the ASCII domain, not in wide chars.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

41c93d97 Remove unnecessary testIOS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !51

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

a5046656 SystemTool: remove unused Convert*MacroString()
caaef6bb testSystemTools: avoid strcpy()

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !50

This test was meant to cover the `kwsys/ios/*` headers, but they were
removed in commit 15a16826 (Remove include <kwsys/ios/*> and
kwsys_ios:: compatibility layer, 2015-08-20).

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

aa9f3a82 macOS: Account for deployment target when checking for utimensat

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !49

The SDK for macOS 10.13 adds `utimensat`, but the symbol is not
available at runtime on older macOS versions.  Check the deployment
target before using the symbol.

Issue: cmake/cmake#17101

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

c8cfe4e0 SystemTools: Drop SplitProgramFromArgs function

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !48

This was used only by CMake's get_filename_components() command, which
has now been re-implemented independently.  The operation is not
well-defined (string parsing should not depend on filesystem content),
so remove it.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

80652055 Directory: Use Windows Extended Paths

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !47

Steven authored 7 years ago and Brad King committed 7 years ago

Teach `Load` to access the filesystem using extended paths to handle
long absolute paths.  Add a test case.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

da61baff Added cmake settable property to enable the macro
6d73752d Allow KWSYSPE_USE_SELECT macro to be overriden at compile time.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !43

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

da8a9e65 SystemTools: make GetFilenameName handle either kind of slash

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !46

Previously trying to parse a windows-style (backslash separated) path on
Linux would fail.  Make this function handle either kind of separator on
both platforms.

Brad King authored 7 years ago and Kitware Robot committed 7 years ago

dfa13188 Fixed a couple of trivial clang -Wunused-macros warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !44