Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Slam
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
KEU-ComputerVision
Slam
Merge requests
!429
An error occurred while fetching the assigned milestone of the selected merge_request.
[fix] Fix loop closure bugs
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
[fix] Fix loop closure bugs
fix/FixLoopClosureBugs
into
master
Overview
1
Commits
5
Pipelines
2
Changes
1
Merged
Julia Sanchez
requested to merge
fix/FixLoopClosureBugs
into
master
7 months ago
Overview
1
Commits
5
Pipelines
2
Changes
1
Expand
Goal
Fix remaining bugs in loop closure process in library.
Changes
Fix query/revisited bad initialization order in registration process
Fix loop closure registration covariance
Fix segfault due to change in keypoint type
Add comments
Checklist
Camel case everywhere except for ROS variables/parameters
Lower case for local variables and lambda functions
Upper case for members, methods and tool functions (in Utils)
Precise namespace when calling a function (or this->X or classe.X)
Align code (for multiline if and while, "&&" or "||" go in upper line to ensure alignement)
Check your spaces
between if, while, for and parenthesis
between operators and variables: e.g. a + b
after ","
Mind your commit titles/desc (plurals, he/she + "s", correct tags, title should begin by a verb...)
Function names should start with a verb, variable names should start with a name
Macros should be between {}
Do not use negative boolean (i.e. noJoe)
Check minimal size of the types (double -> float -> int -> uint)
Check const and ref in functions arguments
References should be written "type& name", not "type &name"
Update documentation
Add MR labels [ROS]/[ROS2]/[PV]
If ros/ros2, update task table
here
Add a comment over each non trivial function in header files
Add a header to each new file
Edited
7 months ago
by
Julia Sanchez
1
0
Merge request reports
Activity
All activity
Filter activity
Deselect all
Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Please
register
or
sign in
to reply
Loading