Skip to content
Snippets Groups Projects

[PV][refact] Refact loop parameter and warning

Merged Tong Fu requested to merge refact/PV/RefactLoopParameters into master
All threads resolved!

Goal

add offset of loop closure is a parameter to add a offset between query submap and revisited submap when two frames of loop is so far that icp can not compute the registration.

Previously, in pv wrapping add offset is in the advanced parameters of loop closure. Now we make it out of advanced parameters.

Changes

  1. add offset of loop closure is now in the general setting of loop closure category
  2. Add warning in pv wrapping when loop closure is not detected by teaserpp

Results

Screenshot_from_2023-12-18_10-58-31

Edited by Tong Fu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julia Sanchez
  • Tong Fu added 2 commits

    added 2 commits

    • 274777ff - [refact] Add warning when loop closure is not detected
    • b627820f - [refact] Make AddOffset not advanced parameter for loop closure

    Compare with previous version

  • Tong Fu resolved all threads

    resolved all threads

  • Tong Fu changed the description

    changed the description

  • Tong Fu added 14 commits

    added 14 commits

    • b627820f...df36d516 - 12 commits from branch master
    • 5e90b05a - [refact] Add warning when loop closure is not detected
    • 8650750a - [refact] Make AddOffset not advanced parameter for loop closure

    Compare with previous version

  • Julia Sanchez approved this merge request

    approved this merge request

  • Tong Fu added 7 commits

    added 7 commits

    • 8650750a...923e8314 - 5 commits from branch master
    • 543d5131 - [refact] Add warning when loop closure is not detected
    • fde90c38 - [refact] Make AddOffset not advanced parameter for loop closure

    Compare with previous version

  • Tong Fu enabled an automatic merge when the pipeline for fde90c38 succeeds

    enabled an automatic merge when the pipeline for fde90c38 succeeds

  • Tong Fu mentioned in commit fbe418e3

    mentioned in commit fbe418e3

  • merged

  • Please register or sign in to reply
    Loading