Skip to content
Snippets Groups Projects
  1. May 03, 2016
  2. Apr 29, 2016
    • Brad King's avatar
      Format include directive blocks and ordering with clang-format · e1c77472
      Brad King authored
      
      Sort include directives within each block (separated by a blank line) in
      lexicographic order (except to prioritize `sys/types.h` first).  First
      run `clang-format` with the config file:
      
          ---
          SortIncludes: false
          ...
      
      Commit the result temporarily.  Then run `clang-format` again with:
      
          ---
          SortIncludes: true
          IncludeCategories:
            - Regex:    'sys/types.h'
              Priority: -1
          ...
      
      Commit the result temporarily.  Start a new branch and cherry-pick the
      second commit.  Manually resolve conflicts to preserve indentation of
      re-ordered includes.  This cleans up the include ordering without
      changing any other style.
      
      Use the following command to run `clang-format`:
      
          $ git ls-files -z -- \
              '*.c' '*.cc' '*.cpp' '*.cxx' '*.h' '*.hh' '*.hpp' '*.hxx' |
            egrep -z -v '(Lexer|Parser|ParserHelper)\.' |
            egrep -z -v '^Source/cm_sha2' |
            egrep -z -v '^Source/(kwsys|CursesDialog/form)/' |
            egrep -z -v '^Utilities/(KW|cm).*/' |
            egrep -z -v '^Tests/Module/GenerateExportHeader' |
            egrep -z -v '^Tests/RunCMake/CommandLine/cmake_depends/test_UTF-16LE.h' |
            xargs -0 clang-format -i
      
      This selects source files that do not come from a third-party.
      
      Inspired-by: default avatarDaniel Pfeifer <daniel@pfeifer-mail.de>
      e1c77472
    • Brad King's avatar
      Source: Stabilize include order · 180538c7
      Brad King authored
      Each source file has a logical first include file.  Include it in an
      isolated block so that tools that sort includes do not move them.
      180538c7
    • Brad King's avatar
      Utilities/Release: Stabilize include order in WiX custom action · 0e7bca92
      Brad King authored
      In `detect_nsis_overwrite.cpp` we include windows.h first, and we must
      preserve that.  Place the include in an isolated block so that tools
      that sort includes do not move it.
      0e7bca92
    • Brad King's avatar
      Tests: Stabilize include order in MFC, VSXaml, and VSWinStorePhone · eb817be0
      Brad King authored
      These tests use a precompiled header that must be included first.
      Include the header in an isolated block so that tools that sort
      includes do not move it.
      eb817be0
    • Daniel Pfeifer's avatar
      Tests: Stabilize include order in StringFileTest · eda313b4
      Daniel Pfeifer authored and Brad King's avatar Brad King committed
      This test generates a header file which is not self-contained.
      Include it in a separate block of includes so that tools that
      sort includes do not move it.
      eda313b4
    • Daniel Pfeifer's avatar
      CursesDialog: add missing cmState include · 7110b754
      Daniel Pfeifer authored and Brad King's avatar Brad King committed
      7110b754
    • Brad King's avatar
      Modules: Remove unused CMakeTestWatcomVersion.c file · d7a5f255
      Brad King authored
      This file has not been used since commit v2.8.10~218^2~7^2 (Watcom:
      Simplify compiler version detection, 2012-08-13).
      d7a5f255
  3. Apr 28, 2016
  4. Apr 27, 2016
  5. Apr 26, 2016
  6. Apr 25, 2016
  7. Apr 24, 2016
  8. Apr 23, 2016
  9. Apr 22, 2016
    • Brad King's avatar
      Merge topic 'fix-bison-flex-command-escaping' · eadc6db8
      Brad King authored and Kitware Robot's avatar Kitware Robot committed
      fd73bb60 Help: Add notes for topic 'fix-bison-flex-command-escaping'
      f56a0ddd FindBISON: Fix BISON_TARGET macro for special characters in path (#16072)
      3d13492e FindFLEX: Fix FLEX_TARGET macro for special characters in path (#16072)
      eadc6db8
    • Brad King's avatar
      Merge topic 'autogen-updates' · 76e793b9
      Brad King authored and Kitware Robot's avatar Kitware Robot committed
      84946c73 Tests: QtAutogen: Same source name in different directories test
      9c6fa684 Autogen: Generate qrc_NAME.cpp files in subdirectories
      488ea8c7 Autogen: Generate not included moc files in subdirectories (#12873)
      66caae45 Autogen: Check added for name collisions of generated qrc_NAME.cpp files
      663d093d Autogen: Check added for name collisions of generated ui_NAME.h files
      8295d437 Autogen: Check added for name collisions of generated moc files
      d350308a Help: Improve AUTOMOC documentation layout
      76e793b9
    • Brad King's avatar
      Merge topic 'xcode-c_str' · eb874070
      Brad King authored and Kitware Robot's avatar Kitware Robot committed
      2263949b cmGlobalXCodeGenerator: do not pass char* to cmSystemTools::CollapseFullPath()
      2b25ce30 make cmGlobalXCodeGenerator::XCodeEscapePath() take a std::string&
      ffedf352 make cmGlobalXCodeGenerator::BuildObjectListOrString::Add() take a string&
      6100bdff cmGlobalXCodeGenerator: directly call CreateString() with std::string
      eb874070
Loading