COMP: Improve source download strategy for Assimp project

This commit partially reverts ce3d6a91d (Convert external projects to zips)

It avoids check-sum verification failure in the following scenarios:

• the branch with the patches is updated to include additional patches.

• the git server re-generate the cached archives with a new approach leading to different checksums. see [1], [2] and [3] for discussion of similar issues with eiter GitLab or GitHub

It also references the branch imstk-v3.3.1-2016-07-08-a8673d482 (equivalent to fixCompilationError). The associated naming convention is documented at https://gitlab.kitware.com/iMSTK/assimp/-/blob/welcome/README.md

[1] Gitlab release tarball stability https://forum.gitlab.com/t/gitlab-release-tarball-stability/41888

[2] Why are the md5 checksums for download archives different? https://forum.gitlab.com/t/why-are-the-md5-checksums-for-download-archives-different/41649/2

[3] Github Archive URL checksums have changed https://github.com/spack/spack/issues/5411

added Priority: high Topic: Build incident labels

Do: test

This merge request has been queued for testing. Test results may be viewed on:

• Gitlab CI builders results can be viewed via the Pipelines for this merge request.
• CDash links are also available in the Pipelines page
• CDash (master)
• Buildbot (master) (only visible from inside Kitware)

Branch-at-master: 9b901a6d

This looks good, but i've had mixed result with this strategy, maybe it's a configuration issue on my side but in multiple cases i've seen updates to the SHA in the cmake result in build failures when no git fetch executed on configuration and then the resulting checkout of the SHA fails as it doesn't exist in the local repository.

This is intermittent and I haven't seen it in a while here https://gitlab.kitware.com/VROrthognathic/OrthognathicTrainer/-/blob/master/Superbuild/External_iMSTK.cmake i'm calling fetch explicitly for example

it's somewhat hard to reproduce as it needs

• An update in the upstream repository
• A local copy with an earlier commit
• An update to the SHA in the CMAKE

approved this merge request

merged

mentioned in commit 06d595da

i'm calling fetch explicitly for example

This is frustrating for sure and it should be addressed.

cases i've seen updates to the SHA in the cmake result in build failures

A regression was introduced in CMake 3.20.0 and then fixed in 3.20.3, see https://github.com/Kitware/CMake/commit/5e941a545bf5882ddf101cad383dc815fb651f26

I am wondering if this could have been the source of the problem.

As a side note, moving forward, we will simplify OrthognathicTrainer based on approach used in KitwareMedical/SlicerCustomAppTemplate

If the issue happen again, make sure to reach out.

Cmake 3.20 - 3.20.3 sounds about right, with regard to orthognatic trainer just wait, andrew did some refactoring that might affect that, it's working atm ... i'll keep the CustomAppTemplate in mind for the next project setup