Skip to content
Snippets Groups Projects

BUG: Fix attributes when they don't have the expected value

Merged Harald Scheirich requested to merge VROrthognathic/iMSTK:feature/coerce-attributes into master
All threads resolved!

When loading sometimes the incoming attributes do not agree with what is expected by the meshes, this casts arrays that are selected to be attributes (e.g. normals) to the expected type. See also #305 (closed)

Merge request reports

Pipeline #228725 passed

Pipeline passed for b7317d30 on VROrthognathic:feature/coerce-attributes

Approval is optional

Merged by Sreekanth ArikatlaSreekanth Arikatla 3 years ago (May 14, 2021 2:44pm UTC)

Merge details

Pipeline #228733 created

Pipeline created for 2ed1a1e5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Harald Scheirich added 2 commits

    added 2 commits

    • 50712cb4 - Refactor cast to use template macro
    • c9d6ef46 - Replace image cast with new calls

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Harald Scheirich resolved all threads

    resolved all threads

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: d3785c5d

  • Harald Scheirich added 6 commits

    added 6 commits

    Compare with previous version

  • do:test

  • @andrew.wilson run into an issue when checking the texture coords, the RigidBodyDynamics2 example breaks under this MR, the texture coords produced by SurfaceMeshFlyingEdges only have 1 component, we're processing output from VTK here. What's the fix ? just warn if the number of components is wrong ?

  • added 1 commit

    • 2e2c61cc - Warn instead of CHECK for invalid number of components

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 2e2c61cc

  • The dashboard reports build errors

  • After its passing it looks good to me.

  • do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 2e2c61cc

  • added 1 commit

    • b7317d30 - Add /bigobj to MeshIO library and failing examples

    Compare with previous version

  • do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • Gitlab CI builders results can be viewed via the Pipelines for this merge request.
    • CDash links are also available in the Pipelines page
    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: b7317d30

  • mentioned in commit 2ed1a1e5

  • Please register or sign in to reply
    Loading