Brad King authored 5 years ago and Kitware Robot committed 5 years ago

7fe3e874 cmCPackLog: Fix support for multiple log message tags
74f2c0ea cmCTestTestHandler: Remove extra layer of parentheses
7c2767ef cmCTestMultiProcessHandler: Explain testRun ownership in comments
303e8134 CTest: Simplify some boolean conditions
51565abe cmMessageCommand: Remove extra layer of parentheses
b1cfaf7b cmVSSetupHelper: Remove unused SmartBSTR copy operations
3f4c4e7a cmVSSetupHelper: Fix SmartBSTR copy operations
a8ca5aea cmMakefileTargetGenerator: Check for null before using a pointer
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Acked-by: Artalus <artalus-mail@yandex.ru>
Merge-request: !3715

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

3b2b0282 Source sweep: Replace std::ostringstream when used with a single append

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3726

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

aaf59120 Source sweep: Replace cmExpandList with the shorter cmExpandedList

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3725

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

232f5bd6 FindLibLZMA: Find debug/release variants on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3714

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

b14bcd91 cmListCommand: Use cmSubcommandTable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3723

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

66c2714f cmStringCommand: Use cmSubcommandTable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3721

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

4c8741eb CPack/STGZ: Require explicit acceptance or refusal of license

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3717

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

2a71a039 ctest: rename TRACK to GROUP

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Zack Galbreath <zack.galbreath@kitware.com>
Merge-request: !3707

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

20792679 ctest_build: ignore ANSI color

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3702

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

197c5e12 Source: Add cm::optional
170fcd71 Extend C++17 feature checks to require std::optional

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sebastian Holtermann <sebholt@web.de>
Merge-request: !3644

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

74eef37b Utilities/Release: Select MSVC runtime library via abstraction
ed54d877 Configure CMake itself with policies through CMake 3.15

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3718

Fix logic from commit bbf1c2d2 (ENH: More improvements and add
logging, 2006-01-02, v2.4.0~712) to append to the accumulated tag string
instead of overwriting it for each type of message.

Issue: #19610

A condition in `ComputeTestListForRerunFailed` contained an extra layer
of parentheses.  Remove them.  The condition itself is correct because
an empty list means "all tests" so we want to include the current test.

Issue: #19610

The ownership semantics of the 'testRun' variable are subtle and
may fool static analysers.  Add comments explaining them for now.
Later some refactoring could be done to clarify the code.

Issue: #19610

Directly compare two boolean values instead of spelling out accepted
combinations.

Issue: #19610

The logic checking `CMAKE_WARN_DEPRECATED` contained an unnecessary
layer of parentheses.  The condition is of the form `!IsSet || IsOn`
which is correct because the documentation says that the behavior is
enabled unless the variable is explicitly set to a false value.

Issue: #19610

For our use case we do not actually need to copy these.
Mark the operations as `= delete` to simplify the code.

Fix the SmartBSTR copy constructor and copy assignment operator added by
commit 18c8278b (VS: Add helper class to interact with Visual Studio
Installer, 2016-12-14, v3.8.0-rc1~93^2~4) to use the string from the
source of the copy.

Issue: #19610

Fix the order of logic added by commit 7740ccd1 (ENH: some cleanup of
the makefile generator, 2006-02-14, v2.4.0~517) to check for allocation
failure ('new' returns null) before using the pointer.

Issue: #19610

This replaces `std::ostringstream`, when it is written to only once.
If the single written argument was numeric, `std::to_string` is used instead.
Otherwise, the single written argument is used directly instead of the
`std::ostringstream::str()` invocation.

This replaces the code pattern
```
std::vector<std::string> args;
cmExpandList(valueStr, args, ...)
```
with
```
std::vector<std::string> args = cmExpandedList(valueStr, ...)
```

sidju authored 5 years ago and Brad King committed 5 years ago

To make using the generated STGZ easier, require a specific answer to
accepting the license terms.  Since more moves down one line when '\n'
is entered a user may hold enter to paginate through the document. This
change prevents the user from accidentally refusing the license terms by
holding enter for too long and having to start over.

Use the `CMAKE_MSVC_RUNTIME_LIBRARY` abstraction added by CMake 3.15
instead of hard-coding the `-MT` flag.

In particular, set `CMP0091` to `NEW` to enable the MSVC runtime library
abstraction so it can be set via `CMAKE_MSVC_RUNTIME_LIBRARY` in the
cache.

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

3bb74534 GetPrerequisites: match ldd output on Solaris

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3695

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

1a6e5ac5 gitattributes: Use LF newlines in '.bash' files

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3720

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

5778880d CTest: Fix --show-only=json-v1 output with REQUIRED_FILES property

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3719

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

971c7782 CrayPrgEnv: Change default linking mode based on PE version

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3716

Brad King authored 5 years ago and Kitware Robot committed 5 years ago

9b334397 Source sweep: Use cmStrCat for string concatenation

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Rolf Eike Beer <eike@sf-mail.de>
Acked-by: Daniel Pfeifer <daniel@pfeifer-mail.de>
Merge-request: !3699