Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

05166afb Simplify PointLocatorBase

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3269

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

dc4e261d Merge branch 'ci-use-only-needs-release' into ci-use-only-needs
adc84a98 gitlab-ci: remove `dependencies` from jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3277

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

adc84a98 gitlab-ci: remove `dependencies` from jobs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3277

* ci-use-only-needs-release:
  gitlab-ci: remove `dependencies` from jobs

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

aa36b79e ci: remove executable permissions from `.ps1` scripts

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3276

Ben Boeckel authored 4 months ago and Kitware Robot committed 4 months ago

aa36b79e ci: remove executable permissions from `.ps1` scripts

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3276

Historically, `needs` specifies the jobs which need to complete
successfully and `dependencies` specifies the jobs which provide
artifacts which should be used. Modern GitLab discourages using both as
`needs` now supports an `artifacts` key to say "depend on but do not use
artifacts", so remove `dependencies` and use `needs:artifacts` where
necessary.

See: https://docs.gitlab.com/ee/ci/yaml/#needsartifacts

PowerShell scripts are not inherently executable and therefore should not have
the executable bit set.

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

8bd6ebac Fix clang compile issue with a missing tempolate arg list

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3275

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

8bd6ebac Fix clang compile issue with a missing tempolate arg list

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3275

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

8bd6ebac Fix clang compile issue with a missing tempolate arg list

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3275

Apparently, starting with LLVM clang version 20, if you use the `template`
keyword to highlight a sub-element, you have to provide a template argument
list. This is true even for a method where the template arguments can be
completely determined by the types of the arguments. Fix this problem by
providing an empty template arg list (so the compiler knows what is
templated but still figures out its own types).

Fixes #830

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

674d370b Fix clang compile issue with a missing tempolate arg list

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3274

Apparently, starting with LLVM clang version 20, if you use the `template`
keyword to highlight a sub-element, you have to provide a template argument
list. This is true even for a method where the template arguments can be
completely determined by the types of the arguments. Fix this problem by
providing an empty template arg list (so the compiler knows what is
templated but still figures out its own types).

Fixes #830

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

48e385af Fix compile error for contour tree print

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Gunther Weber <ghweber@lbl.gov>
Merge-request: !3271

Kenneth Moreland authored 4 months ago and Kitware Robot committed 4 months ago

c805a603 Remove unused method from MIR tables

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Abhishek Yenpure <abhi.yenpure@kitware.com>
Merge-request: !3272

The implementation of this method was incorrect as it referenced a class
member that does not exist. Many compilers allowed it in a templated
class when the method was never used, but other compilers attempt to
compile the inlined method regardless.

Since the method clearly is not needed, the easy solution is to remove
it.

A print for one of the contour tree objects was referencing members of
itself that don't seem to exist. This causes the Intel compiler to fail
to compile it. I'm at a loss about how any other compiler does not error
out, but at any rate this should be correct.

Ben Boeckel authored 5 months ago and Kitware Robot committed 5 months ago

8bb8ec53 VTKmWrappers: allow pool size to be configured externally

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !3270

`PointLocatorBase` used to use CRTP. However, this pattern is
unnecessary as the only real subclass it calls is Build, which does not
need templating. The base class does not have to call the
`PrepareForExecution` method, so it can provide its own features to
derived classes more easily.

Also moved `PointLocatorBase` out of the `internal` namespace. Although
it provides little benefit other than a base class, it will make
documenting its methods easier.

Kenneth Moreland authored 5 months ago and Kitware Robot committed 5 months ago

c5a8de92 Simplify CellLocatorBase

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Dave Pugmire <dpugmire@gmail.com>
Merge-request: !3268

`CellLocatorBase` used to use CRTP. However, this pattern is unnecessary as
the only real subclass it calls is `Build`, which does not need templating.
The base class does not have to call the `PrepareForExecution` method, so
it can provide its own features to derived classes more easily.

Also moved `CellLocatorBase` out of the `internal` namespace. Although it
provides little benefit other than a base class, it will make documenting
its methods easier.

Kenneth Moreland authored 5 months ago and Kitware Robot committed 5 months ago

01054427 Add documentation for all of the DataSet methods

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3265

Kenneth Moreland authored 5 months ago and Kitware Robot committed 5 months ago

33373f4b Fix deprecation warning in WorkletCellNeighborhood

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !3266

Kenneth Moreland authored 5 months ago and Kitware Robot committed 5 months ago

33373f4b Fix deprecation warning in WorkletCellNeighborhood

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !3266

Kenneth Moreland authored 5 months ago and Kitware Robot committed 5 months ago

33373f4b Fix deprecation warning in WorkletCellNeighborhood

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !3266

Gunther Weber authored 5 months ago and Kitware Robot committed 5 months ago

f5a95046 Disabled a few contour tree tests to reduce time needed
8f3e8617 Minor refactoring of tests for contour tree.
237b5ad6 Add pre-simplification for contour tree
809127ed (Bug)fix to suppress off-block regular nodes in Augmented Tree

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Gunther Weber <ghweber@lbl.gov>
Merge-request: !3227

Oliver Ruebel authored 1 year ago and Gunther Weber committed 5 months ago

Add pre-simplification as mitigation for memory usage and scaling issues
when running distributed contour tree algorithm on highly complex data
sets.

Co-authored-by: Mingzhe Li <mingzhefluorite@gmail.com>