Skip to content
Snippets Groups Projects
  1. Apr 13, 2020
    • Sean McBride's avatar
      Fixed Address Sanitizer stack-use-after-scope error in test · de14053c
      Sean McBride authored and Ben Boeckel's avatar Ben Boeckel committed
      Error was:
      AddressSanitizer: stack-use-after-scope TestOrderStatistics.cxx:530 in TestOrderStatistics(int, char**)
      
      Fixed by sticking with std::string instead of raw char*. Interestingly, another part of the file was already doing this correctly.
      
      (cherry picked from commit e6890bbf)
      de14053c
    • Sean McBride's avatar
      Zero initialize stack buffers so that strlen() can't overrun them · b1d65d2c
      Sean McBride authored and Ben Boeckel's avatar Ben Boeckel committed
      Found with Address Sanitizer in test VTK::RenderingVolumeOpenGL2Cxx-TestGPURayCastDepthPeelingBoxWidget.
      
      Error was:
      
      ==61971==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffee20da410 at pc 0x00011e67a3f7 bp 0x7ffee20d9eb0 sp 0x7ffee20d9658
      READ of size 257 at 0x7ffee20da410 thread T0
          #0 0x11e67a3f6 in wrap_strlen (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x153f6)
          #1 0x10ee6d495 in vtkRenderWindowInteractor::SetKeySym(char const*) vtkRenderWindowInteractor.h:571
          #2 0x1145af7bd in vtkInteractorEventRecorder::Play() vtkInteractorEventRecorder.cxx:264
          #3 0x10db406d3 in TestGPURayCastDepthPeelingBoxWidget(int, char**) TestGPURayCastDepthPeelingBoxWidget.cxx:1439
          #4 0x10db2ec67 in main vtkRenderingVolumeOpenGL2CxxTests.cxx:284
          #5 0x7fff75b183d4 in start (libdyld.dylib:x86_64+0x163d4)
      
      (cherry picked from commit f4370017)
      b1d65d2c
    • Michael Migliore's avatar
      Merge topic 'fix-env' into release · 8c9bccfb
      Michael Migliore authored and Kitware Robot's avatar Kitware Robot committed
      
      888d2c1c Fix environment map orientation
      
      Acked-by: default avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: default avatarJoachim Pouderoux <joachim.pouderoux@kitware.com>
      Merge-request: !6718
      8c9bccfb
  2. Apr 12, 2020
  3. Apr 11, 2020
  4. Apr 10, 2020
  5. Apr 09, 2020
  6. Apr 08, 2020
  7. Apr 07, 2020
Loading