Implement cmLocalGenerator::ExpandRuleVariables in terms of the new
class for source compatibility and to reduce diff noise in this commit.

Don't rely on the cmGeneratorTarget type needlessly.

The rule replacement API should not really be in cmLocalGenerator, but
it was historically, and this coupled many other things together here
too, such as output conversion.  Make the output converter a parameter
so that rule replacement can be removed from cmLocalGenerator.

These do not change over the lifetime of the cmLocalGenerator.

This reduces the final replacement to a simple query in the map, which
is much more readable than what was here before.

There is no need to be in the loop.  Being there just adds to
complexity.

The same variables are replaced/retrieved from cmMakefile again and
again.  Use a container so that they don't have to be retrieved
repeatedly, and to simplify the nested loop.

This is just to make follow-up diffs smaller.

Use it to determine when a rule replacement should gain extra options.

This one is not like the others as it doesn't participate in
substitutions.  Keep ExpandRuleVariables doing only one thing and make
callers responsible for inserting a launcher prefix, simplifying the
code all-around.

Remove now-obsolete InsertRuleLauncher method.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

d079e71c VS: Provide an option to use x64 host tools
779939a0 Help: Document VS and Xcode toolset selection

Visual Studio provides toolchains that are themselves built for 32-bit
or 64-bit host architectures.  By default it uses the 32-bit tools, but
it can be told to prefer the 64-bit tools on 64-bit hosts.  Extend the
`CMAKE_GENERATOR_TOOLSET` specification to provide a way to request
use of the 64-bit host tools.

Closes: #15622

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

39b08858 cmSystemTools: Flush output buffer for list_item_verbose

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

08b9a0fd FindBoost: Simplify library dir detection with cascading if/elseif/else
ca4029fa FindBoost: Minor style updates
2e242b5c FindBoost: Use list(INSERT) to simplify suffix list generation
6699d46a FindBoost: Use string(APPEND) in more cases

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

19ffc072 Sublime: Exclude build tree from source tree project only optionally

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

20278872 Ninja: Fix POST_BUILD commands on macOS Frameworks

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

9977899d Ninja: Fix RC language depfile generation with cmcldeps

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

2f79b22c Merge branch 'backport-LINK_WHAT_YOU_USE-allow-OFF' into LINK_WHAT_YOU_USE-allow-OFF
33cb0173 Honor LINK_WHAT_YOU_USE when set to OFF
933e54d3 Honor LINK_WHAT_YOU_USE when set to OFF

The condition added by commit v2.8.12~179^2 (OS X: Fix regression
handling frameworks for Ninja, 2013-07-16) for excluding use of
versioning symlinks on macOS Frameworks must match that used for
POST_BUILD selection.  Otherwise we place the POST_BUILD commands after
a symlink step that is never added.

Closes: #16363

Jamie Snape authored 8 years ago and Brad King committed 8 years ago

Explicitly setting variable CMAKE_LINK_WHAT_YOU_USE or property
LINK_WHAT_YOU_USE to OFF should not cause LWYU to run.  Fix the
property lookup to use GetPropertyAsBool.

Jamie Snape authored 8 years ago and Brad King committed 8 years ago

Explicitly setting variable CMAKE_LINK_WHAT_YOU_USE or property
LINK_WHAT_YOU_USE to OFF should not cause LWYU to run.  Fix the
property lookup to use GetPropertyAsBool.

Ben Boeckel authored 8 years ago and Brad King committed 8 years ago

In commit v3.7.0-rc1~275^2 (Ninja: Use full path for all source files,
2016-08-05), the source path was changed to use an absolute path.
Inside of `cmcldeps` for `.rc` file compilation, it uses a separate
argument for the path to the source file.  This ended up causing
`cmcldeps` to transform the following call:

    cmcldeps.exe RC source.rc ... C:/full/path/to/source.rc

into:

    ... C:/full/path/to//Tc source.rc

which is invalid.  Update the source filename to use the full path to
the source file so that the path is replaced properly.

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

When `std::cout` and `FILE *stdout` are used at same time need to
explicitly flush otherwise they can be out of sync.

Brad King authored 8 years ago and Kitware Robot committed 8 years ago

6e5a3655 FindIce: Add support for version 3.6.3