Skip to content

[refact] Refact lidar reader proxies and calibration dialog

Timothée Couble requested to merge refact/reorganizeInterpreterProxies into master

Goal

Refact Lidar readers and improve calibration choice

Main changes

Add a dynamic LiDAR configuration dialog

  • This dialog is intended to supersede the calibration dialog.
  • It automatically populates the dialog combobox with available interpreters.
  • It uses a new proxy InterpreterManager (in a new module LidarView::RemotingServerManager)
  • Adapt python wrapping for the new config
  • Add new reaction to read pcap & streams and update proxy configuration

Add a calibration file custom proxy widget

  • It can be used in paraview XML by adding panel_widget="calibration_file_widget" decorator

  • It includes a checkbox for toggling the visibility of the QListWidget

  • It automatically caches added files

  • It displays only the filename with extension, not the full path

  • image

  • Merge Lidar and GNSS readers and stream in one source:

    • The current vtkLidarPoseStream class structure is not optimal, as it opens two separate streams for the same host but on different ports.
    • Change vtkPose classes to Lidar module and merge readers xmls

Minor changes ( + fixes & tests):

  • Change plugins loading order
    • Ensure that the LidarCorePlugin is positioned at the first position, interpreter plugins depend on LidarCorePlugin having its XML loaded.
  • Add method to accept multiple lidar ports
  • Remove unused ApplyTransform & change SensorTransform to a subproxy
  • Rename & reformat all internal interpreters xml files
  • Improve calibration and pcap reader error messages
  • Add test for open pcap python trace
  • Change calibration file description

MR Dependences

Related to lidarview!227 (merged), velodyneplugin!7 (merged) and HesaiPlugin!14 (merged)

Edited by Timothée Couble

Merge request reports