Previously the array was not marked when it was created through
the dataset adapter interface so it had the default FIELD
attribute.

Previously Verdict was used to compute cell sizes but it only
handled triangles, quads, tets and hexes. Adding a new filter
to compute cell sizes and having the volume() method in
algorithms.py to use that instead.

If an out-of-range value is sent to isprint(), then programs generated
by Visual Studio 2010 and later will assert.  I suspect that it does this
because the alternative would be to guess the encoding and potentially
give an incorrect answer, which could compromise the security of the
executable.

Kunda authored 8 years ago and Cory Quammen committed 8 years ago

doxy and misc. typos pt2

Kunda authored 8 years ago and Cory Quammen committed 8 years ago

fixes some doxy typos
fixes misc. comment typos

This is needed to resolve a cycle causing a leak as a result of
add a numpy array to a dataset where the array was derived from
an array associated with the dataset.

Previously, if a class in VTK had no copy constructor it would not be
wrapped (unless it was derived from vtkObjectBase, which always has the
copy constructor disabled).

Examples of classes that are now wrapped are vtkFloatingPointException
(which only has static methods and is never actually instantiated) and
RAII classes like vtkSimpleMutexLock that lack copy constructors for
obvious reasons.

Adds a fallback for python 2.

This is similar to what is already done in ITK and SimpleITK.

The new vtkTargetLinkLibrariesWithDynamicLookup.cmake file is slightly modified copy from
ITK/CMake/itkTargetLinkLibrariesWithDynamicLookup.cmake
The explanation of what this patch tries to achieve is documented in this file.

A new argument is introduced, called OPTIONAL_PYTHON_LINK.
When used, the module will be optionally be linked against libpython.
In the module.cmake files, most vtkPython dependencies were moved to COMPILE_DEPENDS, so that libpython is not added to the target_link_libraries() call.

The vtkPython is explicitely linked against the python libraries, as this is a python executable.

Also, the find_package calls for the PythonLibs were made optional when possible.

The XDMF3 project was not updated, this will need to be done separately if weak linking is wished for that project.

Fixes: #16068

- Avoid cppcheck false positive (due to pointer aliasing confusion). Reworked the code so g doesn’t alias gTmp, so that cppcheck doesn’t think that gTmp is used unititialized.
- added seemingly missing break
- removed store to local variable from a macro
- fixed other warnings.

These are all new warnings vs the previous version, 1.76.1

No real bugs found/fixed here.

Most are either overwriting a never-read variable value,
usually only at intialiazation, or a useless comparison.

In a couple of places, threw in a const or did other minor reworking.

Strictly speaking, in C, unlike C++, one must use void for an empty parameter list.

VTK has several Borland-specific workarounds, but I’m
fairly sure they are all for ancient compilers.
So this changes makes them all apply to older-than-newest
versions only.
This will make it easier to remove them entirely one day,
as currently it’s impossible to know if they are needed for all, old, or new versions.

Apparently expansion of this macro (which is sometimes defined on Win32)
is undefined and causes a compile error.

This is mainly for kwiml, which was added to VTK 7.1.  For type sizes,
endianness, etc. kwiml checks compiler macros instead of using cmake
to generate config headers via try-compile.  Hence, the wrappers must
define all the macros that the native compiler defines.

The parser would die if "volatile" appeared inside curly braces.
This was due to its accidental omission from the "keyword" rule.

Even though typedefs have been handled by the Python wrappers ever since
VTK 6.0, this feature was never enabled for the Java and Tcl wrappers.
This problem was noticed when the vtkMTimeType typedef was introduced,
since it caused MTime methods to disappear from the Java/Tcl wrappers.

ndarray methods such as sum(...) should produce scalar types,
rather than a 0-d VTKArray. Add __array_wrap__(...) method
to coerce 0-d array to scalar.

David Gobbi authored 8 years ago and Chuck Atkins committed 8 years ago

This adds a check to vtkPythonCommand so that it doesn't attempt to
use the calldata pointer if the pointer is NULL.

David Gobbi authored 8 years ago and Chuck Atkins committed 8 years ago

When Python observed a VTK DeleteEvent, it called GetObjectFromPointer()
to try to get (or make) a Python object for the vtkObject that invoked
the event.  Obviously if a vtkObject is being deleted, we do not want to
create a new Python object that references it.

This adds a check to vtkPythonCommand so that it doesn't attempt to
use the calldata pointer if the pointer is NULL.

When Python observed a VTK DeleteEvent, it called GetObjectFromPointer()
to try to get (or make) a Python object for the vtkObject that invoked
the event.  Obviously if a vtkObject is being deleted, we do not want to
create a new Python object that references it.

I used perl regex to find any groups that spanned a protected: or
private: access specifier.

This change keeps the style of the python wrapper code consistent, and
removes trailing whitespace that was inadvertently generated.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The 'brief' special was only being handled at the beginning of a line,
and the 'warning' and 'sa' specials were not handled at all.  The wrappers
already understand a large number of doxygen specials, but not all of them.

Our module dependency update sweep accidentally recorded this
dependency in the wrong direction.  Fix the dependency so that
the `vtk` executable can use components from the `vtkRenderingTk`
module, such as `vtkTkImageViewerWidget`.

This fixes a `vtkRenderingTkTcl-cursor3D` test failure.

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.