Kunda authored 8 years ago and Cory Quammen committed 8 years ago

doxy and misc. typos pt2

Kunda authored 8 years ago and Cory Quammen committed 8 years ago

fixes some doxy typos
fixes misc. comment typos

- Made a few APIs' params const
- Changed many usages of the evil GetBounds() to expect a const
  return value, even though it does not (yet?) return const
- Slightly changed return values of vtkTextActor3D::GetBounds()
  to return its own ivar instead of its ImageActor's

add casts in lots of places to mun

This fixes performance warnings for cppcheck.

new versions of cmake warn on no setting

- Now require newer Xcode and more modern Objective-C dialect.
- Now require building VTK with VTK_CUSTOM_LIBRARY_SUFFIX="",
  which is best practice anyway if using Xcode, so that the CMake-built
  VTK libraries don't constantly change filenames (by having the version number embedded).
- Adjusted Xcode project paths to remove version from filename.
- Added a window controller class, which is more idiomatic.
- The example now uses ARC (automatic reference counting) memory management by default.
- renamed ivars to start with underscore, per Cocoa convention
- added project.xcworkspace to .gitignore
- added usual VTK divider line comments

ES2 is causing headaches and code mess and is
getting old. Remove for 8.0 so we can focus on
more modern APIs. Most Apple and Adroid devices
from the past 4 years support ES3.

CMake 3.7 adds support for cross-compiling to Android without a complex
toolchain file.  Port our main CMake build system to work without the
`android.toolchain.cmake` file:

```
$ cmake ../VTK \
    -DCMAKE_SYSTEM_NAME=Android \
    -DCMAKE_ANDROID_NDK=/path/to/ndk \
    -DVTKCompileTools_DIR=/path/to/vtk-compile-tools \
    -DOPENGL_ES_VERSION=3.0 \
    -DVTK_Group_StandAlone=OFF
```

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

These files were missed in the first round of re-indentation.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

Made several params const reference.
Mostly in tests, but a couple are slight API change.

The text on some labels on the right side of the form are clipped
because the labels themselves were not wide enough.
This commit makes them wide enough to fit the text without clipping.

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

The super-directory Examples/Infovis/Cxx was loading required
VTK modules and including the VTK_USE_FILE.
Once this file is included, CMake prevents any projects from its
subdirectories from including it again. This would not let the
sub-projects from linking to more modules than the main project.

Haocheng LIU authored 8 years ago and Haocheng LIU committed 8 years ago

With VTK new version, find_package cannot find VTK_RENDERING_BACKEND
properly. The solution is to call find_package(VTK REQUIRED) first, then
use vtk_module_config to load the needed modules. Some typos are also fixed.
For Statistics example, the SetInput function is replaced by SetInputDta
function(See vtkTableAlgorithm class).

Recent change (MR #838) introduced an issue with MFC applications.
This change make vtkHandleMessage2 transfer unprocessed messages to
the OldProc handler. However in MFC, the window is created by MFC and
MFC installs its event handler first. When we connect the render window
interactor, this one does not setup its handler on it (even if OldProc
points on the MFC handler). So the MFC handler catches the messages
first and transfers them to the interactor through vtkHandleMessage2...
and this one can now transfers them to the OldProc handler, which is
the MFC one, so it loops.
To fix we use the already existing feature of vtkHandleMessage2 function
to change interactor's OldProc through a user defined message.
We call this function when initializing the interactor providing the
MFC superclass event handler.

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

was missing escapes on the quotes

fix dashboard build error when the directory is not present
but cmake is trying to delete it as part of the build process

Kitware Robot authored 9 years ago and Dan Lipsa committed 9 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

The cload load box was causing some sort of sizing constraint
issue when animated. No clue why. Turned animaiton off and the
issue goes away. Also added file type icons.

The projects were linking to old VTK libraries. Updated to modular
libraries.

A number of improvements and a new ios example

- expose more module options in the ios build process
- add support for gesture based events
- add gesture reconition for cases where the native gesture
  recognizers are not used
- modify the multitouch interactor style to be based off
  the gestures
- modify the plane widget to support the pinch gesture as an example
- create a new iOS example called planeview that demonstrates
  - using multitouch gestures
  - loading data from a cloud provider
  - using a splash screen
  - using a settings page to control options
  - using a probe widget