Prefer prefix increment/decrement on iterators

This fixes performance warnings for cppcheck.

Domains/Chemistry/vtkXYZMolReader2.cxx

@@ -182,7 +182,7 @@ int vtkXYZMolReader2::RequestData(
       vtkWarningMacro ("XYZMolReader2 using its first timestep value of "
                       << requestedTimeStep);
     }
-    for (it = this->TimeSteps.begin(); it < this->TimeSteps.end(); it++, timestep++)
+    for (it = this->TimeSteps.begin(); it < this->TimeSteps.end(); ++it, ++timestep)
     {
       if ((*it > requestedTimeStep))
         break;
@@ -190,18 +190,19 @@ int vtkXYZMolReader2::RequestData(
 
     if(it != this->TimeSteps.end())
     {
-      it--;
-      timestep--;
+      --it;
+      --timestep;
       if(fabs(*it - requestedTimeStep) > fabs(*(it+1) - requestedTimeStep))
       {
         // closer to next timestep value
-        timestep++;
-        it++;
+        ++timestep;
+        ++it;
       }
     }
     else
     {
-      it--; timestep--;
+      --timestep;
+      --it;
     }
   }
   else

Examples/Rendering/Cxx/MaterialObjects.cxx

@@ -131,7 +131,7 @@ void gridLayoutActors( std::vector<vtkActor*> actors )
     // Z
     if( b[4]<bounds[4] ) bounds[4] = b[4];
     if( b[5]>bounds[5] ) bounds[5] = b[5];
-    it++;
+    ++it;
   }
 
   double step[3] = {1.25 * (bounds[1]-bounds[0]),
@@ -255,7 +255,7 @@ int main(int argc, char* argv[])
   while( it != itEnd )
   {
     ren1->AddActor(*it);
-    it++;
+    ++it;
   }
 
   ren1->SetBackground(0.1, 0.2, 0.4);
@@ -303,8 +303,8 @@ int main(int argc, char* argv[])
                                        << (*it)->GetPosition()[1] << ", "
                                        << (*it)->GetPosition()[2] << endl;
     (*it)->Delete();
-    it++;
-    count++;
+    ++it;
+    ++count;
   }
 #endif
 

Geovis/Core/vtkGeoProjection.cxx

@@ -46,8 +46,8 @@ public:
       int nbIter = index;
       while(nbIter > 0)
       {
-        nbIter--;
-        iter++;
+        --nbIter;
+        ++iter;
       }
       return iter->first.c_str();
     }
@@ -63,8 +63,8 @@ public:
       int nbIter = index;
       while(nbIter > 0)
       {
-        nbIter--;
-        iter++;
+        --nbIter;
+        ++iter;
       }
       return iter->second.c_str();
     }

Imaging/Stencil/vtkLassoStencilSource.cxx

@@ -117,7 +117,7 @@ vtkMTimeType vtkLassoStencilSource::GetMTime()
       {
         mTime = t;
       }
-      iter++;
+      ++iter;
     }
   }