Kunda authored 8 years ago and Cory Quammen committed 8 years ago

doxy and misc. typos pt2

- Made a few APIs' params const
- Changed many usages of the evil GetBounds() to expect a const
  return value, even though it does not (yet?) return const
- Slightly changed return values of vtkTextActor3D::GetBounds()
  to return its own ivar instead of its ImageActor's

add casts in lots of places to mun

This fixes performance warnings for cppcheck.

This change better supports alternative wrapping tools for VTK

Kitware Robot authored 8 years ago and David Gobbi committed 8 years ago

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

generated via:
cd $VTKSRC
perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
cp -r ~/tmp/vtkheaders/* .

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

These mappers are useful for non chemistry applications
so move them to the OpenGL2 directory

Rather than install, attempt to locate, parse, etc the elements.xml
file directly, embed the data in the vtkBlueObeliskData translation
unit via the vtkBlueObeliskDataInternal header.

The header file is generated by the GenerateBlueObeliskHeader test
in Domains/Chemistry, which is built by enabling the CMake option
VTK_BUILD_BODR_DATA_GENERATOR.

Some fields were incorrectly parsed because the current tag was not
cleared at the end of an element.

vtkMoleculeMapper now handles custom lookup tables.

No longer hardcoded to "Atomic Numbers".

The depth peelers currently assume gl_FragCoord.z is always the depth,
but the imposter shaders in Domains/Chemistry modify the depth.

This patch adds a //VTK::Depth::Impl hook into the fragment shader
template, before any depth peeling processing is applied. The depth
is stored into gl_FragDepth, and all depth processing now uses this
variable instead of gl_FragCoord.z.

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

There wasn't much left.

Notably, don't #define vtkstd at all anymore.

Find/replace of:

;[ ]*//\s*Not implemented[\.]*
to
 VTK_DELETE_FUNCTION;

To catch a few remaining ones missed by previous greps.

Manually reverted changed files in VPIC and KWSys folders, and a couple other of places.

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

The new OpenGLRenderPass stuff can remove/change/optimize out some
uniforms and varyings without the mapper's knowledge. This prevents
a ton of spurious warnings from being emitted.

Dhanannjay Deo authored 9 years ago and Dhanannjay Deo committed 9 years ago

- Release openslide handle correctly
- Also tests partial updates
- OpenSlideReader extent orientation
- Also uses new UpdateExtent to set reqeuested extents