I think the old code was fine but tsan can
have false positives with some atomic types
and race conditions so try another fix

Mathieu Westphal (Kitware) authored 8 years ago and Kitware Robot committed 8 years ago

f0729750 Fix NULL socket crash

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Merge-request: !2318

David Gobbi authored 8 years ago and Kitware Robot committed 8 years ago

0f2b56e4 Prefer GetIncrements(incs) over getting a pointer

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2325

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

ba4813f2 fix unsafe memory write in vtkImageGradientMagnitude etc

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2320

The GetIncrements() method calls ComputeIncrements(), and if you do not
supply your own array, then the vtkImageData::Increments ivar is modified
and returned.  This means that the signature of ComputeIncrements() that
returns a pointer is not thread safe.

David Lonie authored 8 years ago and Kitware Robot committed 8 years ago

17d4747e Restore FBO bindings after SurfaceLIC rendering.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2313

David Gobbi authored 8 years ago and Kitware Robot committed 8 years ago

70bd204f Fix off-by-one error in TestGLS2PSTextOpacity
2c51d6fe Prefer prefix increment/decrement on iterators

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2323

This error was found by cppcheck.

This fixes performance warnings for cppcheck.

The class was writing to a memory location from
multiple threads bro. Also fix thread issues in
the TestAtomic and TestConditionVariable tests.

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

d461040c fix type conversion warnings on new dashboard machine

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2317

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

07d84f48 fix CMP0020 issue for Examples/Widgets

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2316

fixing dashboard issues

In some cases, when server closes unexpectendly
the client may try to send data to the server
while it's socket has already been destroyed,
provoking a segfault.
This fixes it.

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

4611c773 added some more gl2ps valid images

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2310

new versions of cmake warn on no setting

seems to be a fair bit of variablility on systems

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

4ed3f155 fix failing header tests for pLagrangianParticalTrackker

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2311

David Lonie authored 8 years ago and Kitware Robot committed 8 years ago

6b9b8c8e Use properly sized MAX values to force newer mtime.
ddd40c22 Add min/max defines for vtkMTimeType.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2312

Refs paraview/paraview#17088.

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

9a46ad06 Dan's revert missed this chunk of code

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2306

MTimes are more complicated now than they were when this code was
written, and may be different types.

These follow the naming convention used for vtkIdType. Also added
the missing min/max defines for the vtkType[type][size] typedefs, as
they were needed for some of the MTime implementations.

Joachim Pouderoux authored 8 years ago and Kitware Robot committed 8 years ago

363f2155 Fix TubeFilter when generating texture coordinates

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !2219

was missing comment and VTK_DELETE_FUNCTION

Sean McBride authored 8 years ago and Kitware Robot committed 8 years ago

4e5c7f67 Fixed null dereference warned by cppcheck

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2280

Sean McBride authored 8 years ago and Kitware Robot committed 8 years ago

a8e1ef08 Fixed clang -Wstrict-prototypes warnings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2307

Mathieu Westphal (Kitware) authored 8 years ago and Kitware Robot committed 8 years ago

43ce2ed0 Correcting vtkCutter progress

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Merge-request: !2304

Ken Martin authored 8 years ago and Kitware Robot committed 8 years ago

32b5c8bc fix a compiler warning

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !2305

Strictly speaking, in C, unlike C++, one must use void for an empty parameter list.

Revert this as it is probably causing issues on
some systems.

The code was producing a compiler warning on
some systems.  The code was fine but could be
changed to shut up the warning.

Previous version of the progress computation was incorrect in some cases
this fixes it.

Utkarsh Ayachit authored 8 years ago and Kitware Robot committed 8 years ago

7dde74cf Disable `GL_POLYGON_SMOOTH`.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !2303

Disabling GL_POLYGON_SMOOTH in vtkOpenGLContextDevice2D. It causes odd
blending artifacts with Nvidia drivers on Linux when using Qt5 +
OpenGL2.

Andrew Bauer authored 8 years ago and Kitware Robot committed 8 years ago

b733aad1 Improving vtkAggregateDataSetFilter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !2285

Mathieu Westphal (Kitware) authored 8 years ago and Kitware Robot committed 8 years ago

df1bbe21 Memory bugfixes for LagrangianParticleTracker

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Merge-request: !2292

This commits fixes small memory issues with the lagrangian particle tracker
as weel as changing the defautl surface array value to Terminate

Joachim Pouderoux authored 8 years ago and Kitware Robot committed 8 years ago

fe3a9c4c Revert warnings to debug messages introduced by !1948

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Bill Lorensen <bill.lorensen@gmail.com>
Merge-request: !2298