Skip to content

HIP: remove bogus kokkoscore INTERFACE_COMPILE_DEFINITIONS property

Vicente Bolea requested to merge vbolea/vtk-m:kokkos-fix into master

When Kokkos uses HIP it initialize the properties of the target kokkoscore like this:

set_target_properties(Kokkos::kokkoscore PROPERTIES                                                                               
  INTERFACE_COMPILE_DEFINITIONS "\$<\$<COMPILE_LANGUAGE:CXX>:KOKKOS_DEPENDENCE>"                                                  
  INTERFACE_COMPILE_FEATURES "cxx_std_14"                                                                                         
  INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:-fno-gpu-rdc>;\$<\$<COMPILE_LANGUAGE:CXX>:-x;hip;--offload-arch=gfx900>"

These generator expressions create some issues when we try to generate files with a content that depends on it. We already zeroed INTERFACE_COMPILE_OPTIONS and INTERFACE_LINK_OPTIONS for similar reasons, the reason of that we did not the same for INTERFACE_COMPILE_DEFINITIONS is that we did not have an issue with this so far.

Unfortunately, for VTK when using kokkos_hip transitively through VTK-m it tries to generate files with the content of INTERFACE_COMPILE_DEFINITIONS which results in a configure error.

Eventually this has to make its way to the Kokkos project.

Merge request reports