Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 188
    • Issues 188
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

An update will be applied May 24th, between 12PM and 1PM EDT (UTC -400). The site may be slow during that time.

  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2679

Merged
Created Jan 20, 2022 by Vicente Bolea@vbolea💬Maintainer

HIP: remove bogus kokkoscore INTERFACE_COMPILE_DEFINITIONS property

  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 1

When Kokkos uses HIP it initialize the properties of the target kokkoscore like this:

set_target_properties(Kokkos::kokkoscore PROPERTIES                                                                               
  INTERFACE_COMPILE_DEFINITIONS "\$<\$<COMPILE_LANGUAGE:CXX>:KOKKOS_DEPENDENCE>"                                                  
  INTERFACE_COMPILE_FEATURES "cxx_std_14"                                                                                         
  INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:-fno-gpu-rdc>;\$<\$<COMPILE_LANGUAGE:CXX>:-x;hip;--offload-arch=gfx900>" 

These generator expressions create some issues when we try to generate files with a content that depends on it. We already zeroed INTERFACE_COMPILE_OPTIONS and INTERFACE_LINK_OPTIONS for similar reasons, the reason of that we did not the same for INTERFACE_COMPILE_DEFINITIONS is that we did not have an issue with this so far.

Unfortunately, for VTK when using kokkos_hip transitively through VTK-m it tries to generate files with the content of INTERFACE_COMPILE_DEFINITIONS which results in a configure error.

Eventually this has to make its way to the Kokkos project.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: kokkos-fix