Skip to content
Snippets Groups Projects

Optimize casting operations

Merged Robert Maynard requested to merge robertmaynard/vtk-m:optimize_casting_operations into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: c4caeef7

  • Errors:

    • commit f769ccd0 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/StorageVirtual.hxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit c4caeef7 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/VariantArrayHandle.cxx, vtkm/cont/internal/VariantArrayHandleContainer.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Kenneth Moreland
  • Robert Maynard added 23 commits

    added 23 commits

    • c4caeef7...c89f633d - 21 commits from branch vtk:master
    • 1d4569cf - Optimize TransferInfo / VirtualObjectTransfer for shared memory systems
    • 83cc7049 - VariantArrayHandleContainer casting operations have minimal overhead.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 83cc7049

  • Errors:

    • commit 1d4569cf is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/StorageVirtual.hxx. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.
    • commit 83cc7049 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/VariantArrayHandle.cxx, vtkm/cont/internal/VariantArrayHandleContainer.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Kenneth Moreland resolved all discussions

    resolved all discussions

  • If I understand these changes, you are skipping some steps when "transferring" data to the same memory/execution space by not generating new objects. Sounds good to me.

    +1 once formatting and dashboard issues are resolved.

  • @kmorel Exactly.

  • Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 2 commits

    added 2 commits

    • 67af0d99 - Optimize TransferInfo / VirtualObjectTransfer for shared memory systems
    • b56c9e85 - VariantArrayHandleContainer casting operations have minimal overhead.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: b56c9e85

  • Robert Maynard added 3 commits

    added 3 commits

    • b56c9e85...831a0bf8 - 2 commits from branch vtk:master
    • 2112fa60 - VariantArrayHandleContainer casting operations have minimal overhead.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 2112fa60

  • Errors:

    • commit 2112fa60 is not allowed because the following files are not formatted according to the 'clang-format-3.8' check: vtkm/cont/VariantArrayHandle.cxx, vtkm/cont/internal/VariantArrayHandleContainer.h. Post a comment ending in the line Do: reformat to rewrite the MR source branch automatically.

    Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.

  • Do: reformat

  • This topic has been reformatted and pushed; please fetch from the source repository and reset your local branch to continue with further development on the reformatted commits.

  • Kitware Robot added 1 commit

    added 1 commit

    • d29bdb2e - VariantArrayHandleContainer casting operations have minimal overhead.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: d29bdb2e

  • Do: merge

  • Robert Maynard mentioned in commit 0241201d

    mentioned in commit 0241201d

  • merged

  • Please register or sign in to reply
    Loading