Fix issues with VTKmDetermineVersion.
The code had 2 issues:
-
used obsolete 'output' if Git executable was missing. There was a possibility that output variable was never set and used some garbage value from parent scope.
-
version pattern matching was too liberal and would match any long txt so long as it has some numbers in it that matched a typical version number.
Edited by Utkarsh Ayachit
Merge request reports
Activity
mentioned in merge request paraview/paraview!2417 (merged)
- Resolved by Utkarsh Ayachit
added 7 commits
-
c806f92f...6d0e3036 - 6 commits from branch
vtk:master
- da7c6c46 - Fix issues with VTKmDetermineVersion.
-
c806f92f...6d0e3036 - 6 commits from branch
@robertmaynard what do you think? If that looks good, I'll update ParaView's accordingly as well.
Please register or sign in to reply