Skip to content
Snippets Groups Projects

Fix issues with VTKmDetermineVersion.

Merged Utkarsh Ayachit requested to merge utkarsh.ayachit/vtk-m:fix-determine-version into master

The code had 2 issues:

  1. used obsolete 'output' if Git executable was missing. There was a possibility that output variable was never set and used some garbage value from parent scope.

  2. version pattern matching was too liberal and would match any long txt so long as it has some numbers in it that matched a typical version number.

see: paraview/paraview#18116 (closed)

Edited by Utkarsh Ayachit

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Utkarsh Ayachit resolved all discussions

    resolved all discussions

  • Utkarsh Ayachit added 7 commits

    added 7 commits

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: da7c6c46

  • added 1 commit

    • d623ee48 - Fix issues with VTKmDetermineVersion.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: d623ee48

  • @robertmaynard what do you think? If that looks good, I'll update ParaView's accordingly as well.

  • added 1 commit

    • 7f16a1a0 - Fix issues with VTKmDetermineVersion.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 7f16a1a0

  • added 1 commit

    • 00a65585 - Fix issues with VTKmDetermineVersion.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 00a65585

  • added 1 commit

    • cf91ca52 - Fix issues with VTKmDetermineVersion.

    Compare with previous version

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: cf91ca52

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading