Skip to content

fixes issues with ParaViewDetermineVersion.

Utkarsh Ayachit requested to merge utkarsh.ayachit/paraview:fix-determine-version into master

The code had 2 issues:

  1. used obsolete 'output' if Git executable was missing. There was a possibility that output variable was never set and used some garbage value from parent scope.

  2. version pattern matching was too liberal and would match absolute any long txt so long as it has some numbers in it that matched a typical version number.

see also: vtk/vtk-m!1166 (merged), #18116 (closed)

Edited by Utkarsh Ayachit

Merge request reports