add FIDES_DEPRECATED macro
Just grabbed VTK-m deprecation macros to be used here.
Merge request reports
Activity
Errors:
- commit cbcc5a0e is not allowed because the following files are not formatted according to the 'clang-format' check:
fides/Configure.h
,fides/Deprecated.h
,tests/test-deprecated.cxx
. Post a comment ending in the lineDo: reformat
to rewrite the MR source branch automatically.
Please rewrite commits to fix the errors listed above (adding fixup commits will not resolve the errors) and force-push the branch again to update the merge request.
- commit cbcc5a0e is not allowed because the following files are not formatted according to the 'clang-format' check:
@dpugmire or @NAThompson would you review? I've got some stuff I want to deprecate in another MR, so wanted to add in a way to deprecate things. Just grabbed it from VTK-m.
This all looks good to me.
One question: Why not just restrict to compilers which support
[[deprecated]]
? I believe that VTK-m only had to provide it's own macro before the C++-14 shift; now it can be safely removed.You have added some additional semantics which are nice, such as which version it'll be deprecated in. But will it ever be used in a non-trivial way? I imagine we won't have deprecation warnings over multiple versions.
mentioned in commit e5e8a84f