Kitware Robot authored 5 months ago and Ben Boeckel committed 5 months ago

Also use C++17 syntax rules as the next release expects to use C++17.

Updating a lot of baselines to match the new image comparison method

Infovis/Boost module does not need ABI mangling
IO/XML tests drop exceptions to C API
Add MANGLING label to ABI mangling tests
Fix bug in parsing exceptions in ABI mangling test driver

These were auto-found and auto-fixed by clang `-Xclang -fixit`

* This extends support for more arrays (like imlicit arrays),
instead of crashing.
* This removes the use of old template macros,
limiting the risk for unsupported cases (like new implicit arrays)

Replace 1

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================(.|\n)*.*Program:   Visualization Toolkit\n.*Module:.*\n\n  Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n  All rights reserved.\n  See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 2

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================(.|\n)*.*Program:   Visualization Toolkit\n.*Module:.*\n\n  Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n  All rights reserved.\n  See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 3

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n.*Program:.*Visualization Toolkit\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n.*\n.*\n.*\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 4

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 5

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 6

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 7

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 8

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\/\*==================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n===================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace sandia 1

 cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n\n-------------------------------------------------------------------------\n.*Copyright 2008 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,\n.*the U.S. Government retains certain rights in this software.\n-------------------------------------------------------------------------\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2008 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-CLAUSE-Sandia-USGov/g' %s

Replace 9

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*Visualization Toolkit\n.*Module:.*\n.*Language:.*\n\n.*Copyright \(c\) .* Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 1

Replace 10

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace 11

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n.*Program:.*\n.*Module:.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n.*\n.*\n.*\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Replace Valve 1

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\nParts Copyright Valve Corporation from.*\nunder their BSD license found here:\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) 2015, Valve Corporation\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 2

Manual 3

manual 4

manual sandia 1

manual 5

Replace ParaView 1

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Sandia Corporation, Kitware Inc.\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) Sandia Corporation, Kitware Inc\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual Sandia 2

Replace 13

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual sandia 3

replace 14

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .* for details.\n\n.*\n.*\n.*\n\n.*=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual sandia 4

Manual 6

manual 7

manual sandia 5

Manual Kitware SAS 1

manual 7

Manual 10

manual 11

manual 12

manual 15

Fix wrong spdx name

Remove useless cmake copyright

Remove useless copyrights

Remove useless copyright and license statement in python files

Removal glsl

cat files.out | xargs -I %s perl -i~ -0777 -pe "s/.*=========================================================================\n.*\n.*Program:.*\n.*Module:.*\n.*\n.*Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n.*All rights reserved.\n.*See Copyright.txt or .*for details.\n.*\n.*\n.*\n.*\n.*\n.*=========================================================================\n//g" %s

Replace sandia accel

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\/=============================================================================\n.*\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See LICENSE.txt for details.\n.*\n.*This.*\n.*the.*\n.*PURPOSE.*\n.*\n.*Copyright 2012 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,\n.*the U.S. Government retains certain rights in this software.\n.*\n.*=============================================================================/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright (c) Kitware, Inc.\n\/\/ SPDX-FileCopyrightText: Copyright 2012 Sandia Corporation.\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Manual sandia accel

manual Kitware inc

Manual fixups

Manual 14

Replace 15

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\*=========================================================================\n\n.*Program:.*\n.*Module:.*\n\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See LICENSE file for details.\n\n.*\n.*\n.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-CLAUSE/g' %s

Manual 16

Removing non-standard file header

cat files.out | xargs -I %s perl -i~ -0777 -pe 's/\/\/ \-\*\- c\+\+.*\n\n//g' %s

Manual removal non standard header

Adding custom sandia and lanl licenses

Fix missing header common core

Manual missing headers

Add missing sandia

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\n\/\*\n.*Copyright 2004 Sandia Corporation.\n.*Under.*\n.*license.*\n.*U.*\n.*or.*\n.*statement.*\n \*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2004 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Adding missing sandia licenses

Adding sandia licenses

Adding missing sandia licenses

Replace sandia

Adding sandia module changes

Use new custom license system

Replace sandia

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*-------------------------------------------------------------------------\n.*Copyright 2009 Sandia Corporation.\n.*Under the terms of Contract DE-AC04-94AL85000.*\n.*the.*\n-------------------------------------------------------------------------\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright 2009 Sandia Corporation\n\/\/ SPDX-License-Identifier: LicenseRef-BSD-3-Clause-Sandia-USGov/g' %s

Adding missing sandia licenses

Sandia final fixup license

Adding missing sandia license

Fix remaining sandia license

Manual LANL license

Replace sandia BSD

cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*----------------------------------------------------------------------------\n.*Copyright \(c\) Sandia Corporation\n.*See Copyright.txt.*\n.*----------------------------------------------------------------------------\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) Sandia Corporation\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Replace Kitware, Inc.

 cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\*=========================================================================\n\n.*Program.*\n.*Module.*\n\n.*Copyright \(c\) Kitware, Inc.\n.*All rights reserved.\n.*See Copyright.txt.*\n\n.*This.*\n.*the.*\n.*PURPOSE.*\n\n=========================================================================\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) Kitware, Inc.\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual ParaView license

Remove useless license statement in cmake files

Manual licenses

Replace lanl

 cat files.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\n\/\*.*\n.*\n.*Copyright \(c\) 2000.*2009.*Lawrence Livermore National Security, LLC\n.*Produced at the Lawrence.*\n.*LLNL-CODE-400124\n.*All rights reserved.\n.*\n.*This.*\n.*see.*\n.*file.*\n.*http.*\n.*\n.*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) 2000 - 2009, Lawrence Livermore National Security, LLC\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual LANL

NVIDIA license impact

Manual Indiana

Manual copyrights

More manual licenses

More manual licenses

Replace Atamai

 cat a.out  | xargs -I %s perl -i~ -0777 -pe 's/\A\/\/ SPDX-FileCopyrightText.*\n\/\/ SPDX-License-Identifier.*\n\/\*.*\n\n.*Copyright \(c\) 2006 Atamai, Inc.\n\nUse.*\nbinary.*\nconditions.*\n\n1.*\n   form.*\n   the.*\n   license.*\n\n2.*\n   notice.*\n   in.*\n   distribution.*\n\n3.*\n   and.*\n\nTHE.*\nWITHOUT.*\nTHE.*\nPURPOSE.*\nMODIFY.*\nBE.*\n.*\nOR.*\nTHE.*\nPOSSIBILITY.*\n\n.*\*\//\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-FileCopyrightText: Copyright \(c\) 2006 Atamai, Inc.\n\/\/ SPDX-License-Identifier: BSD-3-Clause/g' %s

Manual MIT

Manual licenses

Xdmf2 License

PLY license

Manual VRML licenses

replace Netcdf license

Manual OpenXR license

Manual Licenses

Example Licenses manual

Manual Copyrights and licenses

Manual licensing

Removing empty lines

Manual licenses

Manual final pass

Manual Dicom

Replace all cxx without copyright info

find .  -name "*.cxx" -exec grep -L "SPDX" {} \; | grep -v ThirdParty | grep -v Utilities > files.out

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\A(.*)\n/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-Clause\n$1\n/g' %s

Replace all header missing license

find .  -name "*\.h" -exec grep -L "SPDX" {} \; | grep -v ThirdParty | grep -v Utilities > files.out

cat files.out |  xargs -I %s perl -i~ -0777 -pe 's/\A(.*)\n/\/\/ SPDX-FileCopyrightText: Copyright \(c\) Ken Martin, Will Schroeder, Bill Lorensen\n\/\/ SPDX-License-Identifier: BSD-3-Clause\n$1\n/g' %s

Manual from build

Add missing license

Replace copyright.txt

Remove license files

Manual fixes found by building

Fix header testing

Add license in vtkEncodeString

Manual new filters

Review JF

Despite its name, IsItemPresent() doesn't return a boolean, it returns an index.  Made this more clear where it's used.

Introduced a similar method named IndexOfFirstOccurence() that returns the index, as you'd guess from its name.  Changed many uses of IsItemPresent to IndexOfFirstOccurence().

Changed HasProp() and HasImage() from returning int to returning vtkTypeBool. Also, with VTK_LEGACY_REMOVE, changed behaviour to actually return 0 or 1, instead of returning a 1-based index.

Found via `codespell -q 3 -S ./.git,./ThirdParty,./Utilities/MetaIO,./Utilities/KWSys -L acount,aline,alledges,ans,ba,childs,co-ordinates,contrl,datas,dota,eiter,inout,inouts,lod,lsit,nin,nd,normale,normaly,ot,outout,pard,pres,siz,statics`

This is a UNIX only test.

VTK_ABI_NAMESPACE_{BEGIN,END} macro is inserted around all VTK symbols.

Exclusions:
 * C interfaces, such as GetVTKVersion and the python module.
 * third-party libraries and external libraries that are not maintained
   by VTK but are part of the VTK repository.
 * Cxx module tests
 * Utilities
 * Wrapping/Tools

Found via `codespell`

No interface changes.

The implicit conversion makes the use of `strcmp` too easy. Use
`operator==` where possible.

This is in preparation for deprecation of the implicit conversion from
`vtkStdString` to `const char*`.