Andras Lasso authored 6 days ago and Dženan Zukić committed 5 days ago

This line set the homogeneous IJK coordinates incorrectly:

    pointsDataCoords.emplace_back(bounds[1], bounds[3], bounds[5], 0.);

The problem is that the last component is set to 0 instead of 1
(the coordinates specify a direction vector and not a position).
When this vector is multiplied by the homogeneous transformation matrix,
the position is incorrect, because the translation component of the matrix
is not taken into account.

fixes https://github.com/Slicer/Slicer/issues/8301
fixes #19447

Spiros Tsalikis authored 2 months ago and Kitware Robot committed 2 months ago

e3db3c76 vtkTableBasedClipDataSet: Add check to avoid nullptr access
1ab742b0 vtkHigherOrderTetra: Add size check
5d987d5b vtkGenericCell: Return when cell is nullptr

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Acked-by: Mickael PHILIT <mickey.phy@gmail.com>
Merge-request: !11777

David Gobbi authored 2 months ago and Kitware Robot committed 2 months ago

b0bb013f Fix Java depfile error with Visual Studio generator

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Vicente Bolea <vicente.bolea@kitware.com>
Merge-request: !11766

Sankhesh Jhaveri authored 2 months ago and Kitware Robot committed 2 months ago

c5f888fc OSPRay: ambient light switch status

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11780

The OSPRay renderer node avoids ambient lighting if there is an existing
ambient light in the scene. However, this would fail if the existing
light was switched off. This new check ensures that OSPRay uses ambient
illumination even if existing ambient light is switched off.

The DEPFILE files for the .java custom command were being written
to vtk<Module>Java.dir/<Class>.java.d, which caused errors on the
Visual Studio generators because the vtk<Module>Java.dir folders
only exist for Ninja and Makefile generators.  This is fixed by
writing the DEPFILE to vtk<Module>Java/<Class>.java.d instead.

Mathieu Westphal (Kitware) authored 2 months ago and Kitware Robot committed 2 months ago

6f6d77f9 vtkOpenGLRenderer: Fix a warning about spherical harmonics

Acked-by: Kitware Robot <kwrobot@kitware.com>
Tested-by: buildbot <buildbot@kitware.com>
Reviewed-by: Michael Migliore <mcmigliore@gmail.com>
Merge-request: !11779

Cory Quammen authored 2 months ago and Kitware Robot committed 2 months ago

af084bd3 Added release note for light widget path tracing
0a6e6b0f Added test for light widget
890c60e2 Support ray-traced rendering of light widget/representation
f60d1dc2 Support positional light attenuation with ray tracing

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11757

Cory Quammen authored 2 months ago and Kitware Robot committed 2 months ago

f5b8061a Added release note for rectilinear grid cell data support
21fa50d7 Fix volume rendering support for rectilinear grid celldata

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !11764

Ben Boeckel authored 2 months ago and Kitware Robot committed 2 months ago

a3db6c62 ci: exclude geometry shader issues on macOS tests
647bda9d gitlab-ci: update to Xcode 16.1

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Merge-request: !11772

Ben Boeckel authored 2 months ago and Kitware Robot committed 2 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

Ben Boeckel authored 2 months ago and Kitware Robot committed 2 months ago

82980672 matplotlib: use kwargs for `FontProperties` arguments

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Reviewed-by: Mathieu Westphal (Kitware) <mathieu.westphal@kitware.com>
Merge-request: !11773

This has been deprecated and will be removed in a future release.
Migrate to kwargs instead.

Ben Boeckel authored 2 months ago and Kitware Robot committed 2 months ago

6c68c368 vtkTesting: clamp negative SSIM values
f053b934 vtkTesting: handle SSIM's [-1,1] range
7a07dd33 vtkTesting: fix typos in log string and comment
a450694a vtkTesting: fix string allocation
9692d102 TestIOSSExodusParallelWriter: fix compilation without MPI
5b1ff455 IO/IOSS/Testing: remove stray comma in source list
f0c476fa Relaxed overly tight floating-point comparison
b95a6030 ci: exclude floating point precision issues
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: buildbot <buildbot@kitware.com>
Merge-request: !11675

When SSIM returns a negative value, the histogram bucketing ends up
writing to out-of-bounds memory. Don't do that and instead shift the
buckets to account for the full range of values that are possible.

Finally, add commentary on the code.

See commit cd75f4b9 which applied this
to `master` and `release`.

Co-authored-by: Spiros Tsalikis <spiros.tsalikis@kitware.com>

`newFileName` is deleted using `delete[]`, so allocate it with `new[]`.

Vicente Bolea authored 3 months ago and Kitware Robot committed 3 months ago

0ee8f335 java: copy the native libraries when creating native jars

Acked-by: Kitware Robot <kwrobot@kitware.com>
Rejected-by: buildbot <buildbot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11754