David Gobbi authored 4 years ago and Kitware Robot committed 4 years ago

b76eee55 For Python Qt widget, set DPI for text scaling

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6847

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

7789697d Fixed #17832: Observe NSView frame changes even for NSViews VTK didn't create
4a0b3b0a Fixed CAOpenGLLayer example being rendered as solid red
36350987 Create the NSOpenGLPixelFormat and NSOpenGLContext before the NSView/NSWindow
a12cdb6a Hoisted some duplicated code into a helper method
75a4aa97 Review of vtkCocoaRenderWindow SetSize and SetPosition
bf4a12a5 Added method separator comment lines in some files that missed some
3b14eb34 Fixed/improved a few incorrect comments
71a3fa44 Cleanup SetSize and SetPosition methods
...

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Seun Odutola <seun@rogue-research.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6788

Without this change, text is half-size on HiDPI displays.

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

35d16f9a setup.py.in: add topics

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6844

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

7705ef95 README.md: fix typo

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6843

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

6478eacf DOC: Fix link to contributing instructions in python wheel long description
38ba5a09 DOC: Fix reference-style links in README.md to properly render on pypi

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Reviewed-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6842

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

adbab991 Fix and test triangulate for penta and hexa prism cells

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6838

As documented in the specification, reference links should be specified.
See https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links

Jean-Christophe Fillion-Robin authored 4 years ago and Kitware Robot committed 4 years ago

7fe57281 setup.py.in: fixes for pypi

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Merge-request: !6841

(cherry picked from commit 0fa0b892)

Usually VTK creates its own NSViews, and in that case we were already observing NSViewFrameDidChangeNotification and reacting appropriately.

But VTK can also be used in a different way, were clients create their own NSViews and point VTK to them. The SimpleCocoaVTK example does this.  In this case, VTK was not observing for NSVIew frame changes. That was ok unitl b75bc715.  But now that VTK creates its own framebuffer, it really needs to know when the NSView frame changes size.  So now we observe frame changes even for NSViews we didn't create.  In response, GetSize/SetSize will be invoked and do some necessary work. They will not however change the size of the NSView/NSWindow becuase a new 'if' contition limits that to happening only for NSViews created by VTK.

The SimpleCocoaVTK example project has two kinds of NSViews, one being based on CAOpenGLLayer. That one has been broken in master for some time now, rendering as solid red. Fixed by invoking InitializeFromCurrentContext(). Bypassed vtkCocoaRenderWindow's implementation though because it mutates the NSView and NSWindow ivars, which is undesirable in this case. Instead, invoke super's implementation.

The motivation here is that if we switch to NSOpenGLView, we'll need the NSOpenGLPixelFormat to construct it. Seems to make no difference creating it before or after currently.

Also moved the code that sets the NSWindow title higher up where the NSWindow is created.

- fixed error in vtkCocoaRenderWindow::SetPosition() where it was unconditionally setting the NSWindow position to 0,0
- eliminated recursion/reentry into viewFrameDidChange: by adding checks in SetSize() and SetPosition()
- slightly tweaked vtkCocoaRenderWindow::GetSize implementation to return 0,0 if somehow there is no NSView, which is an unlikely (impossible?) edge case
- rearranged some tests so the faster ones are first
- improved some comments

Moved some implementations into the .h, so that all subclasses are the same.

Document that vtkWindow::SetSize invokes vtkCommand::WindowResizeEvent. Other doc improvements.

Added override keyword where it was missing.

Made the parameter names uniform in all classes: width and height, and x and y.

Other minor cleanup, such as using Superclass instead of naming the superclass.

Found with regex: virtual.*override

stringWithUTF8String: does not accept null, so use an empty string if null is given.

Cocoa amd Win32 were both writing to the Size ivar, which is not supposed to be the size of the entire screen.

The Win32 implementation had a ScreenSize ivar but it was totally unused.  The Cocoa implementation didn't even have a ScreenSize ivar.  Put ScreenSize ivar up into vtkOpenGLRenderWindow, and removed it from subclasses that had such an ivar. The OpenVR implementation was missing (and provided to me by Ken).

Also, in Cocoa, instead of getting the NSScreen from the NSWindow, go through the NSView, which is the thing VTK is drawing into, and so slightly more correct.

Added TODOs for subclasses that don't have any code to determine screen sizes.

This will allow one day making those getters return const

vtkTypeBool currently is int, so this changes nothing yet

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

78e12e41 Merge topic 'handle-changed-volume-ray-cast-mapper-for-9.0' into backport-missed-mrs-9.0
a32101ce Update the vtkVolume in the vtkVolumeInputHelper when updating inputs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6832

Merge-request: !6819

Cory Quammen authored 4 years ago and Ben Boeckel committed 4 years ago

The Volume member of vtkVolumeInputHelper could hold onto a reference
to a deleted vtkVolume. Ensure it is updated to the current vtkVolume
in vtkOpenGLGPUVolumeRayCastMapper::vtkInternal::UpdateInputs().

(cherry picked from commit c116819e)

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

e50d83c8 Fix negative Jacobian of Lagrange wedge and add test CellSizeFilter2

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6831

(cherry picked from commit 6d70de50)

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

7a1dede7 setup.py: Update windows glob

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6826

Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

b972b2a8 Merge branch 'upstream-libxml2' into libxml2-fix-snprintf-detection
6b45376d libxml2 2020-04-27 (47212d6c)
3ef138b1 libxml2: update for snprintf detection

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6823

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

9e2e305d Update python wheel metadata

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Acked-by: Bane Sullivan <banesullivan@gmail.com>
Merge-request: !6820