Skip to content
Snippets Groups Projects
  1. Jan 27, 2024
  2. Jan 26, 2024
  3. Jan 25, 2024
  4. Jan 24, 2024
    • Brad King's avatar
      Revert use of libuv for process execution for 3.28 · bcbb212d
      Brad King authored
      Wide use of CMake 3.28.{1,0[-rcN]} has uncovered some hangs and crashes
      in libuv SIGCHLD handling on some platforms, particularly in virtualization
      environments on macOS hosts.  Although the bug does not seem to be in CMake,
      we can restore stability in the CMake 3.28 release series for users of such
      platforms by reverting our new uses of libuv for process execution.
      
      Revert implementation changes merged by commit 47715443 (Merge topic
      'replace-cmsysprocess-with-cmuvprocesschain', 2023-09-06, v3.28.0-rc1~138),
      but keep test suite updates.
      
      Issue: #25414, #25500, #25562, #25589
      bcbb212d
    • Brad King's avatar
      cmUVProcessChain: Tolerate fileno() of invalid FILE stream · adb3e13d
      Brad King authored
      On Windows, in a GUI process without a console, the `std{in,out,err}`
      standard FILE streams may not be open.  Avoid passing an invalid file
      descriptor to the child process, and let libuv attach NUL instead.
      
      Fixes: #25625
      adb3e13d
    • Brad King's avatar
      cmUVProcessChain: Simplify SetExternalStream usage · b6e4e4ba
      Brad King authored
      It is commonly called with the `fileno()` of a `FILE*` stream,
      so accept the latter directly.
      b6e4e4ba
Loading