Cocoa amd Win32 were both writing to the Size ivar, which is not supposed to be the size of the entire screen.

The Win32 implementation had a ScreenSize ivar but it was totally unused.  The Cocoa implementation didn't even have a ScreenSize ivar.  Put ScreenSize ivar up into vtkOpenGLRenderWindow, and removed it from subclasses that had such an ivar. The OpenVR implementation was missing (and provided to me by Ken).

Also, in Cocoa, instead of getting the NSScreen from the NSWindow, go through the NSView, which is the thing VTK is drawing into, and so slightly more correct.

Added TODOs for subclasses that don't have any code to determine screen sizes.

This will allow one day making those getters return const

vtkTypeBool currently is int, so this changes nothing yet

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

78e12e41 Merge topic 'handle-changed-volume-ray-cast-mapper-for-9.0' into backport-missed-mrs-9.0
a32101ce Update the vtkVolume in the vtkVolumeInputHelper when updating inputs

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: T.J. Corona <tj.corona@kitware.com>
Merge-request: !6832

Merge-request: !6819

Cory Quammen authored 4 years ago and Ben Boeckel committed 4 years ago

The Volume member of vtkVolumeInputHelper could hold onto a reference
to a deleted vtkVolume. Ensure it is updated to the current vtkVolume
in vtkOpenGLGPUVolumeRayCastMapper::vtkInternal::UpdateInputs().

(cherry picked from commit c116819e)

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

e50d83c8 Fix negative Jacobian of Lagrange wedge and add test CellSizeFilter2

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6831

(cherry picked from commit 6d70de50)

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

7a1dede7 setup.py: Update windows glob

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6826

Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

b972b2a8 Merge branch 'upstream-libxml2' into libxml2-fix-snprintf-detection
6b45376d libxml2 2020-04-27 (47212d6c)
3ef138b1 libxml2: update for snprintf detection

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6823

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

9e2e305d Update python wheel metadata

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Acked-by: Bane Sullivan <banesullivan@gmail.com>
Merge-request: !6820

# By libxml2 Upstream
* upstream-libxml2:
  libxml2 2020-04-27 (47212d6c)

Kitware Robot authored 4 years ago and Ben Boeckel committed 4 years ago

Code extracted from:

    https://gitlab.kitware.com/third-party/libxml2.git

at commit 47212d6c3879aeb3ccad457225e4d87194091a6f (for/vtk-20200427-2.9.10).

Fixes: #17868

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

503e0a2d Utilities/Python: use PythonX::Module for the main target
336b65dd Utilities/Python: fix the python linking logic
59d62647 vtkModule: handle dependencies from forward_link as well
13c47bee vtkModule: found optional components are required at install time

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: T.J. Corona <tj.corona@kitware.com>
Reviewed-by: Andrew Maclean <andrew.amaclean@gmail.com>
Merge-request: !6800

T.J. Corona authored 4 years ago and Kitware Robot committed 4 years ago

4eb8ba3f RenderingUI: remove dependency on libXt

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ken Martin <ken.martin@kitware.com>
Merge-request: !6818

Fixes: #17863

Michael Migliore authored 4 years ago and Kitware Robot committed 4 years ago

819b690f Fix missing release causing crash when OpenGL context change

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6814

David Gobbi authored 4 years ago and Kitware Robot committed 4 years ago

f2c2f20d Use pixel scale for resize in Python Qt interactor

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6813

David Gobbi authored 4 years ago and Kitware Robot committed 4 years ago

655d9a31 Re-enable the squadViewer test

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6816

Ben Boeckel authored 5 years ago and T.J. Corona committed 4 years ago

Removed in b19ea9ff (!6470) in code, but
not in the CMake.

The check for running this test was based on the old modules, now
updated to VTK 9 modules.  The test was also missing a module
import.

The device pixel scale (for retina etc.) was being used for all
events except for the resize event.  As a result, resizing on a
retina screen caused the rendering to continually flash between
proper size and half size.

Sebastien Jourdain authored 4 years ago and Kitware Robot committed 4 years ago

8e2bb4b8 FindOpenGL: add EMSCRIPTEN special compilation definition

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6794

Lucas Gandel authored 4 years ago and Kitware Robot committed 4 years ago

1e3d0cf5 Fix PrintSelf method call with uninitialized objects

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6801

Add sanity checks to avoid a crash while printing uninitialized objects.
All VTK classes should be printable right after the object is created.

Michael Migliore authored 4 years ago and Kitware Robot committed 4 years ago

c189b271 Correctly set the FullScreen flag with X

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6793

Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

52141065 FindOpenGL: fix EMSCRIPTEN GLES library usage

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !6787

Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

831104d2 Wrapping/Python: skip interpreters for wheel builds
6f7107da vtkWheelPreparation: force some VTK settings
c7becf59 vtkWheelPreparation: only require Module support
ff45e509 Python: only require module support
8f471908 FindPython: update to sync with CMake 3.18

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !6765