Clinton Stimpson authored 7 years ago and Brad King committed 7 years ago

Non-existent names may be created later with a different case.

luzpaz authored 7 years ago and Brad King committed 7 years ago

Found using

    codespell -q 3 --skip="./Utilities" -I .cmake-whitelist.txt`

in CMake whereby the whitelist contained:

    ans
    dum
    helpfull
    emmited
    emmitted
    buil
    iff
    isnt
    nto
    ot
    pathes
    substract
    te
    todays
    upto
    whitespaces

MakeDirectory can create an entire directory structure
so it's convenient that we can set the default directory
permissions for directories that did not exist beforehand.

Only do one conversion attempt and write that directly to the target buffer. Do
the uppercasing of the drive letter only in the ASCII domain, not in wide chars.

This was used only by CMake's get_filename_components() command, which
has now been re-implemented independently.  The operation is not
well-defined (string parsing should not depend on filesystem content),
so remove it.

Steven authored 7 years ago and Brad King committed 7 years ago

Teach `Load` to access the filesystem using extended paths to handle
long absolute paths.  Add a test case.

Previously trying to parse a windows-style (backslash separated) path on
Linux would fail.  Make this function handle either kind of separator on
both platforms.

This method was added recently but we've found another solution for its
intended use case.  Removing empty path elements can corrupt paths that
depend on a trailing empty component to preserve a trailing slash.

Since this method was meant to complement SplitPath and JoinPath, update
their documentation to explain how they treat empty components.

Replace uses of `SystemTools::ConvertToWindowsExtendedPath`.

Move the implementation of `SystemTools::ConvertToWindowsExtendedPath`
over to a new function in `Encoding`.  It does not depend on other
things `SystemTools` and will be useful in other KWSys components
that already depend on `Encoding` but not `SystemTools`.

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Issue: cmake/cmake#16607

The `Touch` method should care about existence and directory creation
should also be guarded against unreadable paths as well. In addition,
fix a path existence check which should have been updated before.

Gregor Jasny authored 8 years ago and Brad King committed 8 years ago

Logic for the size limit argument added by commit 521c5483 (added a
limit to the getline method, 2007-03-01) had an off-by-one error in
truncating the buffer.  Fix it and add a test case.

Kitware Robot authored 8 years ago and Brad King committed 8 years ago

Run the `clang-format.bash` script to update all our C and C++ code to a new
style defined by `.clang-format`.  Use `clang-format` version 3.8.

* If you reached this commit for a line in `git blame`, re-run the blame
  operation starting at the parent of this commit to see older history
  for the content.

* See the parent commit for instructions to rebase a change across this
  style transition commit.

Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5

Per-source copyright/license notice headers that spell out copyright holder
names and years are hard to maintain and often out-of-date or plain wrong.
Precise contributor information is already maintained automatically by the
version control tool.  Ultimately it is the receiver of a file who is
responsible for determining its licensing status, and per-source notices are
merely a convenience.  Therefore it is simpler and more accurate for
each source to have a generic notice of the license name and references to
more detailed information on copyright holders and full license terms.

Our `Copyright.txt` file now contains a list of Contributors whose names
appeared source-level copyright notices.  It also references version control
history for more precise information.  Therefore we no longer need to spell
out the list of Contributors in each source file notice.

Replace KWSys per-source copyright/license notice headers with a short
description of the license and links to `Copyright.txt` and online
information available from "https://cmake.org/licensing#kwsys".

Run the `filter-notices.bash` script to perform the replacements mechanically.
Manually fix up the shebang line in one file.

Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334

The clang-format tool sorts `#include` lines within contiguous blocks.
Separate blocks with blank lines and sort the include lines within them
so that clang-format does not re-order anything.

Change-Id: I96d6828f470b9a234464972172d46afab322487c

The current implementation was added by commit 5c8693bc (remove
redundant function and eliminate need for strcasecmp, 2003-04-11).  The
code was taken from Graphviz in 2003 from a source file that at the time
was distributed under terms of the Common Public License, Version 1.0.
While the actual content is simple and likely not copyrightable, clarify
the licensing status by simply re-implementing the function from scratch
using another approach.

Change-Id: I44f72b215577af9e3de234b5ef03113c580a3bd6

Change-Id: I7b5d0b0edb756989d84d7291467256ad48004398

If only some leading components of the input path exist then convert
those and leave the rest unchanged.  This way if a file path is
constructed using GetActualCaseForPath and created on disk, then a
following GetActualCaseForPath on the same now-existing path will return
the same value.

Change-Id: I6e09a4d411f8bf107312f39d7409ba2d22bf176b
CMake-Issue: 16295

When `GetShortPathNameW` returns a 0 buffer size then we should not call
it again.

Change-Id: I6529013ec3c792796649c25168f6c67b60ac7238

This method checks if a path by the given name exists. The problem with
FileExists is that it returns `false` even for broken (or
self-referential) symlinks which may not be what the user wants.

Change-Id: I71b8af6e12a5ae4b1319a3bec83db6c3cef36f90

Patrick authored 8 years ago and Brad King committed 8 years ago

Take changes used by pkgsrc [1]:

* SCO OpenServer 5.0.7/3.2's command has 711 permission.

[1] http://cdn.netbsd.org/pub/pkgsrc/current/pkgsrc/devel/cmake/patches/

Change-Id: Ib9fd7611e2c0b3e10a75b2322c002a8cb266ea89

Remove the last calls to the GetEnv methods with this signature from
KWSys itself.

Change-Id: I9cdb2b060776a00bb698b396c9b33450237cd0b7

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: I3cdbcb846a205b211ac0f597e2c1c940dc0b7268

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Some GetEnv callers only need to know whether an environment variable
exists, so provide a direct query for this.

Change-Id: Ib754cb122b53a2a7cc4801fc7198cf1d612ef6f4

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded
to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv)
instead and encode that.

Change-Id: I8cb91f2386eb0efe3ef0a3132d1603217d710b60

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Revise code layout to make introduction of wide character APIs cleaner.

Change-Id: I22301f07eba1e13b954eb938da3305f269d8b754

Dāvis Mosāns authored 8 years ago and Brad King committed 8 years ago

Change-Id: If7753c828c211998b76a1706ca7fd35fbb4c1f71

When using `putenv("A=")` to approximate removal of `A` from the
environment we must not free the buffer afterward because the string
is still actually in the environment.

Change-Id: I4d2455ca604a2e216123a3d2afafb64ca260d105
Reported-by: James Johnston <johnstonj.public@codenest.com>

Move `kwsysEnv` storage management into a `kwsysEnvSet` base class.

Change-Id: I022a8620e570394bb1871515c8275c969535c693
Inspired-by: Dāvis Mosāns <davispuh@gmail.com>

Ben Boeckel authored 9 years ago and Brad King committed 8 years ago

Matches the opening of this #ifdef.

Change-Id: I044645285faaed0ac96b5f40af027ec07b73d825